The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Useless control flow in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaDocSearchQueryFormat.buildQueryAgenda(IrbAgendaSearchParameters, RascalUser) | STYLE | UCF_USELESS_CONTROL_FLOW | 72 | Medium |
| Useless control flow in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaDocSearchQueryFormat.buildQueryAgenda(IrbAgendaSearchParameters, RascalUser, String) | STYLE | UCF_USELESS_CONTROL_FLOW | 122 | Medium |
| Useless control flow in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaDocSearchQueryFormat.buildQueryMinutes(IrbAgendaSearchParameters, RascalUser) | STYLE | UCF_USELESS_CONTROL_FLOW | 232 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.buildEventRow(ResultSet, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 78 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getAgendaEventsFor(long, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 461 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getAgendaEventsFor(String, long) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 527 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getAgendaEventsShortFor(long, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 629 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getAgendasForChairApprovalQueue(RascalUser) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 689 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getAgendasForMinuteCreation(RascalUser) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 760 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getApprovedAgendaEventsFor(String, long) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 908 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getAttachedEventsFor(long, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 1207 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getChairCommitteeIdFor(RascalUser) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 1306 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getCommitteeIdFor(RascalUser) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 1363 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getMinutesApprovalEventsFor(long, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 1716 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getMinutesEventsFor(long, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 1902 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getNonRascalEventsFor(long, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 2077 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getSearchAgendas(RascalUser, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 2439 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getSearchMinutes(RascalUser, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 2569 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getSearchMinutes(String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 2487 | Medium |
| Dead store to row in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getAdverseEventForCommittee(long) | STYLE | DLS_DEAD_LOCAL_STORE | 277 | High |
| Dead store to results1 in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getAgendasForChairApprovalQueue(RascalUser) | STYLE | DLS_DEAD_LOCAL_STORE | 662 | High |
| Dead store to results1 in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getApprovedMinutes(RascalUser, String) | STYLE | DLS_DEAD_LOCAL_STORE | 932 | High |
| Dead store to row in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getApprovedPendingProtocolsForCommittee(long) | STYLE | DLS_DEAD_LOCAL_STORE | 1009 | High |
| Dead store to row in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getCommitteeIdFor(RascalUser) | STYLE | DLS_DEAD_LOCAL_STORE | 1335 | High |
| Dead store to row in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getExemptForCommittee(long) | STYLE | DLS_DEAD_LOCAL_STORE | 1468 | High |
| Dead store to row in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getExpeditableForCommittee(long) | STYLE | DLS_DEAD_LOCAL_STORE | 1563 | High |
| Dead store to row in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getModificationsForCommittee(long) | STYLE | DLS_DEAD_LOCAL_STORE | 1974 | High |
| Dead store to row in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getProtocolsForCommittee(long) | STYLE | DLS_DEAD_LOCAL_STORE | 2234 | High |
| Dead store to row in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getRenewalsForCommittee(long) | STYLE | DLS_DEAD_LOCAL_STORE | 2315 | High |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getAdminFor(long) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 263 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.buildEventRow(ResultSet, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 78 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getAgendaEventsFor(long, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 461 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getAgendaEventsFor(String, long) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 527 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getAgendaEventsShortFor(long, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 629 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getAgendasForChairApprovalQueue(RascalUser) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 689 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getAgendasForMinuteCreation(RascalUser) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 760 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getApprovedAgendaEventsFor(String, long) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 908 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getAttachedEventsFor(long, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 1207 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getChairCommitteeIdFor(RascalUser) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 1306 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getCommitteeIdFor(RascalUser) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 1363 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getMinutesApprovalEventsFor(long, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 1716 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getMinutesEventsFor(long, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 1902 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getNonRascalEventsFor(long, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 2077 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getSearchAgendas(RascalUser, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 2439 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getSearchMinutes(RascalUser, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 2569 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getSearchMinutes(String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 2487 | High |
| Nullcheck of eventName at line 1729 of value previously dereferenced in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaProtocolQuery.getMinutesApprovalEventsFor(long, String) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 1608 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaReportQuery.getAgendaDetailInfoByAgendaHeaderId(String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 80 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaReportQuery.getAgendaInfoByNumberReportResults(String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 251 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaReportQuery.getAgendaInfoByPaperNumberReportResults(String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 334 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaReportQuery.getAllActiveAgendas() | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 420 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaReportQuery.getAllActiveCommitteeIds() | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 465 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaReportQuery.getAllPreMeetingAgendas() | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 517 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaReportQuery.getEventDetailsFor(long, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 694 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaReportQuery.getIrbReportAgendaSummaryResults() | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 763 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaReportQuery.getIrbReportAvailableSummaryResults() | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 806 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaReportQuery.getProtocolChildrenFor(String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 1074 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaReportQuery.getProtocolChildrenFor(String, CURascalJdbcAccessor) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 1200 | Medium |
| Dead store to event in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaReportQuery.getAgendaInfoByNumberReportResults(String) | STYLE | DLS_DEAD_LOCAL_STORE | 235 | Medium |
| Dead store to event in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaReportQuery.getAgendaInfoByPaperNumberReportResults(String) | STYLE | DLS_DEAD_LOCAL_STORE | 306 | Medium |
| Dead store to agendas in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaReportQuery.getIrbReportAgendaSummaryResults() | STYLE | DLS_DEAD_LOCAL_STORE | 751 | Medium |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaReportQuery.getAgendaDetailInfoByAgendaHeaderId(String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 80 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaReportQuery.getAgendaInfoByNumberReportResults(String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 251 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaReportQuery.getAgendaInfoByPaperNumberReportResults(String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 334 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaReportQuery.getAllActiveAgendas() | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 420 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaReportQuery.getAllActiveCommitteeIds() | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 465 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaReportQuery.getAllPreMeetingAgendas() | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 517 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaReportQuery.getEventDetailsFor(long, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 694 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaReportQuery.getIrbReportAgendaSummaryResults() | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 763 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaReportQuery.getIrbReportAvailableSummaryResults() | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 806 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaReportQuery.getProtocolChildrenFor(String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 1074 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaReportQuery.getProtocolChildrenFor(String, CURascalJdbcAccessor) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 1200 | High |
| Nullcheck of eventName at line 706 of value previously dereferenced in edu.columbia.rascal.presentation.agenda.jdbc.IrbAgendaReportQuery.getEventDetailsFor(long, String) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 616 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to row in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaAddendumView.addNewAddendum(CUHtmlTable, int) | STYLE | DLS_DEAD_LOCAL_STORE | 147 | Medium |
| Possible null pointer dereference of eventIdProtocolIdentifierMap in new edu.columbia.rascal.presentation.agenda.pages.IrbAgendaAddendumView(Object, RascalUser, List, Map) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 74 | Medium |
| new edu.columbia.rascal.presentation.agenda.pages.IrbAgendaAddendumView(Object, RascalUser, List, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 75 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaAttachEventView.getTableViewTitle(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 425 | Medium |
| edu.columbia.rascal.presentation.agenda.pages.IrbAgendaAttachEventView.buildAttachEventRows(Vector, String) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 299 | Medium |
| edu.columbia.rascal.presentation.agenda.pages.IrbAgendaAttachEventView.buildNonRascalEventRows(Vector, String) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 351 | Medium |
| Dead store to aTable in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaAttachEventView.buildAttachEventRows(Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 263 | Medium |
| Dead store to aTable in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaAttachEventView.buildNonRascalEventRows(Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 317 | Medium |
| Unread field: edu.columbia.rascal.presentation.agenda.pages.IrbAgendaAttachEventView.iAmAdminF | PERFORMANCE | URF_UNREAD_FIELD | 724 | Medium |
| Unread field: edu.columbia.rascal.presentation.agenda.pages.IrbAgendaAttachEventView.iAmChair | PERFORMANCE | URF_UNREAD_FIELD | 725 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused public or protected field: edu.columbia.rascal.presentation.agenda.pages.IrbAgendaCheckView.ah | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaDataSheetView.getTableViewTitle(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 725 | Medium |
| edu.columbia.rascal.presentation.agenda.pages.IrbAgendaDataSheetView.buildAttachEventRows(Vector, String) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 591 | Medium |
| edu.columbia.rascal.presentation.agenda.pages.IrbAgendaDataSheetView.buildNREventRows(Vector, String) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 625 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused public or protected field: edu.columbia.rascal.presentation.agenda.pages.IrbAgendaEventAbstractEntryView.theAddEdit | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaEventPostMeetingView.getTableViewTitle(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 638 | Medium |
| Dead store to aTable in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaEventPostMeetingView.buildNonRascalEventRows(Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 235 | Medium |
| Dead store to text in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaEventPostMeetingView.getObjectDataSheetLinkWidgetFor(IrbAgendaEvent) | STYLE | DLS_DEAD_LOCAL_STORE | 579 | Medium |
| Exception is caught when Exception is not thrown in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaEventPostMeetingView.buildOldBusinessEventRows(Vector, String) | STYLE | REC_CATCH_EXCEPTION | 405 | Medium |
| Exception is caught when Exception is not thrown in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaEventPostMeetingView.buildOtherTopicEventRows(Vector) | STYLE | REC_CATCH_EXCEPTION | 498 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to pb2 in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaEventSearchView.getButtons() | STYLE | DLS_DEAD_LOCAL_STORE | 220 | High |
| Dead store to form in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaEventSearchView.addItems() | STYLE | DLS_DEAD_LOCAL_STORE | 88 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to text in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaHtmlView.getObjectDataSheetLinkWidgetFor(String, String, String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 694 | Medium |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaHtmlView.getTimeString(Date) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 975 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaHtmlView.getYearWidget(String, int) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 1032 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to meeting in new edu.columbia.rascal.presentation.agenda.pages.IrbAgendaLinkFrameView(String, IrbAgendaHeader, RascalUser, String, Boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 176 | Medium |
| Unread field: edu.columbia.rascal.presentation.agenda.pages.IrbAgendaLinkFrameView.iAmAdmin | PERFORMANCE | URF_UNREAD_FIELD | 741 | Medium |
| Unread field: edu.columbia.rascal.presentation.agenda.pages.IrbAgendaLinkFrameView.iAmCommitteeMember | PERFORMANCE | URF_UNREAD_FIELD | 740 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to compositeMenuItem in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaMainMenuView.addItems(RascalUser) | STYLE | DLS_DEAD_LOCAL_STORE | 184 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaMeetingAttendantView.getTableViewTitle(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 410 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused public or protected field: edu.columbia.rascal.presentation.agenda.pages.IrbAgendaMeetingAttributeEntryView.theAddEdit | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaMinutesApprovalView.getTableViewTitle(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 239 | Medium |
| Dead store to aTable in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaMinutesApprovalView.buildAttachEventRows(Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 122 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to xyPosition in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaMinutesDataSheetPDFUtilityView.addBusinessAttached(long, String, Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 309 | Medium |
| Dead store to xyPosition in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaMinutesDataSheetPDFUtilityView.addProtocolAttached(long, String, Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 866 | Medium |
| Dead store to xyPosition in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaMinutesDataSheetPDFUtilityView.addProtocolAttached(String, Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 716 | Medium |
| Possible null pointer dereference of protHeader in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaMinutesDataSheetPDFUtilityView.addBusinessAttached(long, String, Vector, String) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 383 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to xyPosition in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaMinutesDataSheetPDFView.addBusinessAttached(long, String, Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 317 | Medium |
| Dead store to xyPosition in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaMinutesDataSheetPDFView.addProtocolAttached(long, String, Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 874 | Medium |
| Dead store to xyPosition in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaMinutesDataSheetPDFView.addProtocolAttached(String, Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 724 | Medium |
| Possible null pointer dereference of protHeader in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaMinutesDataSheetPDFView.addBusinessAttached(long, String, Vector, String) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 391 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaMinutesDataSheetUtilityView.getTableViewTitle(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 656 | Medium |
| Dead store to aTable in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaMinutesDataSheetUtilityView.buildNREventRows(Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 573 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaMinutesDataSheetView.getTableViewTitle(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 657 | Medium |
| Dead store to aTable in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaMinutesDataSheetView.buildNREventRows(Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 574 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Return value of IrbAgendaHtmlView.getAgendaHeader() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 222 | Medium |
| Unused public or protected field: edu.columbia.rascal.presentation.agenda.pages.IrbAgendaMinutesNewView.valid | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaNewView.getTimeString(Calendar) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 357 | High |
| Return value of IrbAgendaHtmlView.getAgendaHeader() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 205 | Medium |
| Unused public or protected field: edu.columbia.rascal.presentation.agenda.pages.IrbAgendaNewView.valid | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to row in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaObjectHistoryView.addGeneralRows(CUHtmlTable, int) | STYLE | DLS_DEAD_LOCAL_STORE | 216 | Medium |
| Dead store to ah in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaObjectHistoryView.addIrbProtocolHeader() | STYLE | DLS_DEAD_LOCAL_STORE | 227 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaOldBusinessView.getTableViewTitle(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 259 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaOtherTopicView.getTableViewTitle(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 232 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to xyPosition in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaPDFDataSheetView.addBusinessAttached(long, String, Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 424 | Medium |
| Dead store to xyPosition in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaPDFDataSheetView.addProtocolAttached(long, String, Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 778 | Medium |
| Dead store to xyPosition in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaPDFDataSheetView.addProtocolAttached(String, Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 646 | Medium |
| Possible null pointer dereference of protHeader in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaPDFDataSheetView.addBusinessAttached(long, String, Vector, String) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 504 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to xyPosition in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaPDFShortDataSheetView.addBusinessAttached(String, Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 143 | Medium |
| Dead store to xyPosition in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaPDFShortDataSheetView.addProtocolAttached(IrbAgendaHeader, String, Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 302 | Medium |
| Possible null pointer dereference of protHeader in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaPDFShortDataSheetView.addBusinessAttached(String, Vector, String) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 213 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to numPage in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaPDFUtilityView.addSectionTitleLabel(String) | STYLE | DLS_DEAD_LOCAL_STORE | 248 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to numPage in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaPDFView.addSectionTitleLabel(String) | STYLE | DLS_DEAD_LOCAL_STORE | 240 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to row in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaProtocolEventBusinessView.addGeneralRows(CUHtmlTable, int) | STYLE | DLS_DEAD_LOCAL_STORE | 163 | Medium |
| Unused public or protected field: edu.columbia.rascal.presentation.agenda.pages.IrbAgendaProtocolEventBusinessView.parentName | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Medium | |
| Unused public or protected field: edu.columbia.rascal.presentation.agenda.pages.IrbAgendaProtocolEventBusinessView.parentOid | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.agenda.pages.IrbAgendaReportAgendaSummaryView.addAvailableSummaries(Vector, CUHtmlTable) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 266 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaReportAgendaSummaryView.addAvailableSummaries(Vector, CUHtmlTable) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 273 | High |
| Nullcheck of aString at line 558 of value previously dereferenced in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaReportAgendaSummaryView.getWidgetFor(Float) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 556 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of aString at line 399 of value previously dereferenced in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaReportByProtocolNumberView.getWidgetFor(Float) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 397 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to currentAgenda in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaReportDetailDateRangeView.getAgendaDisplayList(Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 205 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.agenda.pages.IrbAgendaResultsDisplayView.buildPageDisplayControl(int, int, int, int, String) uses the same code for two branches | STYLE | DB_DUPLICATE_BRANCHES | 320 | Medium |
| Dead store to docs in new edu.columbia.rascal.presentation.agenda.pages.IrbAgendaResultsDisplayView(Vector, RascalUser) | STYLE | DLS_DEAD_LOCAL_STORE | 82 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to pb2 in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaSearchView.getButtons() | STYLE | DLS_DEAD_LOCAL_STORE | 199 | High |
| Dead store to form in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaSearchView.addItems() | STYLE | DLS_DEAD_LOCAL_STORE | 98 | Medium |
| Dead store to row in edu.columbia.rascal.presentation.agenda.pages.IrbAgendaSearchView.buildSearchFields() | STYLE | DLS_DEAD_LOCAL_STORE | 158 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to headerEntry in edu.columbia.rascal.presentation.agenda.pages.IrbAttachOtherTopicForAgendaOutputView.addEventData(IrbProtocol, String, CUSortVector) | STYLE | DLS_DEAD_LOCAL_STORE | 84 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to endDate in edu.columbia.rascal.presentation.agenda.pages.IrbReportEnterProtocolNumberView.addGeneralRows(CUHtmlTable, int) | STYLE | DLS_DEAD_LOCAL_STORE | 130 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of staff at line 428 of value previously dereferenced in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaAbstractServlet.sendHazMatsTrainingEmails(IrbProtocolHeader, Vector) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 428 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to attached in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaAttachEventSelectServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 158 | High |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaAttachEventSelectServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 354 | Medium |
| Nullcheck of ah at line 169 of value previously dereferenced in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaAttachEventSelectServlet.getPage() | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 169 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to attached in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaAttachEventServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 48 | Medium |
| Dead store to nonRascal in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaAttachEventServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 49 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to committeeId in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaAttachNonRascalEventServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 69 | Medium |
| Nullcheck of ah at line 69 of value previously dereferenced in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaAttachNonRascalEventServlet.getPage() | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 69 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to headerId in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaCheckFinalizeServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 195 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to numberPart in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaCreateServlet.getAgendaId(Long) | STYLE | DLS_DEAD_LOCAL_STORE | 72 | Medium |
| Public static edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaCreateServlet.getLetters() may expose internal representation by returning IrbAgendaCreateServlet.letters | MALICIOUS_CODE | MS_EXPOSE_REP | 60 | Medium |
| Possible null pointer dereference of ah in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaCreateServlet.saveAgendaValues() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 204 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to committeeId in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaDataSheetServlet.getPDFPage() | STYLE | DLS_DEAD_LOCAL_STORE | 159 | Medium |
| Dead store to committeeId in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaDataSheetServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 69 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to updateQuery in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaDatabaseStoreUtilityServlet.databasePersist(IrbAgendaHeader, ByteArrayOutputStream, String) | STYLE | DLS_DEAD_LOCAL_STORE | 121 | Medium |
| Null pointer dereference of setPDF in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaDatabaseStoreUtilityServlet.databasePersist(IrbAgendaHeader, ByteArrayOutputStream, String) | CORRECTNESS | NP_ALWAYS_NULL | 124 | High |
| Redundant nullcheck of page, which is known to be non-null in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaDatabaseStoreUtilityServlet.doGet(HttpServletRequest, HttpServletResponse) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 172 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaEventAbstractEntryServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 104 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to agendaEvents in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaEventHistoryServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 64 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to attached in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaEventPostMeetingServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 48 | Medium |
| Dead store to nonRascal in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaEventPostMeetingServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 49 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to ru in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaEventRemoveServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 53 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaEventSearchServlet.prepareText(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 91 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to ah in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaFinalizeServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 43 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to currentAttendants in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaMeetingAttendantEntryServlet.submit() | STYLE | DLS_DEAD_LOCAL_STORE | 154 | Medium |
| Dead store to oid in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaMeetingAttendantEntryServlet.submit() | STYLE | DLS_DEAD_LOCAL_STORE | 153 | Medium |
| Null passed for non-null parameter of checkConflicts(RascalUser, String) in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaMeetingAttendantEntryServlet.submit() | CORRECTNESS | NP_NULL_PARAM_DEREF | 185 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to ru in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaMeetingAttendantRemoveServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 47 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to ah in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaMeetingAttributeEntryServlet.submit() | STYLE | DLS_DEAD_LOCAL_STORE | 154 | Medium |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaMeetingAttributeEntryServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 224 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to frames in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaMinutesApprovalServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 48 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of expiration, which is known to be non-null in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaMinutesChairApprovalServlet.checkExpiration(IrbAgendaEvent) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 265 | Medium |
| Nullcheck of ph at line 534 of value previously dereferenced in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaMinutesChairApprovalServlet.generateEmail(int, IrbCorrespondence, String) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 532 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of ph at line 346 of value previously dereferenced in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaMinutesChairSingleEventApprovalServlet.generateEmail(int, IrbCorrespondence, String) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 344 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to link in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaNewServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 68 | Medium |
| Possible null pointer dereference of agenda in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaNewServlet.getPage() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 77 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaOtherTopicEntryServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 112 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to ru in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaRemoveServlet.doGet(HttpServletRequest, HttpServletResponse) | STYLE | DLS_DEAD_LOCAL_STORE | 179 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to currentRow in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaReportDetailServlet.processResults(Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 146 | Medium |
| Dead store to reviewerString in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaReportDetailServlet.processResults(Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 147 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaSearchServlet.prepareText(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 134 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to exemptAttached in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaShortDataSheetServlet.getPDFPage() | STYLE | DLS_DEAD_LOCAL_STORE | 80 | Medium |
| Dead store to expeditableAttached in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaShortDataSheetServlet.getPDFPage() | STYLE | DLS_DEAD_LOCAL_STORE | 77 | Medium |
| Dead store to pendingAttached in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaShortDataSheetServlet.getPDFPage() | STYLE | DLS_DEAD_LOCAL_STORE | 81 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to currentRow in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaSummaryReportServlet.processAssignedResults(Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 154 | Medium |
| Dead store to currentRow in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaSummaryReportServlet.processAvailableResults(Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 214 | Medium |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaSummaryReportServlet.processAssignedResults(Vector) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 175 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.agenda.servlets.IrbAgendaSummaryReportServlet.processAssignedResults(Vector) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 178 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to protocolNumber in edu.columbia.rascal.presentation.agenda.servlets.IrbAttachOtherTopicForAgendaOutputServlet.submit() | STYLE | DLS_DEAD_LOCAL_STORE | 80 | Medium |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.agenda.servlets.IrbAttachOtherTopicForAgendaOutputServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 104 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.agenda.servlets.IrbMinuteSearchServlet.prepareText(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 134 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of is in edu.columbia.rascal.presentation.agenda.servlets.IrbStoredAgendaRetrieveServlet.doGet(HttpServletRequest, HttpServletResponse) on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 91 | Medium |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.agenda.servlets.IrbStoredAgendaRetrieveServlet.doGet(HttpServletRequest, HttpServletResponse) on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 107 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization and update of static field edu.columbia.rascal.presentation.annualcoi.tools.CoiAnnualEmailMonitor.timer in edu.columbia.rascal.presentation.annualcoi.tools.CoiAnnualEmailMonitor.start() | MT_CORRECTNESS | LI_LAZY_INIT_UPDATE_STATIC | 52 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null passed for non-null parameter of edu.columbia.rascal.presentation.tools.emailDistributor.CURascalEmailSender.sendEmail(CURascalEmailMessage) in edu.columbia.rascal.presentation.annualcoi.tools.CoiAnnualEmailTask.generateNotificationEmails(List) | CORRECTNESS | NP_NULL_PARAM_DEREF | 158 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Public static edu.columbia.rascal.presentation.appendix.auxiliary.AppendixMap.getAppendixLetterCodeMap() may expose internal representation by returning AppendixMap.appendixLetterCodeMap | MALICIOUS_CODE | MS_EXPOSE_REP | 86 | Medium |
| Public static edu.columbia.rascal.presentation.appendix.auxiliary.AppendixMap.getappendixPageTitleMap() may expose internal representation by returning AppendixMap.appendixPageTitleTable | MALICIOUS_CODE | MS_EXPOSE_REP | 96 | Medium |
| Public static edu.columbia.rascal.presentation.appendix.auxiliary.AppendixMap.getappendixShortLabelMap() may expose internal representation by returning AppendixMap.appendixShortLabelTable | MALICIOUS_CODE | MS_EXPOSE_REP | 106 | Medium |
| edu.columbia.rascal.presentation.appendix.auxiliary.AppendixMap.appendixPageTitleTable is a mutable collection which should be package protected | MALICIOUS_CODE | MS_MUTABLE_COLLECTION_PKGPROTECT | 57 | Medium |
| edu.columbia.rascal.presentation.appendix.auxiliary.AppendixMap.appendixShortLabelTable is a mutable collection which should be package protected | MALICIOUS_CODE | MS_MUTABLE_COLLECTION_PKGPROTECT | 43 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new edu.columbia.rascal.presentation.appendix.auxiliary.AppendixOwnerSurrogate(Hashtable) may expose internal representation by storing an externally mutable object into AppendixOwnerSurrogate.ownerData | MALICIOUS_CODE | EI_EXPOSE_REP2 | 57 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return false in edu.columbia.rascal.presentation.appendix.jdbc.AppendixJdbcAccessor.processResultSet(List, String), since a java.util.Hashtable can't be a java.util.Vector | CORRECTNESS | BC_IMPOSSIBLE_INSTANCEOF | 152 | Medium |
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.appendix.jdbc.AppendixJdbcAccessor.processResultSet(List, String), since all java.util.Hashtable are instances of java.util.Hashtable | STYLE | BC_VACUOUS_INSTANCEOF | 157 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to memberSites in edu.columbia.rascal.presentation.appendix.jdbc.AppendixWorkListQueryFormat.buildQueryForAnimalCareForSafetyOfficerToApproveList() | STYLE | DLS_DEAD_LOCAL_STORE | 1433 | Medium |
| Dead store to inOrNotInExpression in edu.columbia.rascal.presentation.appendix.jdbc.AppendixWorkListQueryFormat.buildQueryForVeterinarianViewList(Vector, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 3039 | Medium |
| edu.columbia.rascal.presentation.appendix.jdbc.AppendixWorkListQueryFormat.buildExpressionInOrNotInSet(Vector, boolean) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 105 | Medium |
| edu.columbia.rascal.presentation.appendix.jdbc.AppendixWorkListQueryFormat.buildWhereClauseForSelection(CURascalBasicSearchParameter, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 3110 | Medium |
| edu.columbia.rascal.presentation.appendix.jdbc.AppendixWorkListQueryFormat.buildWhereClauseForSelectionByExactMatch(CURascalBasicSearchParameter, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 3197 | Medium |
| Switch statement found in edu.columbia.rascal.presentation.appendix.jdbc.AppendixWorkListQueryFormat.buildWhereClauseForSelection(CURascalBasicSearchParameter, String) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 3094 | Medium |
| Switch statement found in edu.columbia.rascal.presentation.appendix.jdbc.AppendixWorkListQueryFormat.buildWhereClauseForSelectionByExactMatch(CURascalBasicSearchParameter, String) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 3182 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: edu.columbia.rascal.presentation.appendix.pages.AppendixASafetyOfficerApprovalView.formName; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 41 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to t in edu.columbia.rascal.presentation.appendix.pages.AppendixAView.stringtoVector(String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 269 | Medium |
| Useless object stored in variable selected of method edu.columbia.rascal.presentation.appendix.pages.AppendixAView.fieldGet_1B_DnaInsertsSource(String, boolean) | STYLE | UC_USELESS_OBJECT | 950 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Suspicious comparison of Integer references in edu.columbia.rascal.presentation.appendix.pages.AppendixAccessControlView.setControlTableDataRow(CUHtmlTable, int, AppendixAccessControl) | CORRECTNESS | RC_REF_COMPARISON | 306 | High |
| Useless object stored in variable columns of method edu.columbia.rascal.presentation.appendix.pages.AppendixAccessControlView.buildControlRows(Vector) | STYLE | UC_USELESS_OBJECT | 163 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.appendix.pages.AppendixAccessQueueView.setAccessQueueViewTableDataRow(CUHtmlTable, int, Hashtable) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 238 | High |
| Redundant nullcheck of locked, which is known to be non-null in edu.columbia.rascal.presentation.appendix.pages.AppendixAccessQueueView.setAccessQueueViewTableDataRow(CUHtmlTable, int, Hashtable) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 305 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to values in edu.columbia.rascal.presentation.appendix.pages.AppendixAnimalCareAbstractView.render() | STYLE | DLS_DEAD_LOCAL_STORE | 429 | High |
| Dead store to oid in edu.columbia.rascal.presentation.appendix.pages.AppendixAnimalCareAbstractView.setStatusTableDataRow(CUHtmlTable, int, String, String, String, String, String, String, int, int) | STYLE | DLS_DEAD_LOCAL_STORE | 900 | Medium |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.appendix.pages.AppendixAnimalCareAbstractView.setStatusTableData(CUHtmlTable, int, Vector) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 833 | High |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.appendix.pages.AppendixAnimalCareAbstractView.setStatusTableDataRow(CUHtmlTable, int, String, String, String, String, String, String, int, int) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 900 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: edu.columbia.rascal.presentation.appendix.pages.AppendixAnimalCareActionPopupView.aStatusOid | PERFORMANCE | URF_UNREAD_FIELD | 65 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of dateString, which is known to be non-null in edu.columbia.rascal.presentation.appendix.pages.AppendixAnimalCareCorrespondenceReadOnlyPopupView.addFields() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 194 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: edu.columbia.rascal.presentation.appendix.pages.AppendixAuthorizedPersonEntryView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.appendix.pages.AppendixAuthorizedPersonView.getTableViewTitle(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 242 | Medium |
| Possible null pointer dereference of authorized in edu.columbia.rascal.presentation.appendix.pages.AppendixAuthorizedPersonView.setAuthorizedTableDataRow(CUHtmlTable, int) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 305 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: edu.columbia.rascal.presentation.appendix.pages.AppendixBSafetyOfficerApprovalView.formName; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 42 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: edu.columbia.rascal.presentation.appendix.pages.AppendixCSafetyOfficerApprovalView.formName; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 41 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.appendix.pages.AppendixChemicalEntryView.getParmTable() may expose internal representation by returning AppendixChemicalEntryView.parmTable | MALICIOUS_CODE | EI_EXPOSE_REP | 332 | Medium |
| edu.columbia.rascal.presentation.appendix.pages.AppendixChemicalEntryView.setParmTable(Hashtable) may expose internal representation by storing an externally mutable object into AppendixChemicalEntryView.parmTable | MALICIOUS_CODE | EI_EXPOSE_REP2 | 560 | Medium |
| Unused field: edu.columbia.rascal.presentation.appendix.pages.AppendixChemicalEntryView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to aBuffer in edu.columbia.rascal.presentation.appendix.pages.AppendixDReportView.addApprovalFields() | STYLE | DLS_DEAD_LOCAL_STORE | 230 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: edu.columbia.rascal.presentation.appendix.pages.AppendixDSafetyOfficerApprovalView.formName; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 40 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.appendix.pages.AppendixDView.getDateTable(String, String, String, String, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 226 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.appendix.pages.AppendixDView.getYearWidget(String, int) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 365 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to row in edu.columbia.rascal.presentation.appendix.pages.AppendixEReportView.getChemicalLocationsTable(AppendixChemical) | STYLE | DLS_DEAD_LOCAL_STORE | 331 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: edu.columbia.rascal.presentation.appendix.pages.AppendixESafetyOfficerApprovalView.formName; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 44 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: edu.columbia.rascal.presentation.appendix.pages.AppendixFSafetyOfficerApprovalView.formName; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 43 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.appendix.pages.AppendixGIsotopeEntryView.getParmTable() may expose internal representation by returning AppendixGIsotopeEntryView.parmTable | MALICIOUS_CODE | EI_EXPOSE_REP | 497 | Medium |
| edu.columbia.rascal.presentation.appendix.pages.AppendixGIsotopeEntryView.setParmTable(Hashtable) may expose internal representation by storing an externally mutable object into AppendixGIsotopeEntryView.parmTable | MALICIOUS_CODE | EI_EXPOSE_REP2 | 551 | Medium |
| Unused field: edu.columbia.rascal.presentation.appendix.pages.AppendixGIsotopeEntryView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to apxG in edu.columbia.rascal.presentation.appendix.pages.AppendixGReportView.addTopFields() | STYLE | DLS_DEAD_LOCAL_STORE | 363 | Medium |
| Redundant nullcheck of aValue, which is known to be non-null in edu.columbia.rascal.presentation.appendix.pages.AppendixGReportView.fieldGet_2_SurvivalTime() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 1593 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: edu.columbia.rascal.presentation.appendix.pages.AppendixGSafetyOfficerApprovalView.formName; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 43 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.appendix.pages.AppendixHtmlView.getTableCellData(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 1791 | Medium |
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.appendix.pages.AppendixHtmlView.getTableCellData(String, String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 1815 | Medium |
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.appendix.pages.AppendixHtmlView.getTableViewTitle(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 1877 | Medium |
| Dead store to values in edu.columbia.rascal.presentation.appendix.pages.AppendixHtmlView.render() | STYLE | DLS_DEAD_LOCAL_STORE | 2052 | High |
| Dead store to allLocations in edu.columbia.rascal.presentation.appendix.pages.AppendixHtmlView.getLocationReportRows(String) | STYLE | DLS_DEAD_LOCAL_STORE | 1191 | Medium |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.appendix.pages.AppendixHtmlView.getDateTable(String, String, String, String, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 396 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.appendix.pages.AppendixHtmlView.getYearWidget(String, int) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 2023 | High |
| Nullcheck of current at line 2449 of value previously dereferenced in edu.columbia.rascal.presentation.appendix.pages.AppendixHtmlView.getAnimalCareStatusDisplayValue(String) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 2445 | Medium |
| Value of verbiage from previous case is overwritten here due to switch statement fall through | CORRECTNESS | SF_DEAD_STORE_DUE_TO_SWITCH_FALLTHROUGH | 2502 | High |
| Switch statement found in edu.columbia.rascal.presentation.appendix.pages.AppendixHtmlView.getAppendixOnlineTitle() where one case falls through to the next case | STYLE | SF_SWITCH_FALLTHROUGH | 2499 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to row in edu.columbia.rascal.presentation.appendix.pages.AppendixIContrSubsEntryView.addGeneralRows(CUHtmlTable, int) | STYLE | DLS_DEAD_LOCAL_STORE | 91 | Medium |
| Useless object stored in variable columns of method edu.columbia.rascal.presentation.appendix.pages.AppendixIContrSubsEntryView.addGeneralRows(CUHtmlTable, int) | STYLE | UC_USELESS_OBJECT | 87 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to cols in edu.columbia.rascal.presentation.appendix.pages.AppendixIReportView.addGeneralFields(boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 508 | Medium |
| Dead store to row in edu.columbia.rascal.presentation.appendix.pages.AppendixIReportView.getLocationsTable(AppendixIControlSubs) | STYLE | DLS_DEAD_LOCAL_STORE | 638 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: edu.columbia.rascal.presentation.appendix.pages.AppendixISafetyOfficerApprovalView.formName; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 31 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to t in edu.columbia.rascal.presentation.appendix.pages.AppendixIView.stringtoVector(String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 775 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to invitroHiddenField in new edu.columbia.rascal.presentation.appendix.pages.AppendixInvitroTitleModifyView(String, RascalUser) | STYLE | DLS_DEAD_LOCAL_STORE | 57 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to values in edu.columbia.rascal.presentation.appendix.pages.AppendixIrbAbstractView.render() | STYLE | DLS_DEAD_LOCAL_STORE | 319 | High |
| Dead store to ph in edu.columbia.rascal.presentation.appendix.pages.AppendixIrbAbstractView.getWhatHappenedFor(IrbStatus) | STYLE | DLS_DEAD_LOCAL_STORE | 258 | Medium |
| edu.columbia.rascal.presentation.appendix.pages.AppendixIrbAbstractView.getWhatHappenedFor(IrbStatus) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 288 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.appendix.pages.AppendixIsotopeEntryView.getParmTable() may expose internal representation by returning AppendixIsotopeEntryView.parmTable | MALICIOUS_CODE | EI_EXPOSE_REP | 497 | Medium |
| edu.columbia.rascal.presentation.appendix.pages.AppendixIsotopeEntryView.setParmTable(Hashtable) may expose internal representation by storing an externally mutable object into AppendixIsotopeEntryView.parmTable | MALICIOUS_CODE | EI_EXPOSE_REP2 | 551 | Medium |
| Unused field: edu.columbia.rascal.presentation.appendix.pages.AppendixIsotopeEntryView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to values in edu.columbia.rascal.presentation.appendix.pages.AppendixLabAbstractView.render() | STYLE | DLS_DEAD_LOCAL_STORE | 328 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: edu.columbia.rascal.presentation.appendix.pages.AppendixLabCorrespondenceCreateView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to appendixHeaderNumber in edu.columbia.rascal.presentation.appendix.pages.AppendixLinkFrameAbstractView.addInvitroLink(String) | STYLE | DLS_DEAD_LOCAL_STORE | 573 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to param1 in new edu.columbia.rascal.presentation.appendix.pages.AppendixLinkFrameAnimalCareReadOnlyView(IacucProtocolHeader, String, RascalUser) | STYLE | DLS_DEAD_LOCAL_STORE | 46 | Medium |
| Dead store to protNum in new edu.columbia.rascal.presentation.appendix.pages.AppendixLinkFrameAnimalCareReadOnlyView(IacucProtocolHeader, String, RascalUser) | STYLE | DLS_DEAD_LOCAL_STORE | 45 | Medium |
| Dead store to protOid in new edu.columbia.rascal.presentation.appendix.pages.AppendixLinkFrameAnimalCareReadOnlyView(IacucProtocolHeader, String, RascalUser) | STYLE | DLS_DEAD_LOCAL_STORE | 44 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to param1 in edu.columbia.rascal.presentation.appendix.pages.AppendixLinkFrameAnimalCareView.addAppendixApproveLinks(IacucProtocolHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 138 | Medium |
| Dead store to protOid in edu.columbia.rascal.presentation.appendix.pages.AppendixLinkFrameAnimalCareView.addAppendixApproveLinks(IacucProtocolHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 137 | Medium |
| Dead store to protOid in edu.columbia.rascal.presentation.appendix.pages.AppendixLinkFrameAnimalCareView.addAppendixReviewLinks(IacucProtocolHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 432 | Medium |
| Dead store to protOid in edu.columbia.rascal.presentation.appendix.pages.AppendixLinkFrameAnimalCareView.addHistoryLinks(IacucProtocolHeader, String) | STYLE | DLS_DEAD_LOCAL_STORE | 618 | Medium |
| Dead store to protOid in edu.columbia.rascal.presentation.appendix.pages.AppendixLinkFrameAnimalCareView.addProtocolDatasheetLink(IacucProtocolHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 662 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to param1 in edu.columbia.rascal.presentation.appendix.pages.AppendixLinkFrameIrbView.addAppendixApproveLinks(IrbProtocolHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 142 | Medium |
| Dead store to protOid in edu.columbia.rascal.presentation.appendix.pages.AppendixLinkFrameIrbView.addAppendixApproveLinks(IrbProtocolHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 140 | Medium |
| Dead store to protOid in edu.columbia.rascal.presentation.appendix.pages.AppendixLinkFrameIrbView.addAppendixReviewLinks(IrbProtocolHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 333 | Medium |
| Dead store to protOid in edu.columbia.rascal.presentation.appendix.pages.AppendixLinkFrameIrbView.addProtocolDatasheetLink(IrbProtocolHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 542 | Medium |
| Dead store to protOid in edu.columbia.rascal.presentation.appendix.pages.AppendixLinkFrameIrbView.addStudyDescriptionDataSheetLink(IrbProtocolHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 565 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to param1 in edu.columbia.rascal.presentation.appendix.pages.AppendixLinkFrameLabView.addAppendixApproveLinks(HzAppendixHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 149 | Medium |
| Dead store to protOid in edu.columbia.rascal.presentation.appendix.pages.AppendixLinkFrameLabView.addAppendixApproveLinks(HzAppendixHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 148 | Medium |
| Dead store to protOid in edu.columbia.rascal.presentation.appendix.pages.AppendixLinkFrameLabView.addAppendixReviewLinks(HzAppendixHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 254 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to anId in edu.columbia.rascal.presentation.appendix.pages.AppendixMainMenuView.addItems() | STYLE | DLS_DEAD_LOCAL_STORE | 96 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to f1 in edu.columbia.rascal.presentation.appendix.pages.AppendixMainView.addItems() | STYLE | DLS_DEAD_LOCAL_STORE | 76 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.appendix.pages.AppendixOwnerAbstractSummaryView.appendixStatusConversionTable is a mutable collection which should be package protected | MALICIOUS_CODE | MS_MUTABLE_COLLECTION_PKGPROTECT | 34 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to appendixOid in edu.columbia.rascal.presentation.appendix.pages.AppendixOwnersDisplayView.setOwnerDisplayViewTableDataRow(CUHtmlTable, int, Hashtable) | STYLE | DLS_DEAD_LOCAL_STORE | 196 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.appendix.pages.AppendixQueueView.getInstruction(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 85 | Medium |
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.appendix.pages.AppendixQueueView.getTableCellData(String, String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 181 | Medium |
| Unused public or protected field: edu.columbia.rascal.presentation.appendix.pages.AppendixQueueView.subTitle | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: edu.columbia.rascal.presentation.appendix.pages.AppendixReportDateRangeView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to anId in edu.columbia.rascal.presentation.appendix.pages.AppendixReportMenuView.addItems() | STYLE | DLS_DEAD_LOCAL_STORE | 62 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.appendix.pages.AppendixReportProtocolHazMatView.getInstruction(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 415 | Medium |
| Dead store to columns in edu.columbia.rascal.presentation.appendix.pages.AppendixReportProtocolHazMatView.addKey() | STYLE | DLS_DEAD_LOCAL_STORE | 320 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.appendix.pages.AppendixReportPtHazMatView.getInstruction(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 402 | Medium |
| Dead store to columns in edu.columbia.rascal.presentation.appendix.pages.AppendixReportPtHazMatView.addKey() | STYLE | DLS_DEAD_LOCAL_STORE | 307 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to docs in new edu.columbia.rascal.presentation.appendix.pages.AppendixRetrievalDisplayView(Vector, RascalUser) | STYLE | DLS_DEAD_LOCAL_STORE | 41 | High |
| Dead store to docs in new edu.columbia.rascal.presentation.appendix.pages.AppendixRetrievalDisplayView(Vector, RascalUser, String) | STYLE | DLS_DEAD_LOCAL_STORE | 80 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of convert1, which is known to be non-null in edu.columbia.rascal.presentation.appendix.pages.AppendixSafetyOfficerApprovedQueueView.setAnimalCareQueueViewTableDataRow(CUHtmlTable, int, Hashtable) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 259 | Medium |
| Redundant nullcheck of convert1, which is known to be non-null in edu.columbia.rascal.presentation.appendix.pages.AppendixSafetyOfficerApprovedQueueView.setIrbQueueViewTableDataRow(CUHtmlTable, int, Hashtable) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 400 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Repeated conditional test in edu.columbia.rascal.presentation.appendix.pages.AppendixStaffHandlesHazmatView.addGeneralRows(CUHtmlTable, int) | CORRECTNESS | RpC_REPEATED_CONDITIONAL_TEST | 154 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: edu.columbia.rascal.presentation.appendix.pages.AppendixVeterinarianApprovalQueueView.queueType | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of convert1, which is known to be non-null in edu.columbia.rascal.presentation.appendix.pages.AppendixVeterinarianApprovedQueueView.setAnimalCareQueueViewTableDataRow(CUHtmlTable, int, Hashtable) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 194 | Medium |
| Unused field: edu.columbia.rascal.presentation.appendix.pages.AppendixVeterinarianApprovedQueueView.queueType | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.appendix.pages.AppendixView.getTableViewTitle(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 333 | Medium |
| Dead store to currentRow in edu.columbia.rascal.presentation.appendix.pages.AppendixView.addPersonnelDisplayList() | STYLE | DLS_DEAD_LOCAL_STORE | 772 | Medium |
| Dead store to row1 in edu.columbia.rascal.presentation.appendix.pages.AppendixView.addPersonnelDisplayList() | STYLE | DLS_DEAD_LOCAL_STORE | 773 | Medium |
| Dead store to row2 in edu.columbia.rascal.presentation.appendix.pages.AppendixView.addPersonnelDisplayList() | STYLE | DLS_DEAD_LOCAL_STORE | 774 | Medium |
| Suspicious comparison of Long references in edu.columbia.rascal.presentation.appendix.pages.AppendixView.addHazMatsTrainingInfo(Integer, CUHtmlTableRow) | CORRECTNESS | RC_REF_COMPARISON | 524 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to numberPart in edu.columbia.rascal.presentation.appendix.servlets.AppendixAbstractServlet.generateNewProtocolNumber(HzAppendixHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 124 | Medium |
| Redundant nullcheck of aStatusRec, which is known to be non-null in edu.columbia.rascal.presentation.appendix.servlets.AppendixAbstractServlet.getOwnerSurrogate(IrbProtocolHeader) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 1879 | Medium |
| Nullcheck of it at line 423 of value previously dereferenced in edu.columbia.rascal.presentation.appendix.servlets.AppendixAbstractServlet.getAccessibleByHzUser(RascalUser, HzAppendixHeader) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 423 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to anAppendix in edu.columbia.rascal.presentation.appendix.servlets.AppendixAccessControlEntryServlet.saveAccessControlEditValues(RascalUser, String) | STYLE | DLS_DEAD_LOCAL_STORE | 85 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to anAppendix in edu.columbia.rascal.presentation.appendix.servlets.AppendixAccessControlRemoveServlet.deleteAppendixAccessControlByOid(long) | STYLE | DLS_DEAD_LOCAL_STORE | 52 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to iph in edu.columbia.rascal.presentation.appendix.servlets.AppendixAnimalCareCorrespondenceReadOnlyPopupServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 104 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Load of known null value in edu.columbia.rascal.presentation.appendix.servlets.AppendixAnimalCareSafetyOfficerSummaryServlet.getPage() | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 62 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Load of known null value in edu.columbia.rascal.presentation.appendix.servlets.AppendixAnimalCareSummaryReadOnlyServlet.getPage() | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 61 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to uni in edu.columbia.rascal.presentation.appendix.servlets.AppendixApproverViewReleasedQueueServlet.validateGet() | STYLE | DLS_DEAD_LOCAL_STORE | 149 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.appendix.servlets.AppendixAttachSelectionServlet.getPage() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 114 | Medium |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.appendix.servlets.AppendixAttachSelectionServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 259 | Medium |
| Null passed for non-null parameter of AppendixAbstractServlet.regulateHazardFlag(long, String, String, boolean) in edu.columbia.rascal.presentation.appendix.servlets.AppendixAttachSelectionServlet.saveTrackingValues() | CORRECTNESS | NP_NULL_PARAM_DEREF | 229 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.appendix.servlets.AppendixCertifyServlet.getPage() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 93 | Medium |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.appendix.servlets.AppendixCertifyServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 124 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.appendix.servlets.AppendixChemicalEntryServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 300 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to aNumber in edu.columbia.rascal.presentation.appendix.servlets.AppendixCopyServlet.copyAppendixA(RascalUser, AppendixA) | STYLE | DLS_DEAD_LOCAL_STORE | 312 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.appendix.servlets.AppendixDisplaySelectionListServlet.getPage() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 65 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.appendix.servlets.AppendixGIsotopeEntryServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 311 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to locationNum in edu.columbia.rascal.presentation.appendix.servlets.AppendixIContrSubsEntryServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 31 | Medium |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.appendix.servlets.AppendixIContrSubsEntryServlet.closePopup() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 262 | Medium |
| Exception is caught when Exception is not thrown in edu.columbia.rascal.presentation.appendix.servlets.AppendixIContrSubsEntryServlet.submit() | STYLE | REC_CATCH_EXCEPTION | 240 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Switch statement found in edu.columbia.rascal.presentation.appendix.servlets.AppendixInvitroAndAppendixDeleteServlet.deleteHeaderObject(AbstractAppendix) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 171 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to success in edu.columbia.rascal.presentation.appendix.servlets.AppendixInvitroDeleteServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 182 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null passed for non-null parameter of checkHasInvestigator(HzAppendixHeader) in edu.columbia.rascal.presentation.appendix.servlets.AppendixInvitroPreSubmitServlet.getPage() | CORRECTNESS | NP_NULL_PARAM_DEREF | 254 | Medium |
| Switch statement found in edu.columbia.rascal.presentation.appendix.servlets.AppendixInvitroPreSubmitServlet.releaseAppendix() where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 286 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to protOid in edu.columbia.rascal.presentation.appendix.servlets.AppendixIrbSafetyOfficerSummaryServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 49 | Medium |
| Load of known null value in edu.columbia.rascal.presentation.appendix.servlets.AppendixIrbSafetyOfficerSummaryServlet.getPage() | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 65 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to protOid in edu.columbia.rascal.presentation.appendix.servlets.AppendixIrbSummaryReadOnlyServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 49 | Medium |
| Load of known null value in edu.columbia.rascal.presentation.appendix.servlets.AppendixIrbSummaryReadOnlyServlet.getPage() | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 63 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.appendix.servlets.AppendixIsotopeEntryServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 311 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to aUser in edu.columbia.rascal.presentation.appendix.servlets.AppendixLabCorrespondenceCreateServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 115 | Medium |
| Dead store to aRole in edu.columbia.rascal.presentation.appendix.servlets.AppendixLabCorrespondenceCreateServlet.saveCorrespondenceValues() | STYLE | DLS_DEAD_LOCAL_STORE | 140 | Medium |
| Dead store to eventInitiatorRid in edu.columbia.rascal.presentation.appendix.servlets.AppendixLabCorrespondenceCreateServlet.saveCorrespondenceValues() | STYLE | DLS_DEAD_LOCAL_STORE | 149 | Medium |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.appendix.servlets.AppendixLabCorrespondenceCreateServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 244 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to protOid in edu.columbia.rascal.presentation.appendix.servlets.AppendixLabSafetyOfficerSummaryServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 78 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.appendix.servlets.AppendixLocationEntryServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 203 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.appendix.servlets.AppendixLogoFrameServlet.sessionIsValid(), since all javax.servlet.http.HttpSession are instances of javax.servlet.http.HttpSession | STYLE | BC_VACUOUS_INSTANCEOF | 71 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to appendixTable in edu.columbia.rascal.presentation.appendix.servlets.AppendixPtHazMatConversionServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 104 | High |
| Found reliance on default encoding in edu.columbia.rascal.presentation.appendix.servlets.AppendixPtHazMatConversionServlet.getPage(): new java.io.FileWriter(String) | I18N | DM_DEFAULT_ENCODING | 99 | High |
| outRecord is null guaranteed to be dereferenced in edu.columbia.rascal.presentation.appendix.servlets.AppendixPtHazMatConversionServlet.getPage() on exception path | CORRECTNESS | NP_GUARANTEED_DEREF_ON_EXCEPTION_PATH | 252 | Medium |
| Exception is caught when Exception is not thrown in edu.columbia.rascal.presentation.appendix.servlets.AppendixPtHazMatConversionServlet.getPage() | STYLE | REC_CATCH_EXCEPTION | 219 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to uni in edu.columbia.rascal.presentation.appendix.servlets.AppendixReportProtocolHazMatServlet.validateGet() | STYLE | DLS_DEAD_LOCAL_STORE | 216 | Medium |
| Comparison of String objects using == or != in edu.columbia.rascal.presentation.appendix.servlets.AppendixReportProtocolHazMatServlet.getPage() | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 175 | Medium |
| Comparison of String objects using == or != in edu.columbia.rascal.presentation.appendix.servlets.AppendixReportProtocolHazMatServlet.getPage() | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 168 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to uni in edu.columbia.rascal.presentation.appendix.servlets.AppendixReportPtHazMatServlet.validateGet() | STYLE | DLS_DEAD_LOCAL_STORE | 181 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to appendixNumber in edu.columbia.rascal.presentation.appendix.servlets.AppendixRetrieveServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 82 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to uni in edu.columbia.rascal.presentation.appendix.servlets.AppendixSafetyOfficerApprovalQueueServlet.validateGet() | STYLE | DLS_DEAD_LOCAL_STORE | 219 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to header in edu.columbia.rascal.presentation.appendix.servlets.AppendixSafetyOfficerApprovalServlet.saveAppendixTrackingValues(AppendixTracking) | STYLE | DLS_DEAD_LOCAL_STORE | 298 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to uni in edu.columbia.rascal.presentation.appendix.servlets.AppendixSafetyOfficerApprovedQueueServlet.validateGet() | STYLE | DLS_DEAD_LOCAL_STORE | 159 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.appendix.servlets.AppendixSearchParmsEntryServlet.prepareText(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 212 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to procRsltMethodNm in edu.columbia.rascal.presentation.appendix.servlets.AppendixSearchServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 81 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of staffMember in edu.columbia.rascal.presentation.appendix.servlets.AppendixStaffHandlesHazmatServlet.saveStaffHandleHazmatValues() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 105 | Medium |
| Possible null pointer dereference of staffMember in edu.columbia.rascal.presentation.appendix.servlets.AppendixStaffHandlesHazmatServlet.saveStaffHandleHazmatValues() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 135 | Medium |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.appendix.servlets.AppendixStaffHandlesHazmatServlet.getPage() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 71 | Medium |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.appendix.servlets.AppendixStaffHandlesHazmatServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 163 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to uni in edu.columbia.rascal.presentation.appendix.servlets.AppendixVeterinarianApprovalQueueServlet.validateGet() | STYLE | DLS_DEAD_LOCAL_STORE | 144 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to uni in edu.columbia.rascal.presentation.appendix.servlets.AppendixVeterinarianApprovedQueueServlet.validateGet() | STYLE | DLS_DEAD_LOCAL_STORE | 143 | Medium |
| Nullcheck of res at line 107 of value previously dereferenced in edu.columbia.rascal.presentation.appendix.servlets.AppendixVeterinarianApprovedQueueServlet.getPage() | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 107 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Public static edu.columbia.rascal.presentation.common.CURascalApplicationParser.getApplicationTable() may expose internal representation by returning CURascalApplicationParser.applicationTable | MALICIOUS_CODE | MS_EXPOSE_REP | 74 | Medium |
| edu.columbia.rascal.presentation.common.CURascalApplicationParser.applicationTable is a mutable collection which should be package protected | MALICIOUS_CODE | MS_MUTABLE_COLLECTION_PKGPROTECT | 20 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of file at line 35 of value previously dereferenced in edu.columbia.rascal.presentation.common.CURascalBaseFileUploadController.validateUploadedFile(MultipartFile) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 34 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.common.CURascalConstants.APPLICATION_IDS is a mutable array | MALICIOUS_CODE | MS_MUTABLE_ARRAY | 23 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of page, which is known to be non-null in edu.columbia.rascal.presentation.common.CURascalExitMessageServlet.doGet(HttpServletRequest, HttpServletResponse) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 59 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.common.CURascalExitServlet.doGet(HttpServletRequest, HttpServletResponse), since all javax.servlet.http.HttpSession are instances of javax.servlet.http.HttpSession | STYLE | BC_VACUOUS_INSTANCEOF | 74 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.common.CURascalServlet.keywords isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 44 | High |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.common.CURascalServlet.writeWindowCloseAndExitScript() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 1207 | Medium |
| edu.columbia.rascal.presentation.common.CURascalServlet.getIndexOf(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 291 | Medium |
| edu.columbia.rascal.presentation.common.CURascalServlet.getUrlFor(String, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 1321 | Medium |
| edu.columbia.rascal.presentation.common.CURascalServlet.setLineParameters(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 1089 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in edu.columbia.rascal.presentation.common.CURascalVapServlet.deleteHeaderObject(RascalHeaderObject): new java.io.FileWriter(String, boolean) | I18N | DM_DEFAULT_ENCODING | 103 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.common.CUSortVector doesn't override java.util.Vector.equals(Object) | STYLE | EQ_DOESNT_OVERRIDE_EQUALS | 1 | Medium |
| Class edu.columbia.rascal.presentation.common.CUSortVector defines non-transient non-serializable instance field compare | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of email_1 on branch that might be infeasible in edu.columbia.rascal.presentation.common.RascalRequestRascalIDServlet.submit() | STYLE | NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE | 154 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.common.RascalStaticSubmitFormServlet.doPost(HttpServletRequest, HttpServletResponse) on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 162 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.common.RascalStringTester.isRascalDocNumberFormat(String) invokes inefficient new Character(char) constructor; use Character.valueOf(char) instead | PERFORMANCE | DM_NUMBER_CTOR | 77 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to rawColumn in edu.columbia.rascal.presentation.common.csv.CURascalCSVData.getRawColumns() | STYLE | DLS_DEAD_LOCAL_STORE | 143 | Medium |
| Dead store to rawRow in edu.columbia.rascal.presentation.common.csv.CURascalCSVData.getRawRows() | STYLE | DLS_DEAD_LOCAL_STORE | 161 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of dept in edu.columbia.rascal.presentation.common.csv.CURascalCSVProcess.checkDept(Vector, int) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 113 | Medium |
| Unread field: edu.columbia.rascal.presentation.common.csv.CURascalCSVProcess.ru | PERFORMANCE | URF_UNREAD_FIELD | 28 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of rowTokenizer, which is known to be non-null in new edu.columbia.rascal.presentation.common.csv.CURascalCSVRow(String, int, int) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 46 | Medium |
| Redundant nullcheck of token, which is known to be non-null in new edu.columbia.rascal.presentation.common.csv.CURascalCSVRow(String, int, int) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 65 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to complete in edu.columbia.rascal.presentation.common.csv.CURascalCSVType.processTCTestScores(TccourseHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 269 | Medium |
| Dead store to courseNum in edu.columbia.rascal.presentation.common.csv.CURascalCSVType.processTCTestScores(TccourseHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 125 | Medium |
| Dead store to vectorE in edu.columbia.rascal.presentation.common.csv.CURascalCSVType.processTCTestScores(TccourseHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 225 | Medium |
| Dead store to vectorF in edu.columbia.rascal.presentation.common.csv.CURascalCSVType.processTCTestScores(TccourseHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 229 | Medium |
| Dead store to vectorG in edu.columbia.rascal.presentation.common.csv.CURascalCSVType.processTCTestScores(TccourseHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 233 | Medium |
| Dead store to vectorH in edu.columbia.rascal.presentation.common.csv.CURascalCSVType.processTCTestScores(TccourseHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 237 | Medium |
| Dead store to vectorI in edu.columbia.rascal.presentation.common.csv.CURascalCSVType.processTCTestScores(TccourseHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 241 | Medium |
| Dead store to vectorJ in edu.columbia.rascal.presentation.common.csv.CURascalCSVType.processTCTestScores(TccourseHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 245 | Medium |
| Dead store to vectorK in edu.columbia.rascal.presentation.common.csv.CURascalCSVType.processTCTestScores(TccourseHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 249 | Medium |
| Dead store to vectorL in edu.columbia.rascal.presentation.common.csv.CURascalCSVType.processTCTestScores(TccourseHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 253 | Medium |
| Dead store to vectorM in edu.columbia.rascal.presentation.common.csv.CURascalCSVType.processTCTestScores(TccourseHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 257 | Medium |
| Dead store to vectorN in edu.columbia.rascal.presentation.common.csv.CURascalCSVType.processTCTestScores(TccourseHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 261 | Medium |
| Dead store to vectorO in edu.columbia.rascal.presentation.common.csv.CURascalCSVType.processTCTestScores(TccourseHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 265 | Medium |
| Unused field: edu.columbia.rascal.presentation.common.csv.CURascalCSVType.maxSize | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to aRow in edu.columbia.rascal.presentation.common.jdbc.CURascalJdbcAccessor.processResultList(List, int, int, String) | STYLE | DLS_DEAD_LOCAL_STORE | 644 | Medium |
| Dead store to aRow in edu.columbia.rascal.presentation.common.jdbc.CURascalJdbcAccessor.processResultSet(List, int, int) | STYLE | DLS_DEAD_LOCAL_STORE | 582 | Medium |
| Invocation of toString on args in edu.columbia.rascal.presentation.common.jdbc.CURascalJdbcAccessor.performMethod(String, Object, Object[]) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 325 | High |
| Useless object stored in variable args of method edu.columbia.rascal.presentation.common.jdbc.CURascalJdbcAccessor.processResultSet(ResultSet, String) | STYLE | UC_USELESS_OBJECT | 356 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.common.jdbc.CURascalJdbcPreparedQuery.getQueryINParamsHT() may expose internal representation by returning CURascalJdbcPreparedQuery.queryINParamsHT | MALICIOUS_CODE | EI_EXPOSE_REP | 116 | Medium |
| new edu.columbia.rascal.presentation.common.jdbc.CURascalJdbcPreparedQuery(String, Hashtable) may expose internal representation by storing an externally mutable object into CURascalJdbcPreparedQuery.queryINParamsHT | MALICIOUS_CODE | EI_EXPOSE_REP2 | 44 | Medium |
| edu.columbia.rascal.presentation.common.jdbc.CURascalJdbcPreparedQuery.setQueryINParams(Hashtable) may expose internal representation by storing an externally mutable object into CURascalJdbcPreparedQuery.queryINParamsHT | MALICIOUS_CODE | EI_EXPOSE_REP2 | 134 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.common.jdbc.CURascalJdbcQueryFormat.buildWhereClauseForSelection(CURascalBasicSearchParameter, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 101 | Medium |
| edu.columbia.rascal.presentation.common.jdbc.CURascalJdbcQueryFormat.buildWhereClauseForSelectionByExactCaseMatch(CURascalBasicSearchParameter, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 189 | Medium |
| edu.columbia.rascal.presentation.common.jdbc.CURascalJdbcQueryFormat.buildWhereClauseForSelectionByExactMatch(CURascalBasicSearchParameter, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 274 | Medium |
| edu.columbia.rascal.presentation.common.jdbc.CURascalJdbcQueryFormat.buildWhereClauseForSelectionTitle(CURascalBasicSearchParameter, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 361 | Medium |
| edu.columbia.rascal.presentation.common.jdbc.CURascalJdbcQueryFormat.buildWhereClauseForTextSelectionWithLower(CURascalBasicSearchParameter, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 447 | Medium |
| edu.columbia.rascal.presentation.common.jdbc.CURascalJdbcQueryFormat.buildWhereClauseForTextSelectionWithOriginal(CURascalBasicSearchParameter, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 533 | Medium |
| edu.columbia.rascal.presentation.common.jdbc.CURascalJdbcQueryFormat.buildWhereClauseForTextSelectionWithOriginalAndLower(CURascalBasicSearchParameter, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 620 | Medium |
| Switch statement found in edu.columbia.rascal.presentation.common.jdbc.CURascalJdbcQueryFormat.buildWhereClauseForSelection(CURascalBasicSearchParameter, String) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 85 | Medium |
| Switch statement found in edu.columbia.rascal.presentation.common.jdbc.CURascalJdbcQueryFormat.buildWhereClauseForSelectionByExactCaseMatch(CURascalBasicSearchParameter, String) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 175 | Medium |
| Switch statement found in edu.columbia.rascal.presentation.common.jdbc.CURascalJdbcQueryFormat.buildWhereClauseForSelectionByExactMatch(CURascalBasicSearchParameter, String) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 259 | Medium |
| Switch statement found in edu.columbia.rascal.presentation.common.jdbc.CURascalJdbcQueryFormat.buildWhereClauseForSelectionTitle(CURascalBasicSearchParameter, String) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 346 | Medium |
| Switch statement found in edu.columbia.rascal.presentation.common.jdbc.CURascalJdbcQueryFormat.buildWhereClauseForTextSelectionWithLower(CURascalBasicSearchParameter, String) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 433 | Medium |
| Switch statement found in edu.columbia.rascal.presentation.common.jdbc.CURascalJdbcQueryFormat.buildWhereClauseForTextSelectionWithOriginal(CURascalBasicSearchParameter, String) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 519 | Medium |
| Switch statement found in edu.columbia.rascal.presentation.common.jdbc.CURascalJdbcQueryFormat.buildWhereClauseForTextSelectionWithOriginalAndLower(CURascalBasicSearchParameter, String) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 604 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to offset in edu.columbia.rascal.presentation.common.parser.CURascalBasicSearchParser.parse() | STYLE | DLS_DEAD_LOCAL_STORE | 122 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Potentially ambiguous invocation of either an outer or inherited method edu.columbia.rascal.presentation.common.parser.CURascalBasicSearchParser$ParserState.setState(CURascalBasicSearchParser$ParserState) in edu.columbia.rascal.presentation.common.parser.CURascalBasicSearchParser$StateBase.handleToken(CURascalBasicSearchParser$Token) | STYLE | IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD | 495 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Potentially ambiguous invocation of either an outer or inherited method edu.columbia.rascal.presentation.common.parser.CURascalBasicSearchParser$ParserState.setState(CURascalBasicSearchParser$ParserState) in edu.columbia.rascal.presentation.common.parser.CURascalBasicSearchParser$StateBeginORPhrase.handleToken(CURascalBasicSearchParser$Token) | STYLE | IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD | 525 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Potentially ambiguous invocation of either an outer or inherited method edu.columbia.rascal.presentation.common.parser.CURascalBasicSearchParser$ParserState.setState(CURascalBasicSearchParser$ParserState) in edu.columbia.rascal.presentation.common.parser.CURascalBasicSearchParser$StateBeginPhrase.handleToken(CURascalBasicSearchParser$Token) | STYLE | IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD | 564 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Potentially ambiguous invocation of either an outer or inherited method edu.columbia.rascal.presentation.common.parser.CURascalBasicSearchParser$ParserState.setState(CURascalBasicSearchParser$ParserState) in edu.columbia.rascal.presentation.common.parser.CURascalBasicSearchParser$StateBeginPlusMinusPhrase.handleToken(CURascalBasicSearchParser$Token) | STYLE | IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD | 603 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Potentially ambiguous invocation of either an outer or inherited method edu.columbia.rascal.presentation.common.parser.CURascalBasicSearchParser$ParserState.setState(CURascalBasicSearchParser$ParserState) in edu.columbia.rascal.presentation.common.parser.CURascalBasicSearchParser$StateEndPhrase.handleToken(CURascalBasicSearchParser$Token) | STYLE | IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD | 642 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Potentially ambiguous invocation of either an outer or inherited method edu.columbia.rascal.presentation.common.parser.CURascalBasicSearchParser$ParserState.setState(CURascalBasicSearchParser$ParserState) in edu.columbia.rascal.presentation.common.parser.CURascalBasicSearchParser$StateInitial.handleToken(CURascalBasicSearchParser$Token) | STYLE | IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD | 780 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Potentially ambiguous invocation of either an outer or inherited method edu.columbia.rascal.presentation.common.parser.CURascalBasicSearchParser$ParserState.setState(CURascalBasicSearchParser$ParserState) in edu.columbia.rascal.presentation.common.parser.CURascalBasicSearchParser$StateOR.handleToken(CURascalBasicSearchParser$Token) | STYLE | IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD | 814 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Potentially ambiguous invocation of either an outer or inherited method edu.columbia.rascal.presentation.common.parser.CURascalBasicSearchParser$ParserState.setState(CURascalBasicSearchParser$ParserState) in edu.columbia.rascal.presentation.common.parser.CURascalBasicSearchParser$StatePartialOR.handleToken(CURascalBasicSearchParser$Token) | STYLE | IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD | 845 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Potentially ambiguous invocation of either an outer or inherited method edu.columbia.rascal.presentation.common.parser.CURascalBasicSearchParser$ParserState.setState(CURascalBasicSearchParser$ParserState) in edu.columbia.rascal.presentation.common.parser.CURascalBasicSearchParser$StatePartialORPhrase.handleToken(CURascalBasicSearchParser$Token) | STYLE | IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD | 878 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Potentially ambiguous invocation of either an outer or inherited method edu.columbia.rascal.presentation.common.parser.CURascalBasicSearchParser$ParserState.setState(CURascalBasicSearchParser$ParserState) in edu.columbia.rascal.presentation.common.parser.CURascalBasicSearchParser$StatePartialPhrase.handleToken(CURascalBasicSearchParser$Token) | STYLE | IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD | 924 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Potentially ambiguous invocation of either an outer or inherited method edu.columbia.rascal.presentation.common.parser.CURascalBasicSearchParser$ParserState.setState(CURascalBasicSearchParser$ParserState) in edu.columbia.rascal.presentation.common.parser.CURascalBasicSearchParser$StatePartialPlusMinus.handleToken(CURascalBasicSearchParser$Token) | STYLE | IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD | 970 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Potentially ambiguous invocation of either an outer or inherited method edu.columbia.rascal.presentation.common.parser.CURascalBasicSearchParser$ParserState.setState(CURascalBasicSearchParser$ParserState) in edu.columbia.rascal.presentation.common.parser.CURascalBasicSearchParser$StatePartialPlusMinusPhrase.handleToken(CURascalBasicSearchParser$Token) | STYLE | IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD | 1003 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Potentially ambiguous invocation of either an outer or inherited method edu.columbia.rascal.presentation.common.parser.CURascalBasicSearchParser$ParserState.setState(CURascalBasicSearchParser$ParserState) in edu.columbia.rascal.presentation.common.parser.CURascalBasicSearchParser$StatePlusMinus.handleToken(CURascalBasicSearchParser$Token) | STYLE | IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD | 1049 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.common.parser.CURascalSearchParametersParser.getSearchParamsTable() may expose internal representation by returning CURascalSearchParametersParser.searchParamsTable | MALICIOUS_CODE | EI_EXPOSE_REP | 68 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Return value of getPDFPage() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 439 | Medium |
| Return value of getPDFPage() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 738 | Medium |
| Return value of getPDFPage() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 892 | Medium |
| edu.columbia.rascal.presentation.common.pdf.CURascalPDFFormConstruction.getHTMLCharCleaned(String, String, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 1374 | Medium |
| Useless condition: it's known that val == false at this point | STYLE | UC_USELESS_CONDITION | 1278 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to errorsVector in edu.columbia.rascal.presentation.common.pdf.PDFormComparison.comparePDFFiles() | STYLE | DLS_DEAD_LOCAL_STORE | 98 | High |
| Dead store to errorsVector in edu.columbia.rascal.presentation.common.pdf.PDFormComparison.compareProtocolPDFFiles() | STYLE | DLS_DEAD_LOCAL_STORE | 156 | High |
| Dead store to hMap1 in edu.columbia.rascal.presentation.common.pdf.PDFormComparison.constructProtocolPDF(Collection, Collection, Set, Set) | STYLE | DLS_DEAD_LOCAL_STORE | 568 | High |
| Dead store to hMap2 in edu.columbia.rascal.presentation.common.pdf.PDFormComparison.constructProtocolPDF(Collection, Collection, Set, Set) | STYLE | DLS_DEAD_LOCAL_STORE | 569 | High |
| Dead store to itrCol in edu.columbia.rascal.presentation.common.pdf.PDFormComparison.constructProtocolPDF(Collection, Collection, Set, Set) | STYLE | DLS_DEAD_LOCAL_STORE | 560 | Medium |
| Dead store to itrCol2 in edu.columbia.rascal.presentation.common.pdf.PDFormComparison.constructProtocolPDF(Collection, Collection, Set, Set) | STYLE | DLS_DEAD_LOCAL_STORE | 561 | Medium |
| Dead store to newitrSet in edu.columbia.rascal.presentation.common.pdf.PDFormComparison.constructProtocolPDF(Collection, Collection, Set, Set) | STYLE | DLS_DEAD_LOCAL_STORE | 562 | Medium |
| Dead store to newitrSet2 in edu.columbia.rascal.presentation.common.pdf.PDFormComparison.constructProtocolPDF(Collection, Collection, Set, Set) | STYLE | DLS_DEAD_LOCAL_STORE | 563 | Medium |
| Dead store to pdfFilesize in edu.columbia.rascal.presentation.common.pdf.PDFormComparison.setMapCollectionSet(Form, Form) | STYLE | DLS_DEAD_LOCAL_STORE | 641 | Medium |
| Dead store to pdfFilesize2 in edu.columbia.rascal.presentation.common.pdf.PDFormComparison.setMapCollectionSet(Form, Form) | STYLE | DLS_DEAD_LOCAL_STORE | 642 | Medium |
| Dead store to itrSet in edu.columbia.rascal.presentation.common.pdf.PDFormComparison.setProtocolMapCollectionSet(Form, Form) | STYLE | DLS_DEAD_LOCAL_STORE | 691 | Medium |
| Dead store to itrSet2 in edu.columbia.rascal.presentation.common.pdf.PDFormComparison.setProtocolMapCollectionSet(Form, Form) | STYLE | DLS_DEAD_LOCAL_STORE | 692 | Medium |
| Dead store to pdfFilesize in edu.columbia.rascal.presentation.common.pdf.PDFormComparison.setProtocolMapCollectionSet(Form, Form) | STYLE | DLS_DEAD_LOCAL_STORE | 686 | Medium |
| Dead store to pdfFilesize2 in edu.columbia.rascal.presentation.common.pdf.PDFormComparison.setProtocolMapCollectionSet(Form, Form) | STYLE | DLS_DEAD_LOCAL_STORE | 687 | Medium |
| Unread field: edu.columbia.rascal.presentation.common.pdf.PDFormComparison.finalPDFobj | PERFORMANCE | URF_UNREAD_FIELD | 41 | Medium |
| Unread field: edu.columbia.rascal.presentation.common.pdf.PDFormComparison.finalPDFobj2 | PERFORMANCE | URF_UNREAD_FIELD | 42 | Medium |
| Unread field: edu.columbia.rascal.presentation.common.pdf.PDFormComparison.pdfDatabaseFileCount | PERFORMANCE | URF_UNREAD_FIELD | 54 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of out at line 62 of value previously dereferenced in edu.columbia.rascal.presentation.common.pdf.PDFormComparisonRendererBottomPageServlet.doGet(HttpServletRequest, HttpServletResponse) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 62 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of out at line 63 of value previously dereferenced in edu.columbia.rascal.presentation.common.pdf.PDFormComparisonRendererTopPageServlet.doGet(HttpServletRequest, HttpServletResponse) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 63 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should edu.columbia.rascal.presentation.common.tools.CURascalTimer$TaskQueue be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 339 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should edu.columbia.rascal.presentation.common.tools.CURascalTimer$TimerThread be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 497 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in edu.columbia.rascal.presentation.common.tools.CURascalTimerTask.writeToLogFile(String, String): new java.io.FileWriter(String, boolean) | I18N | DM_DEFAULT_ENCODING | 153 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of e in new edu.columbia.rascal.presentation.common.views.CURascalErrorMessageView(Exception) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 44 | Medium |
| Possible null pointer dereference of e in new edu.columbia.rascal.presentation.common.views.CURascalErrorMessageView(Exception, String) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 97 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from java.util.Vector<java.lang.Object> to edu.columbia.rascal.presentation.common.CUSortVector in edu.columbia.rascal.presentation.common.views.CURascalHtmlView.getSortHeader(Vector) | STYLE | BC_UNCONFIRMED_CAST | 987 | Medium |
| Unchecked/unconfirmed cast from java.util.Vector<java.lang.Object> to edu.columbia.rascal.presentation.common.CUSortVector in edu.columbia.rascal.presentation.common.views.CURascalHtmlView.getSortHeader(Vector, String) | STYLE | BC_UNCONFIRMED_CAST | 1028 | Medium |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.common.views.CURascalHtmlView.getDateTable(String, String, String, String, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 483 | High |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.common.views.CURascalHtmlView.draw(HttpServletResponse) on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 453 | Medium |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.common.views.CURascalHtmlView.preDraw(HttpServletResponse) on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 2979 | Medium |
| Nullcheck of selectedItem at line 942 of value previously dereferenced in edu.columbia.rascal.presentation.common.views.CURascalHtmlView.getSingleSelectWidgetFor(Vector, Vector, String) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 942 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Public static edu.columbia.rascal.presentation.consent.auxilliary.ConsentParagraphType.getDefaultsequence() may expose internal representation by returning ConsentParagraphType.defaultSequence | MALICIOUS_CODE | MS_EXPOSE_REP | 115 | Medium |
| Public static edu.columbia.rascal.presentation.consent.auxilliary.ConsentParagraphType.getStaticdynamic() may expose internal representation by returning ConsentParagraphType.staticDynamic | MALICIOUS_CODE | MS_EXPOSE_REP | 124 | Medium |
| Public static edu.columbia.rascal.presentation.consent.auxilliary.ConsentParagraphType.getTypetable() may expose internal representation by returning ConsentParagraphType.typeTable | MALICIOUS_CODE | MS_EXPOSE_REP | 133 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.consent.auxilliary.ConsentSql.getAllActiveStaticPages() | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 74 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.consent.auxilliary.ConsentSql.getAllActiveStaticPages(String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 117 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.consent.auxilliary.ConsentSql.getCreatorsConsentForms(int) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 164 | Medium |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.consent.auxilliary.ConsentSql.getCreatorsConsentForms(int) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 164 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.consent.pages.ConsentContactEntryView.addGeneralRows(CUHtmlTable, int) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 162 | Medium |
| edu.columbia.rascal.presentation.consent.pages.ConsentContactEntryView.getContactTypeWidget() invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 303 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: edu.columbia.rascal.presentation.consent.pages.ConsentDataSheetComparisonView.pageLayout | PERFORMANCE | URF_UNREAD_FIELD | 39 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.consent.pages.ConsentFormElementDisplayView.getTableViewTitle(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 253 | Medium |
| VERY confusing to have methods edu.columbia.rascal.presentation.consent.pages.ConsentFormElementDisplayView.getRowLabelleftFor(String) and edu.columbia.rascal.presentation.consent.pages.ConsentHtmlView.getRowLabelLeftFor(String) | CORRECTNESS | NM_VERY_CONFUSING | 233 | Medium |
| Useless object stored in variable columns of method edu.columbia.rascal.presentation.consent.pages.ConsentFormElementDisplayView.buildFormElementRows(Vector) | STYLE | UC_USELESS_OBJECT | 162 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to allContact in edu.columbia.rascal.presentation.consent.pages.ConsentFormPDFView.addContacts() | STYLE | DLS_DEAD_LOCAL_STORE | 468 | Medium |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.consent.pages.ConsentFormPDFView.addContacts() | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 471 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.consent.pages.ConsentFormPDFView.addParagraphs() | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 604 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.consent.pages.ConsentFormPDFView.addParagraphsDataBaseVersion(ConsentFormElement, String, int) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 1149 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.consent.pages.ConsentFormPDFView.addSignatureLines() | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 759 | High |
| Nullcheck of targeturl at line 149 of value previously dereferenced in new edu.columbia.rascal.presentation.consent.pages.ConsentFormPDFView(ConsentHeader, String) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 143 | Medium |
| Nullcheck of targeturl at line 194 of value previously dereferenced in new edu.columbia.rascal.presentation.consent.pages.ConsentFormPDFView(ConsentHeader, String, boolean) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 188 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to docs in new edu.columbia.rascal.presentation.consent.pages.ConsentFormView(ConsentHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 62 | High |
| Dead store to docs in new edu.columbia.rascal.presentation.consent.pages.ConsentFormView(ConsentHeader, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 100 | High |
| Dead store to elements in edu.columbia.rascal.presentation.consent.pages.ConsentFormView.addResearchPurpose() | STYLE | DLS_DEAD_LOCAL_STORE | 413 | High |
| Dead store to elements in edu.columbia.rascal.presentation.consent.pages.ConsentFormView.addGeneralInformation() | STYLE | DLS_DEAD_LOCAL_STORE | 217 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to values in edu.columbia.rascal.presentation.consent.pages.ConsentHtmlView.render() | STYLE | DLS_DEAD_LOCAL_STORE | 1201 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.consent.pages.ConsentHtmlView.getYearWidget(String, int) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 1150 | High |
| edu.columbia.rascal.presentation.consent.pages.ConsentHtmlView.getDateTable(String, String, String, String, String) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 345 | Medium |
| Field ConsentHtmlView.labelName masks field in superclass edu.columbia.rascal.presentation.common.views.CURascalHtmlView | CORRECTNESS | MF_CLASS_MASKS_FIELD | High | |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.consent.pages.ConsentHtmlView.draw(HttpServletResponse) on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 137 | Medium |
| Nullcheck of selectedItem at line 963 of value previously dereferenced in edu.columbia.rascal.presentation.consent.pages.ConsentHtmlView.getSingleSelectWidgetFor(EVector, String) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 963 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.consent.pages.ConsentPDFTranslationView.translateContacts() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 323 | High |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.consent.pages.ConsentPDFTranslationView.translateParagraphs() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 381 | High |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.consent.pages.ConsentPDFTranslationView.translateSignatureLines() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 457 | High |
| Exception is caught when Exception is not thrown in edu.columbia.rascal.presentation.consent.pages.ConsentPDFTranslationView.translateContacts() | STYLE | REC_CATCH_EXCEPTION | 367 | Medium |
| Exception is caught when Exception is not thrown in edu.columbia.rascal.presentation.consent.pages.ConsentPDFTranslationView.translateSignatureLines() | STYLE | REC_CATCH_EXCEPTION | 502 | Medium |
| Unread field: edu.columbia.rascal.presentation.consent.pages.ConsentPDFTranslationView.dataIterator | PERFORMANCE | URF_UNREAD_FIELD | 424 | Medium |
| Unread field: edu.columbia.rascal.presentation.consent.pages.ConsentPDFTranslationView.isInvalidStatus | PERFORMANCE | URF_UNREAD_FIELD | 45 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread public/protected field: edu.columbia.rascal.presentation.consent.pages.ConsentPDFView.fontSize12 | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 30 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new edu.columbia.rascal.presentation.consent.pages.ConsentParagraphEntryView(Object, String, String) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 68 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.consent.pages.ConsentParagraphView.getTableViewTitle(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 360 | Medium |
| edu.columbia.rascal.presentation.consent.pages.ConsentParagraphView.buildParagraphRows(Vector) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 270 | Medium |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.consent.pages.ConsentParagraphView.addParagraphRows(CUHtmlForm) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 169 | High |
| Switch statement found in edu.columbia.rascal.presentation.consent.pages.ConsentParagraphView.addParagraphRows(CUHtmlForm) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 169 | Medium |
| Useless object stored in variable columns of method edu.columbia.rascal.presentation.consent.pages.ConsentParagraphView.buildParagraphRows(Vector) | STYLE | UC_USELESS_OBJECT | 244 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to docs in new edu.columbia.rascal.presentation.consent.pages.ConsentProtocolResultsDisplayView(Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 59 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused public or protected field: edu.columbia.rascal.presentation.consent.pages.ConsentSuggestedParagraphView.valid | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to rows in edu.columbia.rascal.presentation.consent.pages.ConsentViewStaticParagraphView.addFields() | STYLE | DLS_DEAD_LOCAL_STORE | 92 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.consent.pages.ContactPersonnelView.getTableViewTitle(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 400 | Medium |
| VERY confusing to have methods edu.columbia.rascal.presentation.consent.pages.ContactPersonnelView.getRowLabelleftFor(String) and edu.columbia.rascal.presentation.consent.pages.ConsentHtmlView.getRowLabelLeftFor(String) | CORRECTNESS | NM_VERY_CONFUSING | 380 | Medium |
| Useless object stored in variable columns of method edu.columbia.rascal.presentation.consent.pages.ContactPersonnelView.buildContactRows(Vector) | STYLE | UC_USELESS_OBJECT | 264 | Medium |
| Useless object stored in variable columns of method edu.columbia.rascal.presentation.consent.pages.ContactPersonnelView.buildControlRows(Vector) | STYLE | UC_USELESS_OBJECT | 314 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.consent.servlets.ConsentContactEntryServlet.saveParticipantEditValues(RascalUser, String) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 82 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.consent.servlets.ConsentCopyServlet.generateNewConsentNumber(long) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 105 | Medium |
| edu.columbia.rascal.presentation.consent.servlets.ConsentCopyServlet.generateNewConsentNumber(long) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 105 | Medium |
| edu.columbia.rascal.presentation.consent.servlets.ConsentCopyServlet.getLetters() may expose internal representation by returning ConsentCopyServlet.letters | MALICIOUS_CODE | EI_EXPOSE_REP | 60 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.consent.servlets.ConsentFormElementDisplayServlet.saveConsentFormElementValues() invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 98 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.consent.servlets.ConsentFormNewServlet.getLetters() may expose internal representation by returning ConsentFormNewServlet.letters | MALICIOUS_CODE | EI_EXPOSE_REP | 110 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.consent.servlets.ConsentFormServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 181 | Medium |
| Redundant nullcheck of objPage, which is known to be non-null in edu.columbia.rascal.presentation.consent.servlets.ConsentFormServlet.doGet(HttpServletRequest, HttpServletResponse) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 78 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of cfe in edu.columbia.rascal.presentation.consent.servlets.ConsentParagraphEntryServlet.saveConsentParagraphEditValues(String) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 99 | Medium |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.consent.servlets.ConsentParagraphEntryServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 176 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.consent.servlets.ConsentProtocolSearchServlet.prepareText(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 82 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.consent.servlets.ConsentSuggestedParagraphEntryServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 117 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.controller.ClearValueProcessor.clear(Object) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 44 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to authentication in edu.columbia.rascal.presentation.controller.coi.CoiDisclosureDateReportController.run(String, String, Model) | STYLE | DLS_DEAD_LOCAL_STORE | 134 | Medium |
| Dead store to userIds in edu.columbia.rascal.presentation.controller.coi.CoiDisclosureDateReportController.run(String, String, Model) | STYLE | DLS_DEAD_LOCAL_STORE | 98 | Medium |
| Dead store to userNames in edu.columbia.rascal.presentation.controller.coi.CoiDisclosureDateReportController.run(String, String, Model) | STYLE | DLS_DEAD_LOCAL_STORE | 99 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.controller.coi.CoiFilingDisclosureController.saveFinancialPage(Long, int, Long, String, CoiUserFormCommand) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 404 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to disclosures in edu.columbia.rascal.presentation.controller.coi.CoiFilingStatusReportsController.anomalousDisclosuresByDepartment(String, String, String, Boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 828 | Medium |
| Dead store to disclosures in edu.columbia.rascal.presentation.controller.coi.CoiFilingStatusReportsController.clearedDisclosuresByDepartment(String, String, String, Boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 906 | Medium |
| Dead store to disclosures in edu.columbia.rascal.presentation.controller.coi.CoiFilingStatusReportsController.nonAnomalousDisclosuresByDepartment(String, String, String, Boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 985 | Medium |
| Dead store to users in edu.columbia.rascal.presentation.controller.coi.CoiFilingStatusReportsController.nonRespondersRequiredToFileWithJobCode(String, Boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 730 | Medium |
| Dead store to users in edu.columbia.rascal.presentation.controller.coi.CoiFilingStatusReportsController.nonRespondersRequiredToFileWithOverdueAmount(String, Boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 666 | Medium |
| Dead store to recent in edu.columbia.rascal.presentation.controller.coi.CoiFilingStatusReportsController.usersByDepartment(String, Boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 464 | Medium |
| Dead store to users in edu.columbia.rascal.presentation.controller.coi.CoiFilingStatusReportsController.usersByDepartment(String, Boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 457 | Medium |
| Dead store to expired in edu.columbia.rascal.presentation.controller.coi.CoiFilingStatusReportsController.usersRequiredToFile(String, Boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 236 | Medium |
| Dead store to users in edu.columbia.rascal.presentation.controller.coi.CoiFilingStatusReportsController.usersRequiredToFile(String, Boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 229 | Medium |
| Dead store to expired in edu.columbia.rascal.presentation.controller.coi.CoiFilingStatusReportsController.usersRequiredToFileWithOverdueAmount(String, Boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 560 | Medium |
| Dead store to users in edu.columbia.rascal.presentation.controller.coi.CoiFilingStatusReportsController.usersRequiredToFileWithOverdueAmount(String, Boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 553 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of irbHeader in edu.columbia.rascal.presentation.controller.coi.CoiIrbProtocolController.populateModelObject(CoiDisclosureDetail, Long, String, String, ModelMap, boolean) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 249 | Medium |
| Possible null pointer dereference of answer in edu.columbia.rascal.presentation.controller.coi.CoiIrbProtocolController.saveIrbDisclosure(Long, String, String, String, CoiDisclosureDetail, Map, ModelMap) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 109 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to currentUser in edu.columbia.rascal.presentation.controller.coi.CoiJitAttachmentsController.get(Long, ModelAndView) | STYLE | DLS_DEAD_LOCAL_STORE | 129 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.controller.coi.CoiJustInTimeController.getUsersNotFiledErrors(List) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 283 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to end in edu.columbia.rascal.presentation.controller.coi.CoiNonAnomalousDisclosureReportController.runHtml(String, String, String, String, String, Model) | STYLE | DLS_DEAD_LOCAL_STORE | 159 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to users in edu.columbia.rascal.presentation.controller.coi.CoiPAndSPublicDisclosureController.findDisclosures(String, String, Model) | STYLE | DLS_DEAD_LOCAL_STORE | 69 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Useless object stored in variable response of method edu.columbia.rascal.presentation.controller.hazmats.HazMatsAssignPRQueueController.assignPR(String, String, HzNotes, ModelMap) | STYLE | UC_USELESS_OBJECT | 77 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.controller.hazmats.HazMatsAttachmentsController.ATTACHMENT_TYPES is a mutable collection which should be package protected | MALICIOUS_CODE | MS_MUTABLE_COLLECTION_PKGPROTECT | 82 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to headers in edu.columbia.rascal.presentation.controller.iacuc.IacucActiveProtocolsWithFundingRptController.getActiveProtocolsWithFundingData(ReportCommand) | STYLE | DLS_DEAD_LOCAL_STORE | 94 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.controller.iacuc.IacucAdminReturnToPIController.getOtherStaff(IacucProtocolHeader) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 135 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to currentUser in edu.columbia.rascal.presentation.controller.iacuc.IacucAdverseEventDataSheetPDFController.viewDataSheet(HttpServletRequest, HttpServletResponse, Long) | STYLE | DLS_DEAD_LOCAL_STORE | 47 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null passed for non-null parameter of java.util.Date.after(Date) in edu.columbia.rascal.presentation.controller.iacuc.IacucAttachAppendixController.loadStaffPage(Long, String, Long) | CORRECTNESS | NP_NULL_PARAM_DEREF | 308 | High |
| Nullcheck of testPassedDate at line 308 of value previously dereferenced in edu.columbia.rascal.presentation.controller.iacuc.IacucAttachAppendixController.loadStaffPage(Long, String, Long) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 308 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to headers in edu.columbia.rascal.presentation.controller.iacuc.IacucDeptSubmittedProtocolRptController.getDeptSubmittedProtocolData(ReportCommand) | STYLE | DLS_DEAD_LOCAL_STORE | 131 | Medium |
| Possible null pointer dereference of dept in edu.columbia.rascal.presentation.controller.iacuc.IacucDeptSubmittedProtocolRptController.saveNewDocument(ReportCommand, Model) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 88 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to drugNames in edu.columbia.rascal.presentation.controller.iacuc.IacucDrugController.populateDrugRouteLookups(IacucProtocolHeader, Model, String) | STYLE | DLS_DEAD_LOCAL_STORE | 343 | Medium |
| Dead store to drugNames in edu.columbia.rascal.presentation.controller.iacuc.IacucDrugController.populateLookups(String, Model) | STYLE | DLS_DEAD_LOCAL_STORE | 371 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to currentIph in edu.columbia.rascal.presentation.controller.iacuc.IacucFileUploadController.get(HttpServletRequest) | STYLE | DLS_DEAD_LOCAL_STORE | 128 | Medium |
| Dead store to currentIph in edu.columbia.rascal.presentation.controller.iacuc.IacucFileUploadController.getUpdate(long) | STYLE | DLS_DEAD_LOCAL_STORE | 144 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to currentIph in edu.columbia.rascal.presentation.controller.iacuc.IacucFileUploadInternalController.get(HttpServletRequest) | STYLE | DLS_DEAD_LOCAL_STORE | 120 | Medium |
| Dead store to currentIph in edu.columbia.rascal.presentation.controller.iacuc.IacucFileUploadInternalController.getUpdate(long) | STYLE | DLS_DEAD_LOCAL_STORE | 138 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to dept in edu.columbia.rascal.presentation.controller.iacuc.IacucGeneralInformationController.getProposal(Long, HttpServletRequest, Model) | STYLE | DLS_DEAD_LOCAL_STORE | 123 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of parentProt in edu.columbia.rascal.presentation.controller.iacuc.IacucModContinueController.updateModConProtocol(String, Long, ModelAndView) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 173 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of obj, which is known to be non-null in edu.columbia.rascal.presentation.controller.iacuc.IacucPreviousLinkController.getPreviousLink(HttpServletRequest) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 31 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to protocol in edu.columbia.rascal.presentation.controller.iacuc.IacucProtocolActionController.onSubmit(String, IacucProtocolHeader, BindingResult, Model) | STYLE | DLS_DEAD_LOCAL_STORE | 63 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to currentUser in edu.columbia.rascal.presentation.controller.iacuc.IacucProtocolDataSheetPDFController.viewDataSheet(HttpServletRequest, HttpServletResponse, Long) | STYLE | DLS_DEAD_LOCAL_STORE | 45 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to end in edu.columbia.rascal.presentation.controller.iacuc.IacucReportAdminSummaryController.runHtml(String, String, Model) | STYLE | DLS_DEAD_LOCAL_STORE | 52 | Medium |
| Dead store to start in edu.columbia.rascal.presentation.controller.iacuc.IacucReportAdminSummaryController.runHtml(String, String, Model) | STYLE | DLS_DEAD_LOCAL_STORE | 51 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Invocation of toString on statusIds in edu.columbia.rascal.presentation.controller.iacuc.IacucViewHistoryController.compareSnapshots(String[]) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 93 | Medium |
| Found reliance on default encoding in edu.columbia.rascal.presentation.controller.iacuc.IacucViewHistoryController.compareSnapshots(String[]): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 102 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.controller.iacuc.ReportCommand.getEndDate() may expose internal representation by returning ReportCommand.endDate | MALICIOUS_CODE | EI_EXPOSE_REP | 96 | Medium |
| edu.columbia.rascal.presentation.controller.iacuc.ReportCommand.getStartDate() may expose internal representation by returning ReportCommand.startDate | MALICIOUS_CODE | EI_EXPOSE_REP | 88 | Medium |
| edu.columbia.rascal.presentation.controller.iacuc.ReportCommand.setEndDate(Date) may expose internal representation by storing an externally mutable object into ReportCommand.endDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 100 | Medium |
| edu.columbia.rascal.presentation.controller.iacuc.ReportCommand.setStartDate(Date) may expose internal representation by storing an externally mutable object into ReportCommand.startDate | MALICIOUS_CODE | EI_EXPOSE_REP2 | 92 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of file at line 68 of value previously dereferenced in edu.columbia.rascal.presentation.controller.irb.IrbBaseAttachDocumentsController.validateUploadedFile(MultipartFile) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 67 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Useless object stored in variable irbSubjectPopulationMap of method edu.columbia.rascal.presentation.controller.irb.IrbClosureSubjectsController.loadPage(Long, Model) | STYLE | UC_USELESS_OBJECT | 133 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of appendixH at line 328 of value previously dereferenced in edu.columbia.rascal.presentation.controller.irb.IrbHistoryController.hazmatHistory(String, Long) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 328 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Boxed value is unboxed and then immediately reboxed in edu.columbia.rascal.presentation.controller.irb.IrbPrintMenuController.buildattachmentList(IrbProtocolHeader, List) | PERFORMANCE | BX_UNBOXING_IMMEDIATELY_REBOXED | 547 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to notified in edu.columbia.rascal.presentation.controller.irb.IrbProtocolApprovalsController.approversList(Long, Model) | STYLE | DLS_DEAD_LOCAL_STORE | 155 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to detail in edu.columbia.rascal.presentation.controller.irb.IrbProtocolAttributesController.save(IrbProtocolDetail, BindingResult, RedirectAttributes, SessionStatus, Model) | STYLE | DLS_DEAD_LOCAL_STORE | 196 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to detail in edu.columbia.rascal.presentation.controller.irb.IrbProtocolBackgroundController.save(IrbProtocolDetail, BindingResult, RedirectAttributes, SessionStatus, Model) | STYLE | DLS_DEAD_LOCAL_STORE | 77 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Suspicious comparison of Integer references in edu.columbia.rascal.presentation.controller.irb.IrbProtocolConsentFormController.updateModel(String, Long, Model) | CORRECTNESS | RC_REF_COMPARISON | 76 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to irbFutureUse in edu.columbia.rascal.presentation.controller.irb.IrbProtocolFutureUseController.save(IrbFutureUse, BindingResult, RedirectAttributes, SessionStatus, Model) | STYLE | DLS_DEAD_LOCAL_STORE | 151 | High |
| edu.columbia.rascal.presentation.controller.irb.IrbProtocolFutureUseController.init() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 73 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to thisform in edu.columbia.rascal.presentation.controller.irb.IrbProtocolHipaaController.attach(Long, Long) | STYLE | DLS_DEAD_LOCAL_STORE | 163 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to clearValueMap in edu.columbia.rascal.presentation.controller.irb.IrbProtocolImagingProcedureFormController.init() | STYLE | DLS_DEAD_LOCAL_STORE | 76 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to modification in edu.columbia.rascal.presentation.controller.irb.IrbProtocolModificationController.save(IrbModification, BindingResult, RedirectAttributes, SessionStatus, Model) | STYLE | DLS_DEAD_LOCAL_STORE | 124 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to detail in edu.columbia.rascal.presentation.controller.irb.IrbProtocolNHSRDController.saveHeader(IrbProtocolDetail, BindingResult, RedirectAttributes, SessionStatus, Model) | STYLE | DLS_DEAD_LOCAL_STORE | 82 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to header in edu.columbia.rascal.presentation.controller.irb.IrbProtocolPersonnelController.savePersonnel(Long, IrbStaff, BindingResult, Model, HttpServletResponse, SessionStatus) | STYLE | DLS_DEAD_LOCAL_STORE | 275 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to procedures in edu.columbia.rascal.presentation.controller.irb.IrbProtocolProceduresController.save(IrbProcedures, BindingResult, RedirectAttributes, SessionStatus, Model) | STYLE | DLS_DEAD_LOCAL_STORE | 142 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to renewal in edu.columbia.rascal.presentation.controller.irb.IrbProtocolRenewalController.save(IrbRenewal, BindingResult, RedirectAttributes, SessionStatus, Model) | STYLE | DLS_DEAD_LOCAL_STORE | 150 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to risksBenefits in edu.columbia.rascal.presentation.controller.irb.IrbProtocolRisksBenefitsController.save(IrbProtocolRisksBenefits, BindingResult, RedirectAttributes, SessionStatus, Model) | STYLE | DLS_DEAD_LOCAL_STORE | 77 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to irbStatus in edu.columbia.rascal.presentation.controller.irb.IrbProtocolSnapshotController.viewHistorySnapShot(HttpServletResponse, Long) | STYLE | DLS_DEAD_LOCAL_STORE | 73 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Useless object stored in variable irbSubjectPopulationMap of method edu.columbia.rascal.presentation.controller.irb.IrbProtocolSubjectsController.loadPage(Long, Model) | STYLE | UC_USELESS_OBJECT | 135 | Medium |
| Useless object stored in variable irbSubjectPopulationMap of method edu.columbia.rascal.presentation.controller.irb.IrbProtocolSubjectsController.loadPage(Long, Model) | STYLE | UC_USELESS_OBJECT | 151 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Suspicious comparison of Integer references in edu.columbia.rascal.presentation.controller.pt.PtApprovalsController.hasNoConflicts(PtProposalHeader, Integer) | CORRECTNESS | RC_REF_COMPARISON | 222 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to ptBudget in edu.columbia.rascal.presentation.controller.pt.PtBudgetController.post(PtBudget, BindingResult, Model, String) | STYLE | DLS_DEAD_LOCAL_STORE | 235 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Return value of java.util.Set.size() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 94 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of ph in edu.columbia.rascal.presentation.controller.pt.PtPersonnelController.add(String, PtAccessControl, BindingResult, Model) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 147 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Return value of java.util.Set.size() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 115 | Medium |
| Return value of java.util.Set.size() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 174 | Medium |
| Return value of java.util.Set.size() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 223 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to myModel in edu.columbia.rascal.presentation.controller.tc.TcFileUploadController.get(HttpServletRequest) | STYLE | DLS_DEAD_LOCAL_STORE | 109 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to address in edu.columbia.rascal.presentation.controller.user.UserEditPersonalInformationController._fillEditModelAndView(RascalUser, ModelAndView) | STYLE | DLS_DEAD_LOCAL_STORE | 219 | Medium |
| Dead store to address2 in edu.columbia.rascal.presentation.controller.user.UserEditPersonalInformationController._fillEditModelAndView(RascalUser, ModelAndView) | STYLE | DLS_DEAD_LOCAL_STORE | 220 | Medium |
| Dead store to address3 in edu.columbia.rascal.presentation.controller.user.UserEditPersonalInformationController._fillEditModelAndView(RascalUser, ModelAndView) | STYLE | DLS_DEAD_LOCAL_STORE | 221 | Medium |
| Dead store to address4 in edu.columbia.rascal.presentation.controller.user.UserEditPersonalInformationController._fillEditModelAndView(RascalUser, ModelAndView) | STYLE | DLS_DEAD_LOCAL_STORE | 222 | Medium |
| Dead store to city in edu.columbia.rascal.presentation.controller.user.UserEditPersonalInformationController._fillEditModelAndView(RascalUser, ModelAndView) | STYLE | DLS_DEAD_LOCAL_STORE | 223 | Medium |
| Dead store to country in edu.columbia.rascal.presentation.controller.user.UserEditPersonalInformationController._fillEditModelAndView(RascalUser, ModelAndView) | STYLE | DLS_DEAD_LOCAL_STORE | 224 | Medium |
| Dead store to position in edu.columbia.rascal.presentation.controller.user.UserEditPersonalInformationController._fillEditModelAndView(RascalUser, ModelAndView) | STYLE | DLS_DEAD_LOCAL_STORE | 226 | Medium |
| Dead store to postCode in edu.columbia.rascal.presentation.controller.user.UserEditPersonalInformationController._fillEditModelAndView(RascalUser, ModelAndView) | STYLE | DLS_DEAD_LOCAL_STORE | 225 | Medium |
| Dead store to selection in edu.columbia.rascal.presentation.controller.user.UserEditPersonalInformationController._fillEditModelAndView(RascalUser, ModelAndView) | STYLE | DLS_DEAD_LOCAL_STORE | 259 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.forms.iacuc.IacucAttachPtInfo.getFinalizedOn() may expose internal representation by returning IacucAttachPtInfo.finalizedOn | MALICIOUS_CODE | EI_EXPOSE_REP | 63 | Medium |
| new edu.columbia.rascal.presentation.forms.iacuc.IacucAttachPtInfo(Long, String, String, String, Date, String, String, String) may expose internal representation by storing an externally mutable object into IacucAttachPtInfo.finalizedOn | MALICIOUS_CODE | EI_EXPOSE_REP2 | 34 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Field HipaaReportParameters.statusParm masks field in superclass edu.columbia.rascal.presentation.hipaa.auxiliary.objects.HipaaSearchParameters | CORRECTNESS | MF_CLASS_MASKS_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: edu.columbia.rascal.presentation.hipaa.auxiliary.objects.HipaaSearchParameters.fromDate | PERFORMANCE | UUF_UNUSED_FIELD | Medium | |
| Unused field: edu.columbia.rascal.presentation.hipaa.auxiliary.objects.HipaaSearchParameters.toDate | PERFORMANCE | UUF_UNUSED_FIELD | Medium | |
| Unused public or protected field: edu.columbia.rascal.presentation.hipaa.auxiliary.objects.HipaaSearchParameters.statusParm | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to userId in edu.columbia.rascal.presentation.hipaa.auxiliary.objects.HipaaSearchParametersParser.parseHipaaReportParameters(CURascalServlet) | STYLE | DLS_DEAD_LOCAL_STORE | 61 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Public static edu.columbia.rascal.presentation.hipaa.auxiliary.objects.HipaaStatusConversion.getStatusConversionTable() may expose internal representation by returning HipaaStatusConversion.statusConversionTable | MALICIOUS_CODE | MS_EXPOSE_REP | 54 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to loginUserParticipant in edu.columbia.rascal.presentation.hipaa.jdbc.HipaaDocSearchQueryFormat.buildQueryAll(HipaaSearchParameters, RascalUser) | STYLE | DLS_DEAD_LOCAL_STORE | 224 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Useless object stored in variable args of method edu.columbia.rascal.presentation.hipaa.jdbc.HipaaJdbcAccessor.processResultSetWithArrayList(ResultSet, String) | STYLE | UC_USELESS_OBJECT | 255 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of helpFileName, which is known to be non-null in edu.columbia.rascal.presentation.hipaa.jdbc.HipaaQueryJdbcAccessor.buildRowTableWithActiveFormTemplateQueryResultSet() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 101 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.hipaa.jdbc.HipaaQueryObject.getCleanedString(String, String, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 153 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to acc in edu.columbia.rascal.presentation.hipaa.jdbc.HipaaQueryProcessViaJdbc.getQueryAllHeaderOidsForIrbProtocolViaJdbc(long) | STYLE | DLS_DEAD_LOCAL_STORE | 97 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread public/protected field: edu.columbia.rascal.presentation.hipaa.jdbc.HipaaReportProcessViaJdbc.servlet | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 42 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Useless object stored in variable columns of method edu.columbia.rascal.presentation.hipaa.pages.HipaaAccessControlView.buildControlRows(Set) | STYLE | UC_USELESS_OBJECT | 171 | Medium |
| Unused field: edu.columbia.rascal.presentation.hipaa.pages.HipaaAccessControlView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: edu.columbia.rascal.presentation.hipaa.pages.HipaaControlEntryView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: edu.columbia.rascal.presentation.hipaa.pages.HipaaDisplaySelectionListView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: edu.columbia.rascal.presentation.hipaa.pages.HipaaFormBlankLineEntryView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to questionOid in edu.columbia.rascal.presentation.hipaa.pages.HipaaFormLayoutView.setLayoutTableDataRow(CUHtmlTable, int, HipaaQuestionLookup) | STYLE | DLS_DEAD_LOCAL_STORE | 308 | Medium |
| Dead store to parentOid in edu.columbia.rascal.presentation.hipaa.pages.HipaaFormLayoutView.setSignatureTableDataRow(CUHtmlTable, int, HipaaQuestionLookup) | STYLE | DLS_DEAD_LOCAL_STORE | 404 | Medium |
| Dead store to questionOid in edu.columbia.rascal.presentation.hipaa.pages.HipaaFormLayoutView.setSignatureTableDataRow(CUHtmlTable, int, HipaaQuestionLookup) | STYLE | DLS_DEAD_LOCAL_STORE | 403 | Medium |
| Useless object stored in variable columns of method edu.columbia.rascal.presentation.hipaa.pages.HipaaFormLayoutView.buildFormElementRows(Vector) | STYLE | UC_USELESS_OBJECT | 167 | Medium |
| Useless object stored in variable columns of method edu.columbia.rascal.presentation.hipaa.pages.HipaaFormLayoutView.buildSignatureRows(Vector) | STYLE | UC_USELESS_OBJECT | 247 | Medium |
| Unused field: edu.columbia.rascal.presentation.hipaa.pages.HipaaFormLayoutView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to compositeMenuItem in edu.columbia.rascal.presentation.hipaa.pages.HipaaFormMaintenanceMenuView.addItems(RascalUser) | STYLE | DLS_DEAD_LOCAL_STORE | 74 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to answerFormat in edu.columbia.rascal.presentation.hipaa.pages.HipaaFormQuestionEntryView.addGeneralRows(CUHtmlTable, int) | STYLE | DLS_DEAD_LOCAL_STORE | 267 | Medium |
| Dead store to answerable in edu.columbia.rascal.presentation.hipaa.pages.HipaaFormQuestionEntryView.addGeneralRows(CUHtmlTable, int) | STYLE | DLS_DEAD_LOCAL_STORE | 260 | Medium |
| Dead store to notQuestion in edu.columbia.rascal.presentation.hipaa.pages.HipaaFormQuestionEntryView.addGeneralRows(CUHtmlTable, int) | STYLE | DLS_DEAD_LOCAL_STORE | 262 | Medium |
| Unused field: edu.columbia.rascal.presentation.hipaa.pages.HipaaFormQuestionEntryView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: edu.columbia.rascal.presentation.hipaa.pages.HipaaFormQuestionView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.hipaa.pages.HipaaFormSearchView.addGeneralInformation(Vector) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 99 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to questionOid in edu.columbia.rascal.presentation.hipaa.pages.HipaaHeaderFormLayoutView.setLayoutTableDataRow(CUHtmlTable, int, HipaaHeaderFormQuestion) | STYLE | DLS_DEAD_LOCAL_STORE | 313 | Medium |
| Dead store to parentOid in edu.columbia.rascal.presentation.hipaa.pages.HipaaHeaderFormLayoutView.setSignatureTableDataRow(CUHtmlTable, int, HipaaHeaderFormQuestion) | STYLE | DLS_DEAD_LOCAL_STORE | 407 | Medium |
| Dead store to questionOid in edu.columbia.rascal.presentation.hipaa.pages.HipaaHeaderFormLayoutView.setSignatureTableDataRow(CUHtmlTable, int, HipaaHeaderFormQuestion) | STYLE | DLS_DEAD_LOCAL_STORE | 406 | Medium |
| Useless object stored in variable columns of method edu.columbia.rascal.presentation.hipaa.pages.HipaaHeaderFormLayoutView.buildFormElementRows(Vector) | STYLE | UC_USELESS_OBJECT | 172 | Medium |
| Useless object stored in variable columns of method edu.columbia.rascal.presentation.hipaa.pages.HipaaHeaderFormLayoutView.buildSignatureRows(Vector) | STYLE | UC_USELESS_OBJECT | 252 | Medium |
| Unused field: edu.columbia.rascal.presentation.hipaa.pages.HipaaHeaderFormLayoutView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: edu.columbia.rascal.presentation.hipaa.pages.HipaaHeaderFormQuestionChildEntryView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to answerFormat in edu.columbia.rascal.presentation.hipaa.pages.HipaaHeaderFormQuestionEntryView.addGeneralRows(CUHtmlTable, int) | STYLE | DLS_DEAD_LOCAL_STORE | 264 | Medium |
| Dead store to answerRequired in edu.columbia.rascal.presentation.hipaa.pages.HipaaHeaderFormQuestionEntryView.addGeneralRows(CUHtmlTable, int) | STYLE | DLS_DEAD_LOCAL_STORE | 258 | Medium |
| Dead store to helpFileName in edu.columbia.rascal.presentation.hipaa.pages.HipaaHeaderFormQuestionEntryView.addGeneralRows(CUHtmlTable, int) | STYLE | DLS_DEAD_LOCAL_STORE | 262 | Medium |
| Dead store to notQuestion in edu.columbia.rascal.presentation.hipaa.pages.HipaaHeaderFormQuestionEntryView.addGeneralRows(CUHtmlTable, int) | STYLE | DLS_DEAD_LOCAL_STORE | 259 | Medium |
| Dead store to parentQuestionOid in edu.columbia.rascal.presentation.hipaa.pages.HipaaHeaderFormQuestionEntryView.addGeneralRows(CUHtmlTable, int) | STYLE | DLS_DEAD_LOCAL_STORE | 261 | Medium |
| Unused field: edu.columbia.rascal.presentation.hipaa.pages.HipaaHeaderFormQuestionEntryView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to parentOid in edu.columbia.rascal.presentation.hipaa.pages.HipaaHeaderFormQuestionSetUpView.setChildDivisionRow(CUHtmlTable, int, HipaaHeaderFormQuestion) | STYLE | DLS_DEAD_LOCAL_STORE | 294 | Medium |
| Dead store to parentOid in edu.columbia.rascal.presentation.hipaa.pages.HipaaHeaderFormQuestionSetUpView.setDivisionRow(CUHtmlTable, int, HipaaHeaderFormQuestion) | STYLE | DLS_DEAD_LOCAL_STORE | 376 | Medium |
| Unused field: edu.columbia.rascal.presentation.hipaa.pages.HipaaHeaderFormQuestionSetUpView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to answerFormat in edu.columbia.rascal.presentation.hipaa.pages.HipaaHeaderFormQuestionViewOnlyView.addGeneralRows(CUHtmlTable, int) | STYLE | DLS_DEAD_LOCAL_STORE | 205 | Medium |
| Unused field: edu.columbia.rascal.presentation.hipaa.pages.HipaaHeaderFormQuestionViewOnlyView.addOrEdit | PERFORMANCE | UUF_UNUSED_FIELD | Medium | |
| Unused field: edu.columbia.rascal.presentation.hipaa.pages.HipaaHeaderFormQuestionViewOnlyView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of hh in edu.columbia.rascal.presentation.hipaa.pages.HipaaHeaderNewView.addGeneralRows(CUHtmlTable, int) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 187 | Medium |
| Unused public or protected field: edu.columbia.rascal.presentation.hipaa.pages.HipaaHeaderNewView.valid | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Useless condition: it's known that parentOid != 0 at this point | STYLE | UC_USELESS_CONDITION | 436 | High |
| Useless condition: it's known that parentOid == 0 at this point | STYLE | UC_USELESS_CONDITION | 425 | High |
| Unused field: edu.columbia.rascal.presentation.hipaa.pages.HipaaHeaderQuestionView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to docs in new edu.columbia.rascal.presentation.hipaa.pages.HipaaHeaderResultsDisplayView(Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 49 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to v in edu.columbia.rascal.presentation.hipaa.pages.HipaaHistoryView.addFields() | STYLE | DLS_DEAD_LOCAL_STORE | 92 | High |
| Dead store to statusName in edu.columbia.rascal.presentation.hipaa.pages.HipaaHistoryView.addFields() | STYLE | DLS_DEAD_LOCAL_STORE | 105 | Medium |
| Dead store to titleLen in edu.columbia.rascal.presentation.hipaa.pages.HipaaHistoryView.getColumns() | STYLE | DLS_DEAD_LOCAL_STORE | 172 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.hipaa.pages.HipaaHtmlView.getTableCellData(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 1243 | Medium |
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.hipaa.pages.HipaaHtmlView.getTableCellData(String, String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 1267 | Medium |
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.hipaa.pages.HipaaHtmlView.getTableViewTitle(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 1331 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.hipaa.pages.HipaaHtmlView.getFloatToDollarStringFor(float) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 507 | Medium |
| Dead store to values in edu.columbia.rascal.presentation.hipaa.pages.HipaaHtmlView.render() | STYLE | DLS_DEAD_LOCAL_STORE | 1447 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.hipaa.pages.HipaaHtmlView.getYearWidget(String, int) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 1412 | High |
| edu.columbia.rascal.presentation.hipaa.pages.HipaaHtmlView.getDateTable(String, String, String, String, String) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 325 | Medium |
| edu.columbia.rascal.presentation.hipaa.pages.HipaaHtmlView.getDateTable(String, String, String, String, String, String) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 378 | Medium |
| Field HipaaHtmlView.header masks field in superclass edu.columbia.rascal.presentation.tools.htmlGen.CUHtmlPage | CORRECTNESS | MF_CLASS_MASKS_FIELD | Medium | |
| Public static edu.columbia.rascal.presentation.hipaa.pages.HipaaHtmlView.getActionHistoryDisplayTable() may expose internal representation by returning HipaaHtmlView.actionHistoryDisplayTable | MALICIOUS_CODE | MS_EXPOSE_REP | 98 | Medium |
| edu.columbia.rascal.presentation.hipaa.pages.HipaaHtmlView.actionHistoryDisplayTable should be both final and package protected | MALICIOUS_CODE | MS_FINAL_PKGPROTECT | 55 | Medium |
| Unused public or protected field: edu.columbia.rascal.presentation.hipaa.pages.HipaaHtmlView.labelName | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Medium | |
| Unwritten field: edu.columbia.rascal.presentation.hipaa.pages.HipaaHtmlView.note | CORRECTNESS | UWF_UNWRITTEN_FIELD | 1684 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: edu.columbia.rascal.presentation.hipaa.pages.HipaaIrbResolveView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of current at line 487 of value previously dereferenced in edu.columbia.rascal.presentation.hipaa.pages.HipaaLinkFrameAbstractView.getStatusDisplayValue(String) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 483 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of header at line 100 of value previously dereferenced in new edu.columbia.rascal.presentation.hipaa.pages.HipaaLinkFrameView(HipaaHeader, RascalUser, String, Boolean) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 84 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.hipaa.pages.HipaaNotesView.addOldNotes(CUHtmlTable, int) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 174 | Medium |
| Unused field: edu.columbia.rascal.presentation.hipaa.pages.HipaaNotesView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Field HipaaNotesViewOnly.oldNotes masks field in superclass edu.columbia.rascal.presentation.hipaa.pages.HipaaNotesView | CORRECTNESS | MF_CLASS_MASKS_FIELD | Medium | |
| Field HipaaNotesViewOnly.parentOid masks field in superclass edu.columbia.rascal.presentation.hipaa.pages.HipaaNotesView | CORRECTNESS | MF_CLASS_MASKS_FIELD | Medium | |
| Unread public/protected field: edu.columbia.rascal.presentation.hipaa.pages.HipaaNotesViewOnly.parentOid | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 36 | Medium |
| Unused field: edu.columbia.rascal.presentation.hipaa.pages.HipaaNotesViewOnly.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium | |
| Unused public or protected field: edu.columbia.rascal.presentation.hipaa.pages.HipaaNotesViewOnly.oldNotes | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Medium | |
| Unused public or protected field: edu.columbia.rascal.presentation.hipaa.pages.HipaaNotesViewOnly.parentName | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.hipaa.pages.HipaaPDFView.getAllPI() might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 604 | Medium |
| edu.columbia.rascal.presentation.hipaa.pages.HipaaPDFView.getAllPI(String, String) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 667 | Medium |
| Dead store to embeddedAnswerQuestions in edu.columbia.rascal.presentation.hipaa.pages.HipaaPDFView.addSubTitle() | STYLE | DLS_DEAD_LOCAL_STORE | 410 | Medium |
| Dead store to firstChar in edu.columbia.rascal.presentation.hipaa.pages.HipaaPDFView.extractText(String) | STYLE | DLS_DEAD_LOCAL_STORE | 539 | Medium |
| Dead store to secondChar in edu.columbia.rascal.presentation.hipaa.pages.HipaaPDFView.extractText(String) | STYLE | DLS_DEAD_LOCAL_STORE | 540 | Medium |
| Null passed for non-null parameter of java.util.SortedSet.remove(Object) in edu.columbia.rascal.presentation.hipaa.pages.HipaaPDFView.getAllPI() | CORRECTNESS | NP_NULL_PARAM_DEREF | 611 | Medium |
| Null passed for non-null parameter of java.util.SortedSet.remove(Object) in edu.columbia.rascal.presentation.hipaa.pages.HipaaPDFView.getAllPI(String, String) | CORRECTNESS | NP_NULL_PARAM_DEREF | 674 | Medium |
| edu.columbia.rascal.presentation.hipaa.pages.HipaaPDFView.getCleanedString(String, String, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 710 | Medium |
| Unread public/protected field: edu.columbia.rascal.presentation.hipaa.pages.HipaaPDFView.fontHelveticaBI | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 43 | Medium |
| Unread public/protected field: edu.columbia.rascal.presentation.hipaa.pages.HipaaPDFView.fontHelveticaI | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 44 | Medium |
| Unread public/protected field: edu.columbia.rascal.presentation.hipaa.pages.HipaaPDFView.fontSize18 | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 48 | Medium |
| Unread public/protected field: edu.columbia.rascal.presentation.hipaa.pages.HipaaPDFView.fontSize8 | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 49 | Medium |
| Unread public/protected field: edu.columbia.rascal.presentation.hipaa.pages.HipaaPDFView.oriRightMargin | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 51 | Medium |
| Unread public/protected field: edu.columbia.rascal.presentation.hipaa.pages.HipaaPDFView.spotsNumber | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 52 | Medium |
| Unread public/protected field: edu.columbia.rascal.presentation.hipaa.pages.HipaaPDFView.unitXy | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 54 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to hipaaNumbTxt in edu.columbia.rascal.presentation.hipaa.pages.HipaaQueueAssignedToMeetingView.setQueueQueryViewTableDataRow(CUHtmlTable, int, Hashtable) | STYLE | DLS_DEAD_LOCAL_STORE | 184 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to hipaaNumbTxt in edu.columbia.rascal.presentation.hipaa.pages.HipaaQueueLoggedInView.setQueueQueryViewTableDataRow(CUHtmlTable, int, Hashtable) | STYLE | DLS_DEAD_LOCAL_STORE | 191 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.hipaa.pages.HipaaQueueView.getInstruction(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 133 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to anId in edu.columbia.rascal.presentation.hipaa.pages.HipaaReportMenuView.addItems() | STYLE | DLS_DEAD_LOCAL_STORE | 96 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to userid in edu.columbia.rascal.presentation.hipaa.pages.HipaaUnderConstructionView.addItems(RascalUser) | STYLE | DLS_DEAD_LOCAL_STORE | 67 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Public static edu.columbia.rascal.presentation.hipaa.servlets.HipaaAbstractServlet.getActionHistoryDisplayTable() may expose internal representation by returning HipaaAbstractServlet.actionHistoryDisplayTable | MALICIOUS_CODE | MS_EXPOSE_REP | 106 | Medium |
| edu.columbia.rascal.presentation.hipaa.servlets.HipaaAbstractServlet.actionHistoryDisplayTable should be both final and package protected | MALICIOUS_CODE | MS_FINAL_PKGPROTECT | 47 | Medium |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.hipaa.servlets.HipaaAbstractServlet.redirectToLogon() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 385 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.hipaa.servlets.HipaaAttachSelectionServlet.getPage() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 88 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to hipaaNum in edu.columbia.rascal.presentation.hipaa.servlets.HipaaControlEntryServlet.saveAccessControlEditValues(RascalUser, String) | STYLE | DLS_DEAD_LOCAL_STORE | 75 | Medium |
| Dead store to hipaaNum in edu.columbia.rascal.presentation.hipaa.servlets.HipaaControlEntryServlet.saveAccessControlValues(RascalUser, String) | STYLE | DLS_DEAD_LOCAL_STORE | 93 | Medium |
| Nullcheck of out at line 165 of value previously dereferenced in edu.columbia.rascal.presentation.hipaa.servlets.HipaaControlEntryServlet.submit() | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 165 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.hipaa.servlets.HipaaCopyServlet.getPage() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 46 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to formId in edu.columbia.rascal.presentation.hipaa.servlets.HipaaCreateFormServlet.submit() | STYLE | DLS_DEAD_LOCAL_STORE | 159 | Medium |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.hipaa.servlets.HipaaCreateFormServlet.getPage() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 77 | High |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.hipaa.servlets.HipaaCreateFormServlet.submit() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 165 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to questionIdStr in edu.columbia.rascal.presentation.hipaa.servlets.HipaaFormBlankLineEntryServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 56 | Medium |
| Dead store to questionOid in edu.columbia.rascal.presentation.hipaa.servlets.HipaaFormBlankLineEntryServlet.validatePost() | STYLE | DLS_DEAD_LOCAL_STORE | 151 | Medium |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.hipaa.servlets.HipaaFormBlankLineEntryServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 142 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to questionIdStr in edu.columbia.rascal.presentation.hipaa.servlets.HipaaFormEmbeddedQuestionEntryServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 55 | Medium |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.hipaa.servlets.HipaaFormEmbeddedQuestionEntryServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 160 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.hipaa.servlets.HipaaFormPDFServlet.getPDFPage() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 86 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to questionIdStr in edu.columbia.rascal.presentation.hipaa.servlets.HipaaFormQuestionEntryServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 56 | Medium |
| Dead store to questionOid in edu.columbia.rascal.presentation.hipaa.servlets.HipaaFormQuestionEntryServlet.validatePost() | STYLE | DLS_DEAD_LOCAL_STORE | 201 | Medium |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.hipaa.servlets.HipaaFormQuestionEntryServlet.saveQuestionValues() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 144 | High |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.hipaa.servlets.HipaaFormQuestionEntryServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 192 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to headerFormOid in edu.columbia.rascal.presentation.hipaa.servlets.HipaaFormQuestionRemoveServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 57 | Medium |
| Dead store to parentOid in edu.columbia.rascal.presentation.hipaa.servlets.HipaaFormQuestionRemoveServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 65 | Medium |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.hipaa.servlets.HipaaFormQuestionRemoveServlet.getPage() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 67 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.hipaa.servlets.HipaaFormQuestionServlet.getPage() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 46 | High |
| Null passed for non-null parameter of HipaaAbstractServlet.setHipaaForm(HipaaForm) in edu.columbia.rascal.presentation.hipaa.servlets.HipaaFormQuestionServlet.getPage() | CORRECTNESS | NP_NULL_PARAM_DEREF | 53 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to questionIdStr in edu.columbia.rascal.presentation.hipaa.servlets.HipaaFormSignatureLineEntryServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 56 | Medium |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.hipaa.servlets.HipaaFormSignatureLineEntryServlet.saveQuestionValues() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 107 | High |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.hipaa.servlets.HipaaFormSignatureLineEntryServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 139 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to ru in edu.columbia.rascal.presentation.hipaa.servlets.HipaaFormTemplateDeleteServlet.validateGet() | STYLE | DLS_DEAD_LOCAL_STORE | 149 | Medium |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.hipaa.servlets.HipaaFormTemplateDeleteServlet.getPage() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 99 | High |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.hipaa.servlets.HipaaFormTemplateDeleteServlet.validateGet() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 152 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.hipaa.servlets.HipaaHeaderFormLayoutServlet.validatePost() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 233 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.hipaa.servlets.HipaaHeaderFormQuestionChildEntryServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 111 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to questionIdStr in edu.columbia.rascal.presentation.hipaa.servlets.HipaaHeaderFormQuestionEntryServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 55 | Medium |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.hipaa.servlets.HipaaHeaderFormQuestionEntryServlet.saveQuestionValues() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 101 | High |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.hipaa.servlets.HipaaHeaderFormQuestionEntryServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 125 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to questionIdStr in edu.columbia.rascal.presentation.hipaa.servlets.HipaaHeaderFormSignatureLineEntryServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 56 | Medium |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.hipaa.servlets.HipaaHeaderFormSignatureLineEntryServlet.saveQuestionValues() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 105 | High |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.hipaa.servlets.HipaaHeaderFormSignatureLineEntryServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 135 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to formType in edu.columbia.rascal.presentation.hipaa.servlets.HipaaHeaderQuestionServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 57 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.hipaa.servlets.HipaaHeaderSearchServlet.prepareText(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 83 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.hipaa.servlets.HipaaLinkFrameNewFormServlet.getPage() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 63 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to notes in edu.columbia.rascal.presentation.hipaa.servlets.HipaaNotesServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 56 | Medium |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.hipaa.servlets.HipaaNotesServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 130 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to notes in edu.columbia.rascal.presentation.hipaa.servlets.HipaaNotesViewOnlyServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 55 | Medium |
| Null passed for non-null parameter of new edu.columbia.rascal.presentation.hipaa.pages.HipaaNotesViewOnly(Object, RascalUser, Vector, String, String) in edu.columbia.rascal.presentation.hipaa.servlets.HipaaNotesViewOnlyServlet.getPage() | CORRECTNESS | NP_NULL_PARAM_DEREF | 74 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.hipaa.servlets.HipaaResolveProtocolServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 112 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to formType in edu.columbia.rascal.presentation.hipaa.servlets.HipaaSetStatusServlet.sendEmail(HipaaHeader, String) | STYLE | DLS_DEAD_LOCAL_STORE | 201 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null passed for non-null parameter of edu.columbia.rascal.presentation.tools.emailDistributor.CURascalEmailSender.sendEmail(CURascalEmailMessage) in edu.columbia.rascal.presentation.hipaa.tools.HipaaGeneralEmailMessage.sendEmail(String, String, String, String, String, String) | CORRECTNESS | NP_NULL_PARAM_DEREF | 117 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Public static edu.columbia.rascal.presentation.ic.auxiliary.IacucStatusEngine.getActionHistoryDisplayTable() may expose internal representation by returning IacucStatusEngine.actionHistoryDisplayTable | MALICIOUS_CODE | MS_EXPOSE_REP | 769 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.ic.servlets.IacucAbstractServlet.roleConversionTable should be both final and package protected | MALICIOUS_CODE | MS_FINAL_PKGPROTECT | 42 | Medium |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.ic.servlets.IacucAbstractServlet.redirectToLogon() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 289 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to originParm in edu.columbia.rascal.presentation.ic.servlets.IacucClearLinkFrameServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 35 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.ic.views.IacucHtmlView.getDateTable(String, String, String, String, String) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 111 | Medium |
| edu.columbia.rascal.presentation.ic.views.IacucHtmlView.roleConversionTable should be both final and package protected | MALICIOUS_CODE | MS_FINAL_PKGPROTECT | 31 | Medium |
| Nullcheck of current at line 915 of value previously dereferenced in edu.columbia.rascal.presentation.ic.views.IacucHtmlView.getStatusDisplayValue(String) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 911 | Medium |
| Unread field: edu.columbia.rascal.presentation.ic.views.IacucHtmlView.base; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 48 | Medium |
| Unread field: edu.columbia.rascal.presentation.ic.views.IacucHtmlView.mainTitle | PERFORMANCE | URF_UNREAD_FIELD | 781 | Medium |
| Unused field: edu.columbia.rascal.presentation.ic.views.IacucHtmlView.mode | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.ic.views.IacucLinkFrameAbstractView.modeDictStrCurrentProtocol should be both final and package protected | MALICIOUS_CODE | MS_FINAL_PKGPROTECT | 46 | Medium |
| edu.columbia.rascal.presentation.ic.views.IacucLinkFrameAbstractView.modeDictStrTitle should be both final and package protected | MALICIOUS_CODE | MS_FINAL_PKGPROTECT | 33 | Medium |
| Nullcheck of current at line 402 of value previously dereferenced in edu.columbia.rascal.presentation.ic.views.IacucLinkFrameAbstractView.getStatusDisplayValue(String) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 391 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to protNum in new edu.columbia.rascal.presentation.ic.views.IacucLinkFrameBackToOriginView(IacucProtocolHeader, String, Boolean, RascalUser) | STYLE | DLS_DEAD_LOCAL_STORE | 44 | Medium |
| Dead store to protOid in new edu.columbia.rascal.presentation.ic.views.IacucLinkFrameBackToOriginView(IacucProtocolHeader, String, Boolean, RascalUser) | STYLE | DLS_DEAD_LOCAL_STORE | 43 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to protNum in new edu.columbia.rascal.presentation.ic.views.IacucLinkFrameReadOnlyView(IacucProtocolHeader, String, Boolean, RascalUser) | STYLE | DLS_DEAD_LOCAL_STORE | 57 | Medium |
| Dead store to protOid in new edu.columbia.rascal.presentation.ic.views.IacucLinkFrameReadOnlyView(IacucProtocolHeader, String, Boolean, RascalUser) | STYLE | DLS_DEAD_LOCAL_STORE | 56 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to param1 in new edu.columbia.rascal.presentation.ic.views.IacucLinkFrameView(IacucProtocolHeader, Boolean, RascalUser, String) | STYLE | DLS_DEAD_LOCAL_STORE | 61 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: edu.columbia.rascal.presentation.irb.auxilliary.objects.IrbSearchParameters.srchType | PERFORMANCE | URF_UNREAD_FIELD | 300 | Medium |
| Unread public/protected field: edu.columbia.rascal.presentation.irb.auxilliary.objects.IrbSearchParameters.userId | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 320 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.irb.auxilliary.objects.IrbStatusEngine.recommendedStatusChoices isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 24 | High |
| edu.columbia.rascal.presentation.irb.auxilliary.objects.IrbStatusEngine.statusChoices isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 23 | High |
| Unread public/protected field: edu.columbia.rascal.presentation.irb.auxilliary.objects.IrbStatusEngine.paperProtocolStatusChoices | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 28 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbProtocolQuery.getAllInvolvedChildTypeCodeByNewHeader(long) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 169 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbProtocolQuery.getExpired30DaysProtocols(String, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 762 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbProtocolQuery.getIrbCommitteeMembersFor(long) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 969 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbProtocolQuery.getIrbCommitteeMembersFor(String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 1008 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbProtocolQuery.getIrbCommitteeMembersForMaintenance() | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 1053 | Medium |
| Dead store to protocolNumYearMod in edu.columbia.rascal.presentation.irb.jdbc.IrbProtocolQuery.getIRBProtocolListForProposalTracking(String) | STYLE | DLS_DEAD_LOCAL_STORE | 1091 | Medium |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbProtocolQuery.getAllInvolvedChildTypeCodeByNewHeader(long) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 169 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbProtocolQuery.getExpired30DaysProtocols(String, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 762 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbProtocolQuery.getIrbCommitteeMembersFor(long) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 969 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbProtocolQuery.getIrbCommitteeMembersFor(String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 1008 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbProtocolQuery.getIrbCommitteeMembersForMaintenance() | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 1053 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.buildApprovalResults(ResultSet, String, Vector) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 64 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.buildApprovedResults(ResultSet, String, Vector) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 140 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.buildCTSAApprovalResults(ResultSet, String, Vector) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 445 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.buildCTSAApprovedResults(ResultSet, String, Vector) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 536 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.buildStipulatedApprovalResults(ResultSet, String, Vector) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 629 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.buildStipulatedApprovedResults(ResultSet, String, Vector) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 724 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getAdverseEventEventsForReviewerChairQueue(RascalUser, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 875 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getAdverseEventEventsForReviewerQueue(RascalUser, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 966 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getAdverseEventForLoggerQueue(RascalUser) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 1051 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getAdverseEventForReviewerQueue(RascalUser, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 1134 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getChairCommitteeStringFor(RascalUser) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 1672 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getClosureEventsForReviewerChairQueue(RascalUser, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 5094 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getClosureEventsForReviewerQueue(RascalUser, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 5183 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getClosureForReviewerQueue(RascalUser, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 5262 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getClosuresForChairQueue(String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 5374 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getClosuresForLoggerQueue(RascalUser) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 5460 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getModificationEventsForReviewerChairQueue(RascalUser, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 3014 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getModificationEventsForReviewerQueue(RascalUser, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 3105 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getModificationsForChairQueue(String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 3190 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getModificationsToLogIn(RascalUser) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 3279 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getPaperProtocolsForValidationQueue() | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 3358 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getProtocolEventsForReviewerChairQueue(RascalUser, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 3499 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getProtocolEventsForReviewerQueue(RascalUser, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 3591 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getProtocolsForChairQueue(String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 3678 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getProtocolsForExpeditableReviewerQueue(RascalUser, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 3811 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getProtocolsForReviewerQueue(RascalUser, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 3945 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getProtocolsToLogIn(RascalUser) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 4079 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getRenewalEventsForReviewerChairQueue(RascalUser, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 4189 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getRenewalEventsForReviewerQueue(RascalUser, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 4281 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getRenewalsForChairQueue(String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 4365 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getRenewalsToLogIn(RascalUser) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 4460 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getUnanticipateEventsForReviewerChairQueue(RascalUser, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 5565 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getUnanticipateEventsForReviewerQueue(RascalUser, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 5657 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getUnanticipateForChairQueue(String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 5757 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getUnanticipateForLoggerQueue(RascalUser) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 5847 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getUnanticipateForReviewerQueue(RascalUser, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 5930 | Medium |
| Dead store to results1 in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getCommitteeStringForCorrespondenceQueue(RascalUser) | STYLE | DLS_DEAD_LOCAL_STORE | 1884 | High |
| Dead store to row in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getCommitteeStringForCorrespondenceQueue(RascalUser) | STYLE | DLS_DEAD_LOCAL_STORE | 1886 | High |
| Dead store to committeeBuff in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getCorrespondenceQueueForAdminC(RascalUser, String) | STYLE | DLS_DEAD_LOCAL_STORE | 2055 | High |
| Dead store to locations in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getLogInAdminLocationStringFor(RascalUser) | STYLE | DLS_DEAD_LOCAL_STORE | 2924 | High |
| Dead store to iAmChair in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getAdverseEventEventsForReviewerChairQueue(RascalUser, String) | STYLE | DLS_DEAD_LOCAL_STORE | 817 | Medium |
| Dead store to iAmRascal in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getAdverseEventEventsForReviewerChairQueue(RascalUser, String) | STYLE | DLS_DEAD_LOCAL_STORE | 816 | Medium |
| Dead store to v in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getApprovalQueue(RascalUser) | STYLE | DLS_DEAD_LOCAL_STORE | 1249 | Medium |
| Dead store to v in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getApprovedQueue(RascalUser) | STYLE | DLS_DEAD_LOCAL_STORE | 1417 | Medium |
| Dead store to iAmChair in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getClosureEventsForReviewerChairQueue(RascalUser, String) | STYLE | DLS_DEAD_LOCAL_STORE | 5038 | Medium |
| Dead store to iAmRascal in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getClosureEventsForReviewerChairQueue(RascalUser, String) | STYLE | DLS_DEAD_LOCAL_STORE | 5037 | Medium |
| Dead store to acc in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getLogInAdminLocationStringFor(RascalUser) | STYLE | DLS_DEAD_LOCAL_STORE | 2925 | Medium |
| Dead store to iAmChair in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getModificationEventsForReviewerChairQueue(RascalUser, String) | STYLE | DLS_DEAD_LOCAL_STORE | 2956 | Medium |
| Dead store to iAmRascal in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getModificationEventsForReviewerChairQueue(RascalUser, String) | STYLE | DLS_DEAD_LOCAL_STORE | 2955 | Medium |
| Dead store to iAmChair in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getProtocolEventsForReviewerChairQueue(RascalUser, String) | STYLE | DLS_DEAD_LOCAL_STORE | 3439 | Medium |
| Dead store to iAmRascal in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getProtocolEventsForReviewerChairQueue(RascalUser, String) | STYLE | DLS_DEAD_LOCAL_STORE | 3438 | Medium |
| Dead store to iAmChair in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getRenewalEventsForReviewerChairQueue(RascalUser, String) | STYLE | DLS_DEAD_LOCAL_STORE | 4129 | Medium |
| Dead store to iAmRascal in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getRenewalEventsForReviewerChairQueue(RascalUser, String) | STYLE | DLS_DEAD_LOCAL_STORE | 4128 | Medium |
| Dead store to v in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getStipulatedApprovalQueueFor(String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 4629 | Medium |
| Dead store to v in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getStipulatedApprovedQueueFor(String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 4874 | Medium |
| Dead store to iAmChair in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getUnanticipateEventsForReviewerChairQueue(RascalUser, String) | STYLE | DLS_DEAD_LOCAL_STORE | 5507 | Medium |
| Dead store to iAmRascal in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getUnanticipateEventsForReviewerChairQueue(RascalUser, String) | STYLE | DLS_DEAD_LOCAL_STORE | 5506 | Medium |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getAdverseEventForReviewerQueue(RascalUser, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 1171 | High |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getClosureForReviewerQueue(RascalUser, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 5300 | High |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getPaperProtocolsForValidationQueue() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 3404 | High |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getProtocolsForReviewerQueue(RascalUser, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 3993 | High |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getUnanticipateForReviewerQueue(RascalUser, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 5967 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.buildApprovalResults(ResultSet, String, Vector) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 64 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.buildApprovedResults(ResultSet, String, Vector) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 140 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.buildCTSAApprovalResults(ResultSet, String, Vector) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 445 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.buildCTSAApprovedResults(ResultSet, String, Vector) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 536 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.buildStipulatedApprovalResults(ResultSet, String, Vector) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 629 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.buildStipulatedApprovedResults(ResultSet, String, Vector) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 724 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getAdverseEventEventsForReviewerChairQueue(RascalUser, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 875 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getAdverseEventEventsForReviewerQueue(RascalUser, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 966 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getAdverseEventForLoggerQueue(RascalUser) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 1051 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getAdverseEventForReviewerQueue(RascalUser, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 1134 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getChairCommitteeStringFor(RascalUser) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 1672 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getClosureEventsForReviewerChairQueue(RascalUser, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 5094 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getClosureEventsForReviewerQueue(RascalUser, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 5183 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getClosureForReviewerQueue(RascalUser, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 5262 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getClosuresForChairQueue(String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 5374 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getClosuresForLoggerQueue(RascalUser) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 5460 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getModificationEventsForReviewerChairQueue(RascalUser, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 3014 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getModificationEventsForReviewerQueue(RascalUser, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 3105 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getModificationsForChairQueue(String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 3190 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getModificationsToLogIn(RascalUser) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 3279 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getPaperProtocolsForValidationQueue() | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 3358 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getProtocolEventsForReviewerChairQueue(RascalUser, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 3499 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getProtocolsForChairQueue(String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 3678 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getProtocolsForExpeditableReviewerQueue(RascalUser, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 3811 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getProtocolsForReviewerQueue(RascalUser, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 3945 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getProtocolsToLogIn(RascalUser) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 4079 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getRenewalEventsForReviewerChairQueue(RascalUser, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 4189 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getRenewalEventsForReviewerQueue(RascalUser, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 4281 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getRenewalsForChairQueue(String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 4365 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getRenewalsToLogIn(RascalUser) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 4460 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getUnanticipateEventsForReviewerChairQueue(RascalUser, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 5565 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getUnanticipateEventsForReviewerQueue(RascalUser, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 5657 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getUnanticipateForChairQueue(String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 5757 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getUnanticipateForLoggerQueue(RascalUser) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 5847 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getUnanticipateForReviewerQueue(RascalUser, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 5930 | High |
| Nullcheck of comms at line 1687 of value previously dereferenced in edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getChairCommitteeStringFor(RascalUser) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 1684 | Medium |
| edu.columbia.rascal.presentation.irb.jdbc.IrbQueueQuery.getCommitteeStringForCorrespondenceQueue(RascalUser) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 1912 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.buildCancerCenterReportResult(ResultSet) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 148 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.buildClinicalTrialsFirstSubmissionReportResult(ResultSet, Vector) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 204 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.buildClinicalTrialsReportResult(ResultSet, Vector) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 302 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.buildCurrentActivityReportResult(ResultSet, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 371 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.buildCurrentActivityReportTimesInResult(ResultSet, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 493 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.buildDepartmentReportResult(ResultSet, Vector) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 629 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.buildEventStatusReportResult(ResultSet, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 1601 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.buildExpireDateReportResult(ResultSet) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 1688 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.buildHistoryQueueReportResult(ResultSet, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 2034 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.buildHistoryQueueReportResultForReviewer(ResultSet, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 2124 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.buildPaperValidationReportResult(ResultSet) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 2235 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.buildReportForAdverseEventFrenquencyResult(ResultSet) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 2278 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.buildReportForAdverseEventTrendResult(ResultSet, String) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 2319 | Medium |
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.getCommitteeStringForChairAndAdmin(RascalUser) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 2930 | Medium |
| Dead store to v in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.getEventStatusReport(String, String, String, Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 3352 | High |
| Dead store to v in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.getExpirationDateReport(String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 3597 | High |
| Dead store to v in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.getIrbReportApprovalStatus(String, String, String, Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 4003 | High |
| Dead store to row in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.getIrbReportOverallCommitteeStatsResults(String, String, String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 5813 | High |
| Dead store to row in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.getIrbReportSumbissionTimeResults(String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 7366 | High |
| Dead store to results in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.buildDeviceStudyReportResult(ResultSet, Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 697 | Medium |
| Dead store to results in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.buildDrugDeviceStudyReportResult(ResultSet, Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 1056 | Medium |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.buildCancerCenterReportResult(ResultSet) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 148 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.buildClinicalTrialsFirstSubmissionReportResult(ResultSet, Vector) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 204 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.buildClinicalTrialsReportResult(ResultSet, Vector) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 302 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.buildCurrentActivityReportResult(ResultSet, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 371 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.buildCurrentActivityReportTimesInResult(ResultSet, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 493 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.buildDepartmentReportResult(ResultSet, Vector) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 630 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.buildEventStatusReportResult(ResultSet, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 1601 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.buildExpireDateReportResult(ResultSet) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 1688 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.buildHistoryQueueReportResult(ResultSet, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 2034 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.buildHistoryQueueReportResultForReviewer(ResultSet, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 2124 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.buildPaperValidationReportResult(ResultSet) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 2235 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.buildReportForAdverseEventFrenquencyResult(ResultSet) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 2278 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.buildReportForAdverseEventTrendResult(ResultSet, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 2319 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.getCommitteeStringForChairAndAdmin(RascalUser) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 2930 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.getIrbReportCancerCenterResults(String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 4538 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.getIrbReportSumbissionTimeResults(String, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 7379 | High |
| Redundant nullcheck of StringBuilder.toString(), which is known to be non-null in edu.columbia.rascal.presentation.irb.jdbc.IrbReportQuery.buildDrugDeviceStudyReportResult(ResultSet, Vector) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 1448 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of pdf in edu.columbia.rascal.presentation.irb.pages.HzAttestationCertifiedDataSheetView.constructPDF() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 75 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.irb.pages.HzAttestationPDFDatabaseView.saveAttestationForm() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 67 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to docs in new edu.columbia.rascal.presentation.irb.pages.HzAttestationResultDisplayView(Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 43 | High |
| Dead store to linkBuffer in edu.columbia.rascal.presentation.irb.pages.HzAttestationResultDisplayView.buildForm(Vector, int, int, int, int) | STYLE | DLS_DEAD_LOCAL_STORE | 189 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.irb.pages.HzAttestationView.addFields() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 90 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread public/protected field: edu.columbia.rascal.presentation.irb.pages.IrbApprovalEntryView.parentName | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 179 | Medium |
| Unread public/protected field: edu.columbia.rascal.presentation.irb.pages.IrbApprovalEntryView.parentOid | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 188 | Medium |
| Unused public or protected field: edu.columbia.rascal.presentation.irb.pages.IrbApprovalEntryView.passKerberos | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Medium | |
| Unwritten public or protected field: edu.columbia.rascal.presentation.irb.pages.IrbApprovalEntryView.anOid | STYLE | UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD | 79 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.irb.pages.IrbApprovalView.setDepartmentalApprovalsTableDataRow(CUHtmlTable, IrbApproval) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 457 | Medium |
| edu.columbia.rascal.presentation.irb.pages.IrbApprovalView.setKeyPersonnelApprovalsTableDataRow(CUHtmlTable, IrbApproval) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 567 | Medium |
| Field IrbApprovalView.protocol masks field in superclass edu.columbia.rascal.presentation.irb.pages.IrbHtmlView | CORRECTNESS | MF_CLASS_MASKS_FIELD | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused public or protected field: edu.columbia.rascal.presentation.irb.pages.IrbCheckView.ph | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to member in edu.columbia.rascal.presentation.irb.pages.IrbCommitteeListView.buildCommitteeRows(Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 179 | Medium |
| Unused field: edu.columbia.rascal.presentation.irb.pages.IrbCommitteeListView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: edu.columbia.rascal.presentation.irb.pages.IrbCommitteeMemberEntryView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null passed for non-null parameter of addFields(IrbProtocolHeader) in new edu.columbia.rascal.presentation.irb.pages.IrbCorrespondenceCreateView(RascalUser, IrbTraceableBusinessObject) | CORRECTNESS | NP_NULL_PARAM_DEREF | 89 | Medium |
| Unread public/protected field: edu.columbia.rascal.presentation.irb.pages.IrbCorrespondenceCreateView.fontName | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 408 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to ru in edu.columbia.rascal.presentation.irb.pages.IrbCorrespondenceDispositionView.buildCorrespondenceRows(Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 270 | Medium |
| Dead store to titleLen in edu.columbia.rascal.presentation.irb.pages.IrbCorrespondenceDispositionView.getColumns() | STYLE | DLS_DEAD_LOCAL_STORE | 415 | Medium |
| Dead store to anOid in edu.columbia.rascal.presentation.irb.pages.IrbCorrespondenceDispositionView.setRespondLink(CUHtmlTable, String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 684 | Medium |
| Dead store to anOid in edu.columbia.rascal.presentation.irb.pages.IrbCorrespondenceDispositionView.setRespondLinkForAdmin(CUHtmlTable, String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 726 | Medium |
| Dead store to protocolOid in edu.columbia.rascal.presentation.irb.pages.IrbCorrespondenceDispositionView.setViewHistoryLink(CUHtmlTable) | STYLE | DLS_DEAD_LOCAL_STORE | 906 | Medium |
| edu.columbia.rascal.presentation.irb.pages.IrbCorrespondenceDispositionView.addFields() invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 164 | Medium |
| Possible null pointer dereference of protocol in edu.columbia.rascal.presentation.irb.pages.IrbCorrespondenceDispositionView.setViewHistoryLink(CUHtmlTable) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 920 | Medium |
| Unread public/protected field: edu.columbia.rascal.presentation.irb.pages.IrbCorrespondenceDispositionView.fontName | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 559 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread public/protected field: edu.columbia.rascal.presentation.irb.pages.IrbCorrespondenceEditView.fontName | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 383 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to theObjectName in edu.columbia.rascal.presentation.irb.pages.IrbCorrespondenceRespondView.addRecipients() | STYLE | DLS_DEAD_LOCAL_STORE | 397 | Medium |
| Dead store to theObjectOid in edu.columbia.rascal.presentation.irb.pages.IrbCorrespondenceRespondView.addRecipients() | STYLE | DLS_DEAD_LOCAL_STORE | 398 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: edu.columbia.rascal.presentation.irb.pages.IrbCorrespondenceReturnOrApproveCreateView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread public/protected field: edu.columbia.rascal.presentation.irb.pages.IrbCorrespondenceToReviewView.fontName | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 302 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: edu.columbia.rascal.presentation.irb.pages.IrbDepartmentApprovalView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: edu.columbia.rascal.presentation.irb.pages.IrbExemptionFederalRegulationView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to row in edu.columbia.rascal.presentation.irb.pages.IrbExpeditableCategoryView.addFields() | STYLE | DLS_DEAD_LOCAL_STORE | 152 | Medium |
| Dead store to titleLen in edu.columbia.rascal.presentation.irb.pages.IrbExpeditableCategoryView.getColumns() | STYLE | DLS_DEAD_LOCAL_STORE | 225 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.irb.pages.IrbHazardousMaterialView.getTableCellData(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 238 | Medium |
| Dead store to anOid in edu.columbia.rascal.presentation.irb.pages.IrbHazardousMaterialView.setHazardsListTableDataRow(CUHtmlTable, int, String, String, boolean, AppendixTracking, String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 602 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to values in edu.columbia.rascal.presentation.irb.pages.IrbHtmlView.render() | STYLE | DLS_DEAD_LOCAL_STORE | 2660 | High |
| edu.columbia.rascal.presentation.irb.pages.IrbHtmlView.getDateTable(String, String, String, String, String) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 386 | Medium |
| Call to java.util.Vector.equals(String) in edu.columbia.rascal.presentation.irb.pages.IrbHtmlView.getMultiSelectWidgetFor(Vector, Vector) | CORRECTNESS | EC_UNRELATED_TYPES | 2231 | High |
| Nullcheck of selectedItems at line 2231 of value previously dereferenced in edu.columbia.rascal.presentation.irb.pages.IrbHtmlView.getMultiSelectWidgetFor(Vector, Vector) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 2231 | Medium |
| Nullcheck of selectedItem at line 2182 of value previously dereferenced in edu.columbia.rascal.presentation.irb.pages.IrbHtmlView.getSingleSelectWidgetFor(EVector, String) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 2182 | Medium |
| Nullcheck of selectedItem at line 2212 of value previously dereferenced in edu.columbia.rascal.presentation.irb.pages.IrbHtmlView.getSingleSelectWidgetFor(Vector, String) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 2212 | Medium |
| Nullcheck of selectedItem at line 2256 of value previously dereferenced in edu.columbia.rascal.presentation.irb.pages.IrbHtmlView.getSingleSelectWidgetFor(Vector, Vector, String) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 2256 | Medium |
| Unread field: edu.columbia.rascal.presentation.irb.pages.IrbHtmlView.mainTitle | PERFORMANCE | URF_UNREAD_FIELD | 2706 | Medium |
| Unused public or protected field: edu.columbia.rascal.presentation.irb.pages.IrbHtmlView.labelName | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Medium | |
| Unwritten field: edu.columbia.rascal.presentation.irb.pages.IrbHtmlView.note | CORRECTNESS | UWF_UNWRITTEN_FIELD | 2816 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to headerId in new edu.columbia.rascal.presentation.irb.pages.IrbLinkFrameView(IrbProtocol, IrbProtocolHeader, String, Boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 212 | Medium |
| Dead store to cc in new edu.columbia.rascal.presentation.irb.pages.IrbLinkFrameView(String, IrbProtocol, IrbProtocolHeader, RascalUser, String, Boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 366 | Medium |
| Dead store to size in edu.columbia.rascal.presentation.irb.pages.IrbLinkFrameView.isConsultant(IrbTraceableBusinessObject, RascalUser) | STYLE | DLS_DEAD_LOCAL_STORE | 1444 | Medium |
| Return value of IrbHtmlView.getRascalUser() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 984 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: edu.columbia.rascal.presentation.irb.pages.IrbMainMenuView.iAmAdminB | PERFORMANCE | URF_UNREAD_FIELD | 439 | Medium |
| Unread field: edu.columbia.rascal.presentation.irb.pages.IrbMainMenuView.iAmCTSAViewer | PERFORMANCE | URF_UNREAD_FIELD | 451 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.irb.pages.IrbNotesView.addOldNotes(CUHtmlTable, int) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 250 | Medium |
| Unread public/protected field: edu.columbia.rascal.presentation.irb.pages.IrbNotesView.parentOid | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 36 | Medium |
| Unused public or protected field: edu.columbia.rascal.presentation.irb.pages.IrbNotesView.parentName | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.irb.pages.IrbPDFView.getStringFromVector(Vector) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 195 | Medium |
| Unused field: edu.columbia.rascal.presentation.irb.pages.IrbPDFView.protocol | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.irb.pages.IrbPiEntryView.addGeneralRows(CUHtmlTable, int) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 246 | Medium |
| edu.columbia.rascal.presentation.irb.pages.IrbPiEntryView.getEditViewWidget() invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 382 | Medium |
| edu.columbia.rascal.presentation.irb.pages.IrbPiEntryView.getObtainingConsentWidget() invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 321 | Medium |
| edu.columbia.rascal.presentation.irb.pages.IrbPiEntryView.getStaffRoleWidget() invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 420 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to reviewers in edu.columbia.rascal.presentation.irb.pages.IrbProtocolDispositionView.addGeneralRows(CUHtmlTable, int, IrbTraceableBusinessObject) | STYLE | DLS_DEAD_LOCAL_STORE | 262 | Medium |
| Dead store to protSize in edu.columbia.rascal.presentation.irb.pages.IrbProtocolDispositionView.buildDocumentRows(List, List, List, List) | STYLE | DLS_DEAD_LOCAL_STORE | 593 | Medium |
| Dead store to titleLen in edu.columbia.rascal.presentation.irb.pages.IrbProtocolDispositionView.getColumns() | STYLE | DLS_DEAD_LOCAL_STORE | 809 | Medium |
| Dead store to psSize in edu.columbia.rascal.presentation.irb.pages.IrbProtocolDispositionView.getExplanationsTable(List) | STYLE | DLS_DEAD_LOCAL_STORE | 866 | Medium |
| Nullcheck of app at line 1005 of value previously dereferenced in edu.columbia.rascal.presentation.irb.pages.IrbProtocolDispositionView.getStipulatedApproverStringFor(IrbTraceableBusinessObject) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 1005 | Medium |
| edu.columbia.rascal.presentation.irb.pages.IrbProtocolDispositionView.addGeneralRows(CUHtmlTable, int, IrbTraceableBusinessObject) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 325 | Medium |
| edu.columbia.rascal.presentation.irb.pages.IrbProtocolDispositionView.getStipulatedApproverStringFor(IrbTraceableBusinessObject) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 994 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.irb.pages.IrbProtocolExemptDeclarationView.getExplanationTable(IrbExemptionSelection) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 342 | Medium |
| Unread public/protected field: edu.columbia.rascal.presentation.irb.pages.IrbProtocolExemptDeclarationView.currentExemptions | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 391 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to exempSize in edu.columbia.rascal.presentation.irb.pages.IrbProtocolExemptionEntryView.getExemptionWidget() | STYLE | DLS_DEAD_LOCAL_STORE | 292 | Medium |
| Unused field: edu.columbia.rascal.presentation.irb.pages.IrbProtocolExemptionEntryView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Return value of edu.columbia.rascal.presentation.common.pdf.CURascalPDFFormConstruction.getPDFPage() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 390 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.translateChildInvolveAnswer() might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 512 | Medium |
| Dead store to approvalDate in edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.translateDepartmentInfo() | STYLE | DLS_DEAD_LOCAL_STORE | 605 | Medium |
| Dead store to expDate in edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.translateDepartmentInfo() | STYLE | DLS_DEAD_LOCAL_STORE | 607 | Medium |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.translateApproval() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 293 | High |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.translateAttachedConsentForms() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 329 | High |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.translateAttachedDocs() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 375 | High |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.translateAttachedHipaaForms() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 421 | High |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.translateDataSecurity() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 1186 | High |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.translateExempt() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 677 | High |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.translateExpedited() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 710 | High |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.translateFunding() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 746 | High |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.translateHumanSpecimen() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 931 | High |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.translateInvestigationalProduct() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 1045 | High |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.translateLocation() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 1226 | High |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.translateRenewalAdverseEvent() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 1519 | High |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.translateResearchQuestion() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 1715 | High |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.translateStaff() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 1777 | High |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.translateSubjectInformation1() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 1903 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.addSubChildInvolvementInfo(StringBuffer, int) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 158 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.translateChildInvolveAnswer() | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 479 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.translateResearchQuestion() | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 1730 | High |
| Exception is caught when Exception is not thrown in edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.translateChildInvolveAnswer() | STYLE | REC_CATCH_EXCEPTION | 493 | Medium |
| Exception is caught when Exception is not thrown in edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.translateDepartmentInfo() | STYLE | REC_CATCH_EXCEPTION | 666 | Medium |
| Exception is caught when Exception is not thrown in edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.translateFunding() | STYLE | REC_CATCH_EXCEPTION | 808 | Medium |
| Exception is caught when Exception is not thrown in edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.translateHumanSpecimen() | STYLE | REC_CATCH_EXCEPTION | 994 | Medium |
| Exception is caught when Exception is not thrown in edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.translateInvestigationalProduct() | STYLE | REC_CATCH_EXCEPTION | 1172 | Medium |
| Exception is caught when Exception is not thrown in edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.translateLocation() | STYLE | REC_CATCH_EXCEPTION | 1272 | Medium |
| Exception is caught when Exception is not thrown in edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.translateRenewalAdverseEvent() | STYLE | REC_CATCH_EXCEPTION | 1573 | Medium |
| Exception is caught when Exception is not thrown in edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.translateStaff() | STYLE | REC_CATCH_EXCEPTION | 1865 | Medium |
| Exception is caught when Exception is not thrown in edu.columbia.rascal.presentation.irb.pages.IrbProtocolPDFDataSheetTranslationView.translateSubjectInformation1() | STYLE | REC_CATCH_EXCEPTION | 1958 | Medium |
| Return value of edu.columbia.rascal.presentation.common.pdf.CURascalPDFFormConstruction.getPDFPage() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 563 | Medium |
| Return value of edu.columbia.rascal.presentation.common.pdf.CURascalPDFFormConstruction.getPDFPage() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 1189 | Medium |
| Return value of edu.columbia.rascal.presentation.common.pdf.CURascalPDFFormConstruction.getPDFPage() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 680 | Medium |
| Return value of edu.columbia.rascal.presentation.common.pdf.CURascalPDFFormConstruction.getPDFPage() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 713 | Medium |
| Return value of edu.columbia.rascal.presentation.common.pdf.CURascalPDFFormConstruction.getPDFPage() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 778 | Medium |
| Return value of edu.columbia.rascal.presentation.common.pdf.CURascalPDFFormConstruction.getPDFPage() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 934 | Medium |
| Return value of edu.columbia.rascal.presentation.common.pdf.CURascalPDFFormConstruction.getPDFPage() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 1048 | Medium |
| Return value of edu.columbia.rascal.presentation.common.pdf.CURascalPDFFormConstruction.getPDFPage() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 1245 | Medium |
| Return value of edu.columbia.rascal.presentation.common.pdf.CURascalPDFFormConstruction.getPDFPage() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 1421 | Medium |
| Return value of edu.columbia.rascal.presentation.common.pdf.CURascalPDFFormConstruction.getPDFPage() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 1569 | Medium |
| Return value of edu.columbia.rascal.presentation.common.pdf.CURascalPDFFormConstruction.getPDFPage() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 1687 | Medium |
| Return value of edu.columbia.rascal.presentation.common.pdf.CURascalPDFFormConstruction.getPDFPage() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 1780 | Medium |
| Return value of edu.columbia.rascal.presentation.common.pdf.CURascalPDFFormConstruction.getPDFPage() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 1921 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to docs in new edu.columbia.rascal.presentation.irb.pages.IrbProtocolRascalResultsDisplayView(Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 44 | High |
| Call to method of static java.text.DateFormat in edu.columbia.rascal.presentation.irb.pages.IrbProtocolRascalResultsDisplayView.formatDateObj(Object) | MT_CORRECTNESS | STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE | 425 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to dat2 in edu.columbia.rascal.presentation.irb.pages.IrbProtocolRenewalOversightMonitoringView.addIrbProtocolHeader() | STYLE | DLS_DEAD_LOCAL_STORE | 368 | Medium |
| Dead store to titleLen in edu.columbia.rascal.presentation.irb.pages.IrbProtocolRenewalOversightMonitoringView.getColumns() | STYLE | DLS_DEAD_LOCAL_STORE | 482 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to col in edu.columbia.rascal.presentation.irb.pages.IrbProtocolResearchSummaryView.addResearchQuestionPopup() | STYLE | DLS_DEAD_LOCAL_STORE | 246 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to docs in new edu.columbia.rascal.presentation.irb.pages.IrbProtocolResultsDisplayView(Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 76 | High |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.irb.pages.IrbProtocolResultsDisplayView.getLatestEventStatus(String, Object, String, Object, String, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 541 | High |
| Call to method of static java.text.DateFormat in edu.columbia.rascal.presentation.irb.pages.IrbProtocolResultsDisplayView.formatDateObj(Object) | MT_CORRECTNESS | STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE | 55 | Medium |
| edu.columbia.rascal.presentation.irb.pages.IrbProtocolResultsDisplayView.renderSortComponent(String, String) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 376 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should edu.columbia.rascal.presentation.irb.pages.IrbProtocolResultsDisplayView$LatestEventStatus be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 589 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to parmString in edu.columbia.rascal.presentation.irb.pages.IrbQueueAdminCorrespondenceView.setAdminTableDataRow(Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 385 | Medium |
| Dead store to protocolNumber in edu.columbia.rascal.presentation.irb.pages.IrbQueueAdminCorrespondenceView.setAdminTableDataRow(Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 386 | Medium |
| Dead store to parmString in edu.columbia.rascal.presentation.irb.pages.IrbQueueAdminCorrespondenceView.setTableDataRow(Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 495 | Medium |
| Dead store to protocolNumber in edu.columbia.rascal.presentation.irb.pages.IrbQueueAdminCorrespondenceView.setTableDataRow(Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 496 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Useless control flow in edu.columbia.rascal.presentation.irb.pages.IrbQueueApprovalConfirmView.isShipping(IrbProtocolHeader) | STYLE | UCF_USELESS_CONTROL_FLOW | 333 | Medium |
| Unused field: edu.columbia.rascal.presentation.irb.pages.IrbQueueApprovalConfirmView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium | |
| Unused public or protected field: edu.columbia.rascal.presentation.irb.pages.IrbQueueApprovalConfirmView.rascal | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to titleLen in edu.columbia.rascal.presentation.irb.pages.IrbQueueApprovalView.getColumns(String) | STYLE | DLS_DEAD_LOCAL_STORE | 170 | Medium |
| Unused public or protected field: edu.columbia.rascal.presentation.irb.pages.IrbQueueApprovalView.rascal | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to parmString in edu.columbia.rascal.presentation.irb.pages.IrbQueueCTSACorrespondenceView.setTableDataRow(Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 269 | Medium |
| Dead store to protocolNumber in edu.columbia.rascal.presentation.irb.pages.IrbQueueCTSACorrespondenceView.setTableDataRow(Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 274 | Medium |
| Unused field: edu.columbia.rascal.presentation.irb.pages.IrbQueueCTSACorrespondenceView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to parmString in edu.columbia.rascal.presentation.irb.pages.IrbQueueCancerCenterCorrespondenceView.setTableDataRow(Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 269 | Medium |
| Dead store to protocolNumber in edu.columbia.rascal.presentation.irb.pages.IrbQueueCancerCenterCorrespondenceView.setTableDataRow(Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 274 | Medium |
| Unused field: edu.columbia.rascal.presentation.irb.pages.IrbQueueCancerCenterCorrespondenceView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to parmString in edu.columbia.rascal.presentation.irb.pages.IrbQueueChairCorrespondenceView.setTableDataRow(Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 331 | Medium |
| Dead store to protocolNumber in edu.columbia.rascal.presentation.irb.pages.IrbQueueChairCorrespondenceView.setTableDataRow(Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 336 | Medium |
| Unused field: edu.columbia.rascal.presentation.irb.pages.IrbQueueChairCorrespondenceView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of app at line 621 of value previously dereferenced in edu.columbia.rascal.presentation.irb.pages.IrbQueueChairView.getClosureWidget(Vector, CUHtmlTable) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 621 | Medium |
| Nullcheck of app at line 360 of value previously dereferenced in edu.columbia.rascal.presentation.irb.pages.IrbQueueChairView.getProtocolWidget(Vector, CUHtmlTable) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 360 | Medium |
| Nullcheck of app at line 794 of value previously dereferenced in edu.columbia.rascal.presentation.irb.pages.IrbQueueChairView.getUnanticipateWidget(Vector, CUHtmlTable) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 794 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to text in edu.columbia.rascal.presentation.irb.pages.IrbQueueConsultantView.getServletLinkFor(String, String, String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 445 | High |
| Redundant nullcheck of dateObj, which is known to be non-null in edu.columbia.rascal.presentation.irb.pages.IrbQueueConsultantView.getExpeditableTable(Vector, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 352 | Medium |
| Useless control flow in edu.columbia.rascal.presentation.irb.pages.IrbQueueConsultantView.getExpeditableTable(Vector, String) | STYLE | UCF_USELESS_CONTROL_FLOW | 415 | Medium |
| Useless object stored in variable columns of method edu.columbia.rascal.presentation.irb.pages.IrbQueueConsultantView.getExpeditableTable(Vector, String) | STYLE | UC_USELESS_OBJECT | 288 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Load of known null value in edu.columbia.rascal.presentation.irb.pages.IrbQueueLoggerView.getSection(String, Vector, CUHtmlTable) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 528 | Medium |
| Nullcheck of app at line 429 of value previously dereferenced in edu.columbia.rascal.presentation.irb.pages.IrbQueueLoggerView.getSection(String, Vector, CUHtmlTable) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 429 | Medium |
| Nullcheck of app at line 450 of value previously dereferenced in edu.columbia.rascal.presentation.irb.pages.IrbQueueLoggerView.getSection(String, Vector, CUHtmlTable) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 450 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to parmString in edu.columbia.rascal.presentation.irb.pages.IrbQueueNotifyCorrespondenceView.setTableDataRow(Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 262 | Medium |
| Dead store to protocolNumber in edu.columbia.rascal.presentation.irb.pages.IrbQueueNotifyCorrespondenceView.setTableDataRow(Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 263 | Medium |
| Unused field: edu.columbia.rascal.presentation.irb.pages.IrbQueueNotifyCorrespondenceView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to text in edu.columbia.rascal.presentation.irb.pages.IrbQueueReviewerForChairView.getServletLinkFor(String, String, String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 608 | High |
| edu.columbia.rascal.presentation.irb.pages.IrbQueueReviewerForChairView.getEventTable(Vector, String) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 292 | Medium |
| edu.columbia.rascal.presentation.irb.pages.IrbQueueReviewerForChairView.getProtocolTable(Vector, String) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 458 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to text in edu.columbia.rascal.presentation.irb.pages.IrbQueueReviewerView.getServletLinkFor(String, String, String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 764 | High |
| edu.columbia.rascal.presentation.irb.pages.IrbQueueReviewerView.getEventTable(Vector, String) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 386 | Medium |
| edu.columbia.rascal.presentation.irb.pages.IrbQueueReviewerView.getProtocolTable(Vector, String) invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 585 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to titleLen in edu.columbia.rascal.presentation.irb.pages.IrbQueueStipulatedApprovalView.getColumns(String) | STYLE | DLS_DEAD_LOCAL_STORE | 338 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Useless control flow in edu.columbia.rascal.presentation.irb.pages.IrbQueueValidatePaperProtocolView.colorRows(CUHtmlTable) | STYLE | UCF_USELESS_CONTROL_FLOW | 107 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread public/protected field: edu.columbia.rascal.presentation.irb.pages.IrbRecipientEntryView.passKerberos | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 25 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Field IrbRemoveExemptView.parentOid masks field in superclass edu.columbia.rascal.presentation.irb.pages.IrbNotesView | CORRECTNESS | MF_CLASS_MASKS_FIELD | Medium | |
| Unused field: edu.columbia.rascal.presentation.irb.pages.IrbRemoveExemptView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of aString at line 585 of value previously dereferenced in edu.columbia.rascal.presentation.irb.pages.IrbReportApprovalStatusView.getWidgetFor(Float) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 583 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to columns in edu.columbia.rascal.presentation.irb.pages.IrbReportApprovedCountView.getThreeElementsTable(String, String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 506 | High |
| Dead store to titleLen in edu.columbia.rascal.presentation.irb.pages.IrbReportApprovedCountView.getColumns() | STYLE | DLS_DEAD_LOCAL_STORE | 165 | Medium |
| Dead store to titleLen in edu.columbia.rascal.presentation.irb.pages.IrbReportApprovedCountView.getSecondRows() | STYLE | DLS_DEAD_LOCAL_STORE | 480 | Medium |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.irb.pages.IrbReportApprovedCountView.getReportTotalWidget(Vector, CUHtmlTable) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 198 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to titleLen in edu.columbia.rascal.presentation.irb.pages.IrbReportCancerCenterStatsView.getColumns() | STYLE | DLS_DEAD_LOCAL_STORE | 126 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of aString at line 561 of value previously dereferenced in edu.columbia.rascal.presentation.irb.pages.IrbReportCancerCenterStatusView.getWidgetFor(Float) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 559 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.irb.pages.IrbReportClinicalTrialsFirstSubmissionStatusView.addGeneralInformation(Vector, Vector) uses the same code for two branches | STYLE | DB_DUPLICATE_BRANCHES | 199 | Medium |
| Nullcheck of aString at line 381 of value previously dereferenced in edu.columbia.rascal.presentation.irb.pages.IrbReportClinicalTrialsFirstSubmissionStatusView.getWidgetFor(Float) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 379 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.irb.pages.IrbReportClinicalTrialsStatusView.addGeneralInformation(Vector, Vector) uses the same code for two branches | STYLE | DB_DUPLICATE_BRANCHES | 201 | Medium |
| Nullcheck of aString at line 389 of value previously dereferenced in edu.columbia.rascal.presentation.irb.pages.IrbReportClinicalTrialsStatusView.getWidgetFor(Float) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 387 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to titleLen in edu.columbia.rascal.presentation.irb.pages.IrbReportCommitteeOverallStats2View.getColumns() | STYLE | DLS_DEAD_LOCAL_STORE | 158 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to subject in edu.columbia.rascal.presentation.irb.pages.IrbReportCommitteeOverallStatsView.getReportPart1TotalWidget(Vector, CUHtmlTable) | STYLE | DLS_DEAD_LOCAL_STORE | 336 | High |
| Dead store to blank in edu.columbia.rascal.presentation.irb.pages.IrbReportCommitteeOverallStatsView.getReportPart1Widget(Vector, CUHtmlTable) | STYLE | DLS_DEAD_LOCAL_STORE | 445 | High |
| Dead store to titleLen in edu.columbia.rascal.presentation.irb.pages.IrbReportCommitteeOverallStatsView.get2ndColumns() | STYLE | DLS_DEAD_LOCAL_STORE | 176 | Medium |
| Dead store to titleLen in edu.columbia.rascal.presentation.irb.pages.IrbReportCommitteeOverallStatsView.getColumns() | STYLE | DLS_DEAD_LOCAL_STORE | 202 | Medium |
| Dead store to aRow in edu.columbia.rascal.presentation.irb.pages.IrbReportCommitteeOverallStatsView.getReportPart1TotalWidget(Vector, CUHtmlTable) | STYLE | DLS_DEAD_LOCAL_STORE | 328 | Medium |
| Dead store to aRow in edu.columbia.rascal.presentation.irb.pages.IrbReportCommitteeOverallStatsView.getReportPart1Widget(Vector, CUHtmlTable) | STYLE | DLS_DEAD_LOCAL_STORE | 438 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to titleLen in edu.columbia.rascal.presentation.irb.pages.IrbReportCommitteeStatsView.getColumns() | STYLE | DLS_DEAD_LOCAL_STORE | 137 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to committee_list in edu.columbia.rascal.presentation.irb.pages.IrbReportCurrentActivityDateRangeView.addGeneralRows(CUHtmlTable, int, String) | STYLE | DLS_DEAD_LOCAL_STORE | 187 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of aString at line 1128 of value previously dereferenced in edu.columbia.rascal.presentation.irb.pages.IrbReportCurrentActivityStatusView.getWidgetFor(Float) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 1126 | High |
| Useless object stored in variable columns1 of method new edu.columbia.rascal.presentation.irb.pages.IrbReportCurrentActivityStatusView(Vector, String, boolean, String, String, String, String, boolean, String, String) | STYLE | UC_USELESS_OBJECT | 104 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to firstOne in edu.columbia.rascal.presentation.irb.pages.IrbReportDepartmentDateRangeView.getDeptNameWidget() | STYLE | DLS_DEAD_LOCAL_STORE | 222 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of aString at line 425 of value previously dereferenced in edu.columbia.rascal.presentation.irb.pages.IrbReportDepartmentStatusView.getWidgetFor(Float) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 423 | High |
| Unread field: edu.columbia.rascal.presentation.irb.pages.IrbReportDepartmentStatusView.deptName | PERFORMANCE | URF_UNREAD_FIELD | 78 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to used in edu.columbia.rascal.presentation.irb.pages.IrbReportDeviceStudyView.createFlatTable(CUSortVector) | STYLE | DLS_DEAD_LOCAL_STORE | 267 | High |
| Dead store to headerList in edu.columbia.rascal.presentation.irb.pages.IrbReportDeviceStudyView.createFlatTable(CUSortVector) | STYLE | DLS_DEAD_LOCAL_STORE | 271 | Medium |
| Dead store to size in edu.columbia.rascal.presentation.irb.pages.IrbReportDeviceStudyView.createNestedChildTable(Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 369 | Medium |
| Dead store to headerList in edu.columbia.rascal.presentation.irb.pages.IrbReportDeviceStudyView.createNestedParentTable(CUSortVector) | STYLE | DLS_DEAD_LOCAL_STORE | 454 | Medium |
| Nullcheck of IrbReportDeviceStudyView.format at line 144 of value previously dereferenced in edu.columbia.rascal.presentation.irb.pages.IrbReportDeviceStudyView.addFields(CUSortVector) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 126 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to used in edu.columbia.rascal.presentation.irb.pages.IrbReportDrugDeviceStudyView.createFlatTable(CUSortVector) | STYLE | DLS_DEAD_LOCAL_STORE | 266 | High |
| Dead store to headerList in edu.columbia.rascal.presentation.irb.pages.IrbReportDrugDeviceStudyView.createFlatTable(CUSortVector) | STYLE | DLS_DEAD_LOCAL_STORE | 270 | Medium |
| Dead store to size in edu.columbia.rascal.presentation.irb.pages.IrbReportDrugDeviceStudyView.createNestedChildTable(Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 368 | Medium |
| Dead store to headerList in edu.columbia.rascal.presentation.irb.pages.IrbReportDrugDeviceStudyView.createNestedParentTable(CUSortVector) | STYLE | DLS_DEAD_LOCAL_STORE | 457 | Medium |
| Nullcheck of IrbReportDrugDeviceStudyView.format at line 110 of value previously dereferenced in edu.columbia.rascal.presentation.irb.pages.IrbReportDrugDeviceStudyView.addFields(CUSortVector) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 92 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of aString at line 422 of value previously dereferenced in edu.columbia.rascal.presentation.irb.pages.IrbReportExpirationDateView.getWidgetFor(Float) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 420 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to text in edu.columbia.rascal.presentation.irb.pages.IrbReportExpiredUnclosuredView.createSubTable(CUSortVector) | STYLE | DLS_DEAD_LOCAL_STORE | 224 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of name in new edu.columbia.rascal.presentation.irb.pages.IrbReportHistoryView(Vector, boolean, String, String, String, String, String, boolean, String) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 112 | Medium |
| Nullcheck of aString at line 623 of value previously dereferenced in edu.columbia.rascal.presentation.irb.pages.IrbReportHistoryView.getWidgetFor(Float) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 621 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: edu.columbia.rascal.presentation.irb.pages.IrbReportMainMenuView.iAmAdminB | PERFORMANCE | URF_UNREAD_FIELD | 373 | Medium |
| Unread field: edu.columbia.rascal.presentation.irb.pages.IrbReportMainMenuView.iAmAdminC | PERFORMANCE | URF_UNREAD_FIELD | 374 | Medium |
| Unread field: edu.columbia.rascal.presentation.irb.pages.IrbReportMainMenuView.iAmAdminD | PERFORMANCE | URF_UNREAD_FIELD | 375 | Medium |
| Unread field: edu.columbia.rascal.presentation.irb.pages.IrbReportMainMenuView.iAmCPDM | PERFORMANCE | URF_UNREAD_FIELD | 379 | Medium |
| Unread field: edu.columbia.rascal.presentation.irb.pages.IrbReportMainMenuView.iAmPsych | PERFORMANCE | URF_UNREAD_FIELD | 382 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to titleLen in edu.columbia.rascal.presentation.irb.pages.IrbReportOverallCommStatsAfterLogInView.getColumns() | STYLE | DLS_DEAD_LOCAL_STORE | 195 | Medium |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.irb.pages.IrbReportOverallCommStatsAfterLogInView.getReportPart1Widget(Vector, CUHtmlTable) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 494 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.pages.IrbReportOverallCommStatsAfterLogInView.getReportPart1Widget(Vector, CUHtmlTable) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 498 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to columns in edu.columbia.rascal.presentation.irb.pages.IrbReportSubmissionCountView.getThreeElementsTable(String, String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 506 | High |
| Dead store to titleLen in edu.columbia.rascal.presentation.irb.pages.IrbReportSubmissionCountView.getColumns() | STYLE | DLS_DEAD_LOCAL_STORE | 165 | Medium |
| Dead store to titleLen in edu.columbia.rascal.presentation.irb.pages.IrbReportSubmissionCountView.getSecondRows() | STYLE | DLS_DEAD_LOCAL_STORE | 477 | Medium |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.irb.pages.IrbReportSubmissionCountView.getReportTotalWidget(Vector, CUHtmlTable) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 201 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to titleLen in edu.columbia.rascal.presentation.irb.pages.IrbReportSubmissionTimeView.getColumns() | STYLE | DLS_DEAD_LOCAL_STORE | 165 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.pages.IrbResearchQuestionPopupView.addGeneralRows(CUHtmlTable) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 144 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.irb.pages.IrbUnanticipatedAttachmentExternalView.buildAttachmentRows(Vector) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 202 | Medium |
| Dead store to checkRascal in edu.columbia.rascal.presentation.irb.pages.IrbUnanticipatedAttachmentExternalView.buildAttachmentRows(Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 186 | Medium |
| Dead store to iAm in edu.columbia.rascal.presentation.irb.pages.IrbUnanticipatedAttachmentExternalView.buildAttachmentRows(Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 184 | Medium |
| Dead store to titleLen in edu.columbia.rascal.presentation.irb.pages.IrbUnanticipatedAttachmentExternalView.getColumns() | STYLE | DLS_DEAD_LOCAL_STORE | 243 | Medium |
| Dead store to st in edu.columbia.rascal.presentation.irb.pages.IrbUnanticipatedAttachmentExternalView.setAttachmentTableDataRow(CUHtmlTable, String, String, String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 466 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.irb.pages.IrbUnanticipatedAttachmentInternalView.buildAttachmentRows(Vector) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 202 | Medium |
| Dead store to titleLen in edu.columbia.rascal.presentation.irb.pages.IrbUnanticipatedAttachmentInternalView.getColumns() | STYLE | DLS_DEAD_LOCAL_STORE | 240 | Medium |
| Dead store to statusName in edu.columbia.rascal.presentation.irb.pages.IrbUnanticipatedAttachmentInternalView.setAttachmentHead(CUHtmlTable) | STYLE | DLS_DEAD_LOCAL_STORE | 378 | Medium |
| Dead store to attachment in edu.columbia.rascal.presentation.irb.pages.IrbUnanticipatedAttachmentInternalView.setAttachmentTableDataRow(CUHtmlTable, String, String, String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 470 | Medium |
| Dead store to st in edu.columbia.rascal.presentation.irb.pages.IrbUnanticipatedAttachmentInternalView.setAttachmentTableDataRow(CUHtmlTable, String, String, String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 472 | Medium |
| Dead store to statusName in edu.columbia.rascal.presentation.irb.pages.IrbUnanticipatedAttachmentInternalView.setAttachmentTableDataRow(CUHtmlTable, String, String, String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 467 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.irb.pages.IrbUnanticipatedAttachmentView.buildAttachmentRows(Vector) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 206 | Medium |
| Dead store to anOid in edu.columbia.rascal.presentation.irb.pages.IrbUnanticipatedAttachmentView.addAttachmentRows(CUHtmlForm) | STYLE | DLS_DEAD_LOCAL_STORE | 81 | Medium |
| Dead store to titleLen in edu.columbia.rascal.presentation.irb.pages.IrbUnanticipatedAttachmentView.getColumns() | STYLE | DLS_DEAD_LOCAL_STORE | 232 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: edu.columbia.rascal.presentation.irb.pages.IrbUnanticipatedDataSheetView.protocolId | PERFORMANCE | URF_UNREAD_FIELD | 389 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Load of known null value in edu.columbia.rascal.presentation.irb.pages.IrbUnanticipatedPDFDataSheetView.constructPDFDatabaseForm() | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 624 | Medium |
| Return value of edu.columbia.rascal.presentation.common.pdf.CURascalPDFFormConstruction.getPDFPage() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 156 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of protocol in edu.columbia.rascal.presentation.irb.servlets.HzAttestationCertifiedDataSheetServlet.getPDFPage() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 121 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.irb.servlets.HzAttestationSearchServlet.prepareText(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 78 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of phOid, which is known to be non-null in edu.columbia.rascal.presentation.irb.servlets.HzPDFAttestationtDecipherServlet.doGet(HttpServletRequest, HttpServletResponse) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 80 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to results in edu.columbia.rascal.presentation.irb.servlets.IrbAbstractServlet.getMeetingDate(String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 336 | High |
| Dead store to row in edu.columbia.rascal.presentation.irb.servlets.IrbAbstractServlet.getMeetingDate(String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 337 | High |
| Nullcheck of protocolStaffVector at line 728 of value previously dereferenced in edu.columbia.rascal.presentation.irb.servlets.IrbAbstractServlet.setOwnerSurrogate() | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 728 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to notes in edu.columbia.rascal.presentation.irb.servlets.IrbApprovalEntryServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 111 | High |
| Dead store to oid in edu.columbia.rascal.presentation.irb.servlets.IrbApprovalEntryServlet.submit() | STYLE | DLS_DEAD_LOCAL_STORE | 167 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null passed for non-null parameter of new edu.columbia.rascal.presentation.irb.pages.IrbApprovalView(Object, String, IrbProtocol, RascalUser) in edu.columbia.rascal.presentation.irb.servlets.IrbApprovalServlet.getPage() | CORRECTNESS | NP_NULL_PARAM_DEREF | 69 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of role in edu.columbia.rascal.presentation.irb.servlets.IrbCommitteeMemberEntryServlet.saveEditValues(IrbCommitteeMember) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 138 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to ru in edu.columbia.rascal.presentation.irb.servlets.IrbConcurrentStudyRemoveServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 48 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.irb.servlets.IrbConcurrentStudyServlet.saveConcurrentStudyValues() uses the same code for two branches | STYLE | DB_DUPLICATE_BRANCHES | 102 | Medium |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.irb.servlets.IrbConcurrentStudyServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 126 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.irb.servlets.IrbCorrespondenceCreateServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 372 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.irb.servlets.IrbCorrespondenceEditServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 277 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.irb.servlets.IrbCorrespondenceRespondServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 581 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of ph in edu.columbia.rascal.presentation.irb.servlets.IrbCorrespondenceReturnOrApproveCreateServlet.sendEmail(Integer, IrbCorrespondence, String) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 839 | High |
| Possible null pointer dereference of chairs in edu.columbia.rascal.presentation.irb.servlets.IrbCorrespondenceReturnOrApproveCreateServlet.sendEmailToChairAndViceChair(String, String) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 934 | Medium |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.irb.servlets.IrbCorrespondenceReturnOrApproveCreateServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 1050 | Medium |
| Nullcheck of staff at line 1415 of value previously dereferenced in edu.columbia.rascal.presentation.irb.servlets.IrbCorrespondenceReturnOrApproveCreateServlet.sendHazMatsTrainingEmails(IrbProtocolHeader, Vector) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 1415 | Medium |
| edu.columbia.rascal.presentation.irb.servlets.IrbCorrespondenceReturnOrApproveCreateServlet.checkStipulatedApprovals(IrbProtocolHeader) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 265 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.irb.servlets.IrbExemptionFederalRegulationServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 87 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to ru in edu.columbia.rascal.presentation.irb.servlets.IrbExemptionRemoveServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 48 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to ru in edu.columbia.rascal.presentation.irb.servlets.IrbExpeditableAnswerRemoveServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 48 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.irb.servlets.IrbExpeditedCategoryServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 145 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to anOid in edu.columbia.rascal.presentation.irb.servlets.IrbMainMenuServlet.submit() | STYLE | DLS_DEAD_LOCAL_STORE | 83 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.irb.servlets.IrbMiscellaneousReviewerEntryServlet.submit() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 100 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to ru in edu.columbia.rascal.presentation.irb.servlets.IrbMiscellaneousReviewerRemoveServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 52 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to notes in edu.columbia.rascal.presentation.irb.servlets.IrbNotesServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 91 | Medium |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.irb.servlets.IrbNotesServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 347 | Medium |
| Nullcheck of ph at line 277 of value previously dereferenced in edu.columbia.rascal.presentation.irb.servlets.IrbNotesServlet.sendEmail(int, String, String, String) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 275 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to notes in edu.columbia.rascal.presentation.irb.servlets.IrbNotesViewOnlyServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 55 | Medium |
| Possible null pointer dereference of parentObject in edu.columbia.rascal.presentation.irb.servlets.IrbNotesViewOnlyServlet.getPage() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 85 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| out is null guaranteed to be dereferenced in edu.columbia.rascal.presentation.irb.servlets.IrbPDFAbstractServlet.getServletRefreshString(HttpServletResponse, HttpServletRequest) on exception path | CORRECTNESS | NP_GUARANTEED_DEREF_ON_EXCEPTION_PATH | 152 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to PDFObjects in edu.columbia.rascal.presentation.irb.servlets.IrbPDFDataSheetDecipherServlet.getPDFObjects(long) | STYLE | DLS_DEAD_LOCAL_STORE | 211 | High |
| Redundant nullcheck of StringBuilder.toString(), which is known to be non-null in edu.columbia.rascal.presentation.irb.servlets.IrbPDFDataSheetDecipherServlet.getProtocolHeaderList(long) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 365 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to protocol in edu.columbia.rascal.presentation.irb.servlets.IrbPaperProtocolSubmitServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 174 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.irb.servlets.IrbPiEntryServlet.checkConflicts(RascalUser, String, String, String, String) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 122 | Medium |
| edu.columbia.rascal.presentation.irb.servlets.IrbPiEntryServlet.saveEditValues(RascalUser, String, String, String) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 204 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.irb.servlets.IrbProtocolAdminChairSearchServlet.prepareText(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 74 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to link in edu.columbia.rascal.presentation.irb.servlets.IrbProtocolAdminClosureServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 99 | Medium |
| Dead store to rUser in edu.columbia.rascal.presentation.irb.servlets.IrbProtocolAdminClosureServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 58 | Medium |
| Dead store to termOid in edu.columbia.rascal.presentation.irb.servlets.IrbProtocolAdminClosureServlet.getRedirectUrl() | STYLE | DLS_DEAD_LOCAL_STORE | 122 | Medium |
| Possible null pointer dereference of term in edu.columbia.rascal.presentation.irb.servlets.IrbProtocolAdminClosureServlet.saveClosureValues() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 181 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of id in edu.columbia.rascal.presentation.irb.servlets.IrbProtocolApprovalLetterServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 289 | Medium |
| Exception is caught when Exception is not thrown in edu.columbia.rascal.presentation.irb.servlets.IrbProtocolApprovalLetterServlet.submit() | STYLE | REC_CATCH_EXCEPTION | 355 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.irb.servlets.IrbProtocolExemptionEntryServlet.saveEditValues(String) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 96 | Medium |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.irb.servlets.IrbProtocolExemptionEntryServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 172 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.irb.servlets.IrbProtocolMedicareApprovalServlet.getAttachedData(long) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 62 | Medium |
| Dead store to size in edu.columbia.rascal.presentation.irb.servlets.IrbProtocolMedicareApprovalServlet.isDeviceStudy(IrbProtocolHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 126 | Medium |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.servlets.IrbProtocolMedicareApprovalServlet.getAttachedData(long) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 62 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.irb.servlets.IrbProtocolRascalSearchServlet.prepareText(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 72 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Boxed value is unboxed and then immediately reboxed in edu.columbia.rascal.presentation.irb.servlets.IrbProtocolRenewalOversightMonitoringServlet.saveRenewalOversightMonitoringValues() | PERFORMANCE | BX_UNBOXING_IMMEDIATELY_REBOXED | 151 | Medium |
| Dead store to percent in edu.columbia.rascal.presentation.irb.servlets.IrbProtocolRenewalOversightMonitoringServlet.saveRenewalOversightMonitoringValues() | STYLE | DLS_DEAD_LOCAL_STORE | 109 | High |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.irb.servlets.IrbProtocolRenewalOversightMonitoringServlet.saveRenewalOversightMonitoringValues() | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 151 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.irb.servlets.IrbProtocolSearchServlet.prepareText(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 78 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to link in edu.columbia.rascal.presentation.irb.servlets.IrbProtocolStudyDescriptionDataSheetServlet.getPDFPage() | STYLE | DLS_DEAD_LOCAL_STORE | 65 | Medium |
| Possible null pointer dereference of protocol in edu.columbia.rascal.presentation.irb.servlets.IrbProtocolStudyDescriptionDataSheetServlet.getPDFPage() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 74 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to senderEmail in edu.columbia.rascal.presentation.irb.servlets.IrbProtocolValidateApproveServlet.generateEmail(RascalUser, IrbProtocolHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 167 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of approval in edu.columbia.rascal.presentation.irb.servlets.IrbQueueApprovalConfirmServlet.saveApprovalValues() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 132 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of others in edu.columbia.rascal.presentation.irb.servlets.IrbQueueChairServlet.getPage() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 111 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of others in edu.columbia.rascal.presentation.irb.servlets.IrbQueueLoggerServlet.getPage() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 268 | Medium |
| Possible null pointer dereference of parentObject in edu.columbia.rascal.presentation.irb.servlets.IrbQueueLoggerServlet.logChange() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 356 | Medium |
| Nullcheck of parentObject at line 409 of value previously dereferenced in edu.columbia.rascal.presentation.irb.servlets.IrbQueueLoggerServlet.logChange() | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 356 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to queueRow in edu.columbia.rascal.presentation.irb.servlets.IrbQueueReviewerForChairServlet.getQueueInfoFor(Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 251 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to queueRow in edu.columbia.rascal.presentation.irb.servlets.IrbQueueReviewerServlet.getQueueInfoFor(Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 321 | Medium |
| Possible null pointer dereference of others in edu.columbia.rascal.presentation.irb.servlets.IrbQueueReviewerServlet.getPage() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 227 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to corr in edu.columbia.rascal.presentation.irb.servlets.IrbRecipientEntryServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 62 | Medium |
| Dead store to parentName in edu.columbia.rascal.presentation.irb.servlets.IrbRecipientEntryServlet.saveRecipiantValues() | STYLE | DLS_DEAD_LOCAL_STORE | 115 | Medium |
| Dead store to role in edu.columbia.rascal.presentation.irb.servlets.IrbRecipientEntryServlet.saveRecipiantValues() | STYLE | DLS_DEAD_LOCAL_STORE | 108 | Medium |
| Dead store to recipientAddEdit in edu.columbia.rascal.presentation.irb.servlets.IrbRecipientEntryServlet.submit() | STYLE | DLS_DEAD_LOCAL_STORE | 219 | Medium |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.irb.servlets.IrbRecipientEntryServlet.submit() | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 226 | Medium |
| edu.columbia.rascal.presentation.irb.servlets.IrbRecipientEntryServlet.saveRecipiantValues() invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 145 | Medium |
| edu.columbia.rascal.presentation.irb.servlets.IrbRecipientEntryServlet.submit() invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 226 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to notes in edu.columbia.rascal.presentation.irb.servlets.IrbRemoveExemptServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 52 | High |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.irb.servlets.IrbRemoveExemptServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 114 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to results in edu.columbia.rascal.presentation.irb.servlets.IrbReportActiveApprovedProtocolServlet.getSelectedData(String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 49 | Medium |
| edu.columbia.rascal.presentation.irb.servlets.IrbReportActiveApprovedProtocolServlet.getPage() invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 85 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to results in edu.columbia.rascal.presentation.irb.servlets.IrbReportApprovalStatusServlet.getSelectedData(String, String, String, String, Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 55 | Medium |
| edu.columbia.rascal.presentation.irb.servlets.IrbReportApprovalStatusServlet.getPage() invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 114 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to from in edu.columbia.rascal.presentation.irb.servlets.IrbReportCancerCenterDateRangeServlet.validatePost() | STYLE | DLS_DEAD_LOCAL_STORE | 112 | Medium |
| Dead store to to in edu.columbia.rascal.presentation.irb.servlets.IrbReportCancerCenterDateRangeServlet.validatePost() | STYLE | DLS_DEAD_LOCAL_STORE | 113 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to tempResult in edu.columbia.rascal.presentation.irb.servlets.IrbReportCancerCenterStatsServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 46 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to view in edu.columbia.rascal.presentation.irb.servlets.IrbReportCancerCenterStatusServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 125 | Medium |
| Dead store to results in edu.columbia.rascal.presentation.irb.servlets.IrbReportCancerCenterStatusServlet.getSelectedData(String, String, boolean, String) | STYLE | DLS_DEAD_LOCAL_STORE | 53 | Medium |
| edu.columbia.rascal.presentation.irb.servlets.IrbReportCancerCenterStatusServlet.getPage() invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 102 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to columns in edu.columbia.rascal.presentation.irb.servlets.IrbReportClinicalTrialsFirstSubmissionStatusServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 72 | Medium |
| Dead store to results in edu.columbia.rascal.presentation.irb.servlets.IrbReportClinicalTrialsFirstSubmissionStatusServlet.getSelectedData(String, String, Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 50 | Medium |
| edu.columbia.rascal.presentation.irb.servlets.IrbReportClinicalTrialsFirstSubmissionStatusServlet.getPage() invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 89 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to columns in edu.columbia.rascal.presentation.irb.servlets.IrbReportClinicalTrialsStatusServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 74 | Medium |
| Dead store to results in edu.columbia.rascal.presentation.irb.servlets.IrbReportClinicalTrialsStatusServlet.getSelectedData(String, String, Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 51 | Medium |
| edu.columbia.rascal.presentation.irb.servlets.IrbReportClinicalTrialsStatusServlet.getPage() invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 91 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to reportType in edu.columbia.rascal.presentation.irb.servlets.IrbReportCommOverallStatsLogInServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 50 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to reportType in edu.columbia.rascal.presentation.irb.servlets.IrbReportCommitteeOverallStats2Servlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 50 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to tempResult in edu.columbia.rascal.presentation.irb.servlets.IrbReportCommitteeOverallStatsServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 60 | High |
| Dead store to reportType in edu.columbia.rascal.presentation.irb.servlets.IrbReportCommitteeOverallStatsServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 50 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to tempResult in edu.columbia.rascal.presentation.irb.servlets.IrbReportCommitteeStatsServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 46 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to rows in edu.columbia.rascal.presentation.irb.servlets.IrbReportCurrentActivityStatusServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 124 | Medium |
| Useless assignment in return from edu.columbia.rascal.presentation.irb.servlets.IrbReportCurrentActivityStatusServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE_IN_RETURN | 202 | Medium |
| edu.columbia.rascal.presentation.irb.servlets.IrbReportCurrentActivityStatusServlet.getPage() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 137 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to columns in edu.columbia.rascal.presentation.irb.servlets.IrbReportDepartmentStatusServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 76 | Medium |
| Dead store to deptCodes in edu.columbia.rascal.presentation.irb.servlets.IrbReportDepartmentStatusServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 67 | Medium |
| Dead store to results in edu.columbia.rascal.presentation.irb.servlets.IrbReportDepartmentStatusServlet.getSelectedData(Vector, Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 48 | Medium |
| edu.columbia.rascal.presentation.irb.servlets.IrbReportDepartmentStatusServlet.getPage() invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 103 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to results in edu.columbia.rascal.presentation.irb.servlets.IrbReportDrugDeviceStudyServlet.getSelectedData(String, String, String, Vector, Vector, Vector, Vector, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 55 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to results in edu.columbia.rascal.presentation.irb.servlets.IrbReportEventStatusServlet.getSelectedData(String, String, String, String, Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 55 | Medium |
| edu.columbia.rascal.presentation.irb.servlets.IrbReportEventStatusServlet.getPage() invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 114 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to results in edu.columbia.rascal.presentation.irb.servlets.IrbReportExpirationDateServlet.getSelectedData(String, String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 51 | Medium |
| edu.columbia.rascal.presentation.irb.servlets.IrbReportExpirationDateServlet.getPage() invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 96 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to results in edu.columbia.rascal.presentation.irb.servlets.IrbReportExpiredUnclosuredServlet.getSelectedData(String, String, Vector, int) | STYLE | DLS_DEAD_LOCAL_STORE | 50 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to results in edu.columbia.rascal.presentation.irb.servlets.IrbReportHistoryServlet.getSelectedData(String, String, String, int, String) | STYLE | DLS_DEAD_LOCAL_STORE | 56 | Medium |
| edu.columbia.rascal.presentation.irb.servlets.IrbReportHistoryServlet.getPage() invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 128 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to results in edu.columbia.rascal.presentation.irb.servlets.IrbReportInProcessProtocolServlet.getSelectedData(String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 49 | Medium |
| edu.columbia.rascal.presentation.irb.servlets.IrbReportInProcessProtocolServlet.getPage() invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 85 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to ru in edu.columbia.rascal.presentation.irb.servlets.IrbResearchQuestionRemoveServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 48 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.irb.servlets.IrbResearchQuestionServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 125 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of parentObject in edu.columbia.rascal.presentation.irb.servlets.IrbReturnToChairServlet.getPage() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 119 | Medium |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.irb.servlets.IrbReturnToChairServlet.getPage() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 137 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of ae in edu.columbia.rascal.presentation.irb.servlets.IrbUnanticipatedAttachmentExternalServlet.getPage() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 86 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of ae in edu.columbia.rascal.presentation.irb.servlets.IrbUnanticipatedAttachmentInternalServlet.getPage() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 87 | Medium |
| Suspicious comparison of Integer references in edu.columbia.rascal.presentation.irb.servlets.IrbUnanticipatedAttachmentInternalServlet.getPage() | CORRECTNESS | RC_REF_COMPARISON | 87 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to ru in edu.columbia.rascal.presentation.irb.servlets.IrbUnanticipatedAttachmentRemoveServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 48 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null passed for non-null parameter of new edu.columbia.rascal.presentation.irb.pages.IrbUnanticipatedAttachmentView(IrbUnanticipatedProblem, RascalUser) in edu.columbia.rascal.presentation.irb.servlets.IrbUnanticipatedAttachmentServlet.getPage() | CORRECTNESS | NP_NULL_PARAM_DEREF | 92 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to link in edu.columbia.rascal.presentation.irb.servlets.IrbUnanticipatedDataSheetServlet.getPDFPage() | STYLE | DLS_DEAD_LOCAL_STORE | 88 | Medium |
| Dead store to link in edu.columbia.rascal.presentation.irb.servlets.IrbUnanticipatedDataSheetServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 54 | Medium |
| Possible null pointer dereference of unanticipate in edu.columbia.rascal.presentation.irb.servlets.IrbUnanticipatedDataSheetServlet.getPDFPage() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 95 | Medium |
| Possible null pointer dereference of unanticipate in edu.columbia.rascal.presentation.irb.servlets.IrbUnanticipatedDataSheetServlet.getPage() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 61 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of up at line 44 of value previously dereferenced in edu.columbia.rascal.presentation.irb.servlets.IrbUnanticipatedLinkFrameServlet.getPage() | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 44 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to attached in edu.columbia.rascal.presentation.irb.servlets.IrbUnanticipatedSubmitServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 162 | Medium |
| Dead store to followUpNumber in edu.columbia.rascal.presentation.irb.servlets.IrbUnanticipatedSubmitServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 159 | Medium |
| Dead store to oldSize in edu.columbia.rascal.presentation.irb.servlets.IrbUnanticipatedSubmitServlet.setStipulatedApprovals(IrbTraceableBusinessObject, String) | STYLE | DLS_DEAD_LOCAL_STORE | 301 | Medium |
| Redundant nullcheck of page, which is known to be non-null in edu.columbia.rascal.presentation.irb.servlets.IrbUnanticipatedSubmitServlet.beginPDFProcessing() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 59 | Medium |
| Redundant nullcheck of page, which is known to be non-null in edu.columbia.rascal.presentation.irb.servlets.IrbUnanticipatedSubmitServlet.doGet(HttpServletRequest, HttpServletResponse) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 123 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization and update of static field edu.columbia.rascal.presentation.irb.tools.IrbEmailINDIDEReminderMonitor.timer in edu.columbia.rascal.presentation.irb.tools.IrbEmailINDIDEReminderMonitor.start() | MT_CORRECTNESS | LI_LAZY_INIT_UPDATE_STATIC | 50 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Useless object stored in variable message of method edu.columbia.rascal.presentation.irb.tools.IrbEmailINDIDEReminderTask.generateLogEntries(Vector) | STYLE | UC_USELESS_OBJECT | 79 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization and update of static field edu.columbia.rascal.presentation.irb.tools.IrbEmailProtocolExpirationMonitor.timer in edu.columbia.rascal.presentation.irb.tools.IrbEmailProtocolExpirationMonitor.start() | MT_CORRECTNESS | LI_LAZY_INIT_UPDATE_STATIC | 52 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Useless object stored in variable message of method edu.columbia.rascal.presentation.irb.tools.IrbEmailProtocolExpirationTask.generateRascalEmails(Vector) | STYLE | UC_USELESS_OBJECT | 295 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization and update of static field edu.columbia.rascal.presentation.irb.tools.IrbEmailProtocolExpired30DaysMonitor.timer in edu.columbia.rascal.presentation.irb.tools.IrbEmailProtocolExpired30DaysMonitor.start() | MT_CORRECTNESS | LI_LAZY_INIT_UPDATE_STATIC | 52 | Medium |
| Incorrect lazy initialization and update of static field edu.columbia.rascal.presentation.irb.tools.IrbEmailProtocolExpired30DaysMonitor.timer in edu.columbia.rascal.presentation.irb.tools.IrbEmailProtocolExpired30DaysMonitor.start(String, String) | MT_CORRECTNESS | LI_LAZY_INIT_UPDATE_STATIC | 72 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Useless object stored in variable message of method edu.columbia.rascal.presentation.irb.tools.IrbEmailProtocolExpired30DaysTask.generateRascalEmails(Vector) | STYLE | UC_USELESS_OBJECT | 190 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization and update of static field edu.columbia.rascal.presentation.irb.tools.IrbEmailRenewalMonitor.timer in edu.columbia.rascal.presentation.irb.tools.IrbEmailRenewalMonitor.start() | MT_CORRECTNESS | LI_LAZY_INIT_UPDATE_STATIC | 52 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of ph at line 154 of value previously dereferenced in edu.columbia.rascal.presentation.irb.tools.IrbEmailRenewalTask.generateNotificationEmails(List) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 154 | High |
| Useless object stored in variable message of method edu.columbia.rascal.presentation.irb.tools.IrbEmailRenewalTask.generateRascalEmails(List) | STYLE | UC_USELESS_OBJECT | 218 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization and update of static field edu.columbia.rascal.presentation.irb.tools.IrbEmailReturnedOrPendingEventsMonitor.timer in edu.columbia.rascal.presentation.irb.tools.IrbEmailReturnedOrPendingEventsMonitor.start() | MT_CORRECTNESS | LI_LAZY_INIT_UPDATE_STATIC | 52 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null passed for non-null parameter of edu.columbia.rascal.presentation.tools.emailDistributor.CURascalEmailSender.sendEmail(CURascalEmailMessage) in edu.columbia.rascal.presentation.irb.tools.IrbGeneralEmailMessage.sendEmail(String, String, String, String, String, String) | CORRECTNESS | NP_NULL_PARAM_DEREF | 121 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Return value of String.concat(String) ignored in edu.columbia.rascal.presentation.irb.tools.IrbTreeViewJsBuilder.buildTreeRecursively(Vector, StringBuffer, String, int, boolean) | CORRECTNESS | RV_RETURN_VALUE_IGNORED | 234 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to hah in new edu.columbia.rascal.presentation.lab.pages.HzAppendixCreatedView(Object, RascalUser) | STYLE | DLS_DEAD_LOCAL_STORE | 93 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: edu.columbia.rascal.presentation.lab.pages.HzAppendixCreationView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to menuItems in edu.columbia.rascal.presentation.lab.pages.HzAppendixHeaderOverviewView.addFields(Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 206 | High |
| Dead store to titleLen in edu.columbia.rascal.presentation.lab.pages.HzAppendixHeaderOverviewView.getColumns() | STYLE | DLS_DEAD_LOCAL_STORE | 284 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to docs in new edu.columbia.rascal.presentation.lab.pages.HzAppendixHeaderResultsDisplayView(Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 50 | High |
| Dead store to linkBuffer in edu.columbia.rascal.presentation.lab.pages.HzAppendixHeaderResultsDisplayView.buildForm(Vector, int, int, int, int) | STYLE | DLS_DEAD_LOCAL_STORE | 194 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to hah in new edu.columbia.rascal.presentation.lab.pages.HzAppendixNewView(Object, RascalUser) | STYLE | DLS_DEAD_LOCAL_STORE | 93 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to parmString in edu.columbia.rascal.presentation.lab.pages.HzAppendixQueueNotifyCorrespondenceView.setTableDataRow(Vector, String) | STYLE | DLS_DEAD_LOCAL_STORE | 178 | High |
| Unused field: edu.columbia.rascal.presentation.lab.pages.HzAppendixQueueNotifyCorrespondenceView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: edu.columbia.rascal.presentation.lab.pages.HzAppendixViewCorrespondenceView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium | |
| Unused field: edu.columbia.rascal.presentation.lab.pages.HzAppendixViewCorrespondenceView.theRole | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused public or protected field: edu.columbia.rascal.presentation.lab.pages.HzCheckView.hah | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.lab.pages.HzHazardousMaterialView.getTableCellData(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 262 | Medium |
| Dead store to anOid in edu.columbia.rascal.presentation.lab.pages.HzHazardousMaterialView.setHazardsListTableDataRow(CUHtmlTable, int, String, String, boolean, AppendixTracking, String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 438 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.lab.pages.HzHistoryView.appendixStatusConversionTable should be both final and package protected | MALICIOUS_CODE | MS_FINAL_PKGPROTECT | 51 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.lab.pages.HzHtmlView.getTableCellData(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 1520 | Medium |
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.lab.pages.HzHtmlView.getTableViewTitle(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 1543 | Medium |
| Dead store to values in edu.columbia.rascal.presentation.lab.pages.HzHtmlView.render() | STYLE | DLS_DEAD_LOCAL_STORE | 1666 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.lab.pages.HzHtmlView.getYearWidget(String, int) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 1636 | High |
| edu.columbia.rascal.presentation.lab.pages.HzHtmlView.getDateTable(String, String, String, String, String) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 402 | Medium |
| edu.columbia.rascal.presentation.lab.pages.HzHtmlView.roleConversionTable should be both final and package protected | MALICIOUS_CODE | MS_FINAL_PKGPROTECT | 51 | Medium |
| Unread field: edu.columbia.rascal.presentation.lab.pages.HzHtmlView.base; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 66 | Medium |
| Unread field: edu.columbia.rascal.presentation.lab.pages.HzHtmlView.note | PERFORMANCE | URF_UNREAD_FIELD | 1734 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused public or protected field: edu.columbia.rascal.presentation.lab.pages.HzLinkFrameView.modeDictStrCurrentProtocol | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Medium | |
| Unused public or protected field: edu.columbia.rascal.presentation.lab.pages.HzLinkFrameView.modeDictStrTitle | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to compositeMenuItem in edu.columbia.rascal.presentation.lab.pages.HzMainMenuView.addItems() | STYLE | DLS_DEAD_LOCAL_STORE | 105 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.lab.pages.HzStaffEntryView.addGeneralRows(CUHtmlTable, int) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 255 | Medium |
| edu.columbia.rascal.presentation.lab.pages.HzStaffEntryView.getEditViewWidget() invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 369 | Medium |
| edu.columbia.rascal.presentation.lab.pages.HzStaffEntryView.getStaffRoleWidget() invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 432 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Suspicious comparison of Long references in edu.columbia.rascal.presentation.lab.pages.HzStaffView.addHazMatsTrainingInfo(Integer, CUHtmlTableRow) | CORRECTNESS | RC_REF_COMPARISON | 513 | High |
| Unread field: edu.columbia.rascal.presentation.lab.pages.HzStaffView.tc1150 | PERFORMANCE | URF_UNREAD_FIELD | 59 | Medium |
| Unread field: edu.columbia.rascal.presentation.lab.pages.HzStaffView.tc1150Regs | PERFORMANCE | URF_UNREAD_FIELD | 48 | Medium |
| Unread field: edu.columbia.rascal.presentation.lab.pages.HzStaffView.tc16 | PERFORMANCE | URF_UNREAD_FIELD | 62 | Medium |
| Unread field: edu.columbia.rascal.presentation.lab.pages.HzStaffView.tc1600 | PERFORMANCE | URF_UNREAD_FIELD | 61 | Medium |
| Unread field: edu.columbia.rascal.presentation.lab.pages.HzStaffView.tc1600Regs | PERFORMANCE | URF_UNREAD_FIELD | 50 | Medium |
| Unread field: edu.columbia.rascal.presentation.lab.pages.HzStaffView.tc16Regs | PERFORMANCE | URF_UNREAD_FIELD | 51 | Medium |
| Unread field: edu.columbia.rascal.presentation.lab.pages.HzStaffView.tc25 | PERFORMANCE | URF_UNREAD_FIELD | 60 | Medium |
| Unread field: edu.columbia.rascal.presentation.lab.pages.HzStaffView.tc25Regs | PERFORMANCE | URF_UNREAD_FIELD | 49 | Medium |
| Unread field: edu.columbia.rascal.presentation.lab.pages.HzStaffView.tc502 | PERFORMANCE | URF_UNREAD_FIELD | 63 | Medium |
| Unread field: edu.columbia.rascal.presentation.lab.pages.HzStaffView.tc502Regs | PERFORMANCE | URF_UNREAD_FIELD | 52 | Medium |
| Unread field: edu.columbia.rascal.presentation.lab.pages.HzStaffView.tc508 | PERFORMANCE | URF_UNREAD_FIELD | 56 | Medium |
| Unread field: edu.columbia.rascal.presentation.lab.pages.HzStaffView.tc508Regs | PERFORMANCE | URF_UNREAD_FIELD | 45 | Medium |
| Unread field: edu.columbia.rascal.presentation.lab.pages.HzStaffView.tc509 | PERFORMANCE | URF_UNREAD_FIELD | 57 | Medium |
| Unread field: edu.columbia.rascal.presentation.lab.pages.HzStaffView.tc509Regs | PERFORMANCE | URF_UNREAD_FIELD | 46 | Medium |
| Unread field: edu.columbia.rascal.presentation.lab.pages.HzStaffView.tc950 | PERFORMANCE | URF_UNREAD_FIELD | 58 | Medium |
| Unread field: edu.columbia.rascal.presentation.lab.pages.HzStaffView.tc950Regs | PERFORMANCE | URF_UNREAD_FIELD | 47 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.lab.servlets.HzAbstractServlet.roleConversionTable should be both final and package protected | MALICIOUS_CODE | MS_FINAL_PKGPROTECT | 66 | Medium |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.lab.servlets.HzAbstractServlet.redirectToLogon() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 544 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of page, which is known to be non-null in edu.columbia.rascal.presentation.lab.servlets.HzAppendixHeaderCheckSubmitServlet.doGet(HttpServletRequest, HttpServletResponse) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 155 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to numberPart in edu.columbia.rascal.presentation.lab.servlets.HzAppendixHeaderCreationServlet.generateNewProtocolNumber(HzAppendixHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 49 | Medium |
| edu.columbia.rascal.presentation.lab.servlets.HzAppendixHeaderCreationServlet.letters should be both final and package protected | MALICIOUS_CODE | MS_FINAL_PKGPROTECT | 23 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of newRequestParameter, which is known to be non-null in edu.columbia.rascal.presentation.lab.servlets.HzAppendixHeaderNewServlet.createNewHeaderRequest() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 56 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to pageInfoKeyword in edu.columbia.rascal.presentation.lab.servlets.HzAppendixHeaderSearchPageServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 56 | Medium |
| Dead store to pagesCacheKeyword in edu.columbia.rascal.presentation.lab.servlets.HzAppendixHeaderSearchPageServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 57 | Medium |
| Dead store to procRsltMethodNm in edu.columbia.rascal.presentation.lab.servlets.HzAppendixHeaderSearchPageServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 58 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to view in edu.columbia.rascal.presentation.lab.servlets.HzAppendixHeaderSearchServlet.submit() | STYLE | DLS_DEAD_LOCAL_STORE | 142 | High |
| Dead store to pageInfoKeyword in edu.columbia.rascal.presentation.lab.servlets.HzAppendixHeaderSearchServlet.submit() | STYLE | DLS_DEAD_LOCAL_STORE | 109 | Medium |
| Dead store to pagesCacheKeyword in edu.columbia.rascal.presentation.lab.servlets.HzAppendixHeaderSearchServlet.submit() | STYLE | DLS_DEAD_LOCAL_STORE | 110 | Medium |
| edu.columbia.rascal.presentation.lab.servlets.HzAppendixHeaderSearchServlet.prepareText(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 82 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Return value of Object.toString() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 124 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.lab.servlets.HzStaffEntryServlet.checkConflicts(RascalUser, String, String, String, String) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 133 | Medium |
| edu.columbia.rascal.presentation.lab.servlets.HzStaffEntryServlet.saveEditValues(RascalUser, String, String, String) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 207 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null passed for non-null parameter of edu.columbia.rascal.presentation.tools.emailDistributor.CURascalEmailSender.sendEmail(CURascalEmailMessage) in edu.columbia.rascal.presentation.lab.tools.HzLabGeneralEmailMessage.sendEmail(String, String, String, String, String, String) | CORRECTNESS | NP_NULL_PARAM_DEREF | 148 | Medium |
| Null passed for non-null parameter of edu.columbia.rascal.presentation.tools.emailDistributor.CURascalEmailSender.sendEmail(CURascalEmailMessage) in edu.columbia.rascal.presentation.lab.tools.HzLabGeneralEmailMessage.sendEmail(String, String, String, String, String, String, String, String) | CORRECTNESS | NP_NULL_PARAM_DEREF | 196 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: edu.columbia.rascal.presentation.lookup.pages.RascalActivityTypeLookupMainView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: edu.columbia.rascal.presentation.lookup.pages.RascalAgencyLookupMainView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: edu.columbia.rascal.presentation.lookup.pages.RascalDepartmentLookupSubDeptOutputView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to depts in edu.columbia.rascal.presentation.lookup.pages.RascalDepartmentLookupView.addGeneralRows() | STYLE | DLS_DEAD_LOCAL_STORE | 74 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to values in edu.columbia.rascal.presentation.lookup.pages.RascalLookupHtmlView.render() | STYLE | DLS_DEAD_LOCAL_STORE | 356 | High |
| Dead store to e in edu.columbia.rascal.presentation.lookup.pages.RascalLookupHtmlView.render() | STYLE | DLS_DEAD_LOCAL_STORE | 340 | Medium |
| Unread field: edu.columbia.rascal.presentation.lookup.pages.RascalLookupHtmlView.mainTitle | PERFORMANCE | URF_UNREAD_FIELD | 406 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: edu.columbia.rascal.presentation.lookup.pages.RascalReportDistributionLookupMainView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: edu.columbia.rascal.presentation.lookup.pages.RascalReportDistributionLookupOutputView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.lookup.servlets.RascalActivityTypeLookupServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 62 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.lookup.servlets.RascalDepartmentLookupInputServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 91 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.lookup.servlets.RascalDepartmentLookupServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 62 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.lookup.servlets.RascalUniLookupMainServlet.addEscapeCharTo(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 55 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to menuItems in edu.columbia.rascal.presentation.myRascal.views.MyRascalMainMenuView.addFields() | STYLE | DLS_DEAD_LOCAL_STORE | 226 | Medium |
| Dead store to menuItems in edu.columbia.rascal.presentation.myRascal.views.MyRascalMainMenuView.addFields(RascalUser) | STYLE | DLS_DEAD_LOCAL_STORE | 413 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to docs in new edu.columbia.rascal.presentation.myRascal.views.MyRascalProposalResultsDisplayView(Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 41 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to rows in edu.columbia.rascal.presentation.propTrak.jdbc.PtQueueQuery.getProjectOfficerNames() | STYLE | DLS_DEAD_LOCAL_STORE | 240 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to aRow in edu.columbia.rascal.presentation.propTrak.jdbc.PtSearchQuery.processUserResultSet(List) | STYLE | DLS_DEAD_LOCAL_STORE | 275 | Medium |
| edu.columbia.rascal.presentation.propTrak.jdbc.PtSearchQuery.buildWhereClauseForSelection(CURascalBasicSearchParameter, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 604 | Medium |
| Switch statement found in edu.columbia.rascal.presentation.propTrak.jdbc.PtSearchQuery.buildWhereClauseForSelection(CURascalBasicSearchParameter, String) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 588 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to statusName in edu.columbia.rascal.presentation.propTrak.pages.PtAttachDocumentsView.setAttachmentHead(CUHtmlTable) | STYLE | DLS_DEAD_LOCAL_STORE | 342 | Medium |
| edu.columbia.rascal.presentation.propTrak.pages.PtAttachDocumentsView.buildAttachmentRows(Vector) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 217 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: edu.columbia.rascal.presentation.propTrak.pages.PtCheckFinalizeView.form | PERFORMANCE | URF_UNREAD_FIELD | 26 | Medium |
| Unused public or protected field: edu.columbia.rascal.presentation.propTrak.pages.PtCheckFinalizeView.ph | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to titleLen in edu.columbia.rascal.presentation.propTrak.pages.PtCorrespondenceDispositionView.getColumns() | STYLE | DLS_DEAD_LOCAL_STORE | 285 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.propTrak.pages.PtHtmlView.getDateTable(String, String, String, String, String) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 319 | Medium |
| Nullcheck of selectedItem at line 1238 of value previously dereferenced in edu.columbia.rascal.presentation.propTrak.pages.PtHtmlView.getSingleSelectWidgetFor(EVector, String) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 1238 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.propTrak.pages.PtInternalNotesEntryView.addOldNotes(CUHtmlTable, int) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 184 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.propTrak.pages.PtNotesEntryView.addOldNotes(CUHtmlTable, int) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 174 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.propTrak.pages.PtParticipantEntryView.addGeneralRows(CUHtmlTable, int) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 188 | Medium |
| edu.columbia.rascal.presentation.propTrak.pages.PtParticipantEntryView.getEditViewWidget() invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 261 | Medium |
| edu.columbia.rascal.presentation.propTrak.pages.PtParticipantEntryView.getParticipantTypeWidget() invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 303 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.propTrak.pages.PtPiEntryView.addGeneralRows(CUHtmlTable, int) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 155 | Medium |
| edu.columbia.rascal.presentation.propTrak.pages.PtPiEntryView.getEditViewWidget() invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 221 | Medium |
| edu.columbia.rascal.presentation.propTrak.pages.PtPiEntryView.getParticipantTypeWidget() invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 243 | Medium |
| Unread public/protected field: edu.columbia.rascal.presentation.propTrak.pages.PtPiEntryView.passKerberos | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 28 | Medium |
| Unread public/protected field: edu.columbia.rascal.presentation.propTrak.pages.PtPiEntryView.theSequenceNum | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 282 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of actTypeCode at line 195 of value previously dereferenced in edu.columbia.rascal.presentation.propTrak.pages.PtProjectOfficerDataView.addGeneralRows(CUHtmlTable, int) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 195 | Medium |
| Nullcheck of var at line 288 of value previously dereferenced in edu.columbia.rascal.presentation.propTrak.pages.PtProjectOfficerDataView.addGeneralRows(CUHtmlTable, int) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 288 | Medium |
| Nullcheck of var at line 312 of value previously dereferenced in edu.columbia.rascal.presentation.propTrak.pages.PtProjectOfficerDataView.addGeneralRows(CUHtmlTable, int) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 312 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Useless object stored in variable columns of method edu.columbia.rascal.presentation.propTrak.pages.PtProposalApprovalStatementsView.addGeneralRows(CUHtmlTable, int) | STYLE | UC_USELESS_OBJECT | 130 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Boxed value is unboxed and then immediately reboxed in edu.columbia.rascal.presentation.propTrak.pages.PtProposalApprovalView.addApprovalRows(CUHtmlTable, int) | PERFORMANCE | BX_UNBOXING_IMMEDIATELY_REBOXED | 97 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Boxed value is unboxed and then immediately reboxed in edu.columbia.rascal.presentation.propTrak.pages.PtProposalCoverSheetView.addSignatureLine(PtApproval) | PERFORMANCE | BX_UNBOXING_IMMEDIATELY_REBOXED | 1728 | Medium |
| new edu.columbia.rascal.presentation.propTrak.pages.PtProposalCoverSheetView(PtProposalHeader, String, String, RascalUser) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 133 | Medium |
| Possible null pointer dereference of ru in edu.columbia.rascal.presentation.propTrak.pages.PtProposalCoverSheetView.addGeneralInformation() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 584 | Medium |
| Possible null pointer dereference of ru in edu.columbia.rascal.presentation.propTrak.pages.PtProposalCoverSheetView.addGeneralInformation() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 584 | Medium |
| Nullcheck of ru at line 598 of value previously dereferenced in edu.columbia.rascal.presentation.propTrak.pages.PtProposalCoverSheetView.addGeneralInformation() | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 584 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of pb, which is known to be non-null in new edu.columbia.rascal.presentation.propTrak.pages.PtProposalFundingView(PtProposalHeader, PtBudget, RascalUser, boolean, boolean) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 109 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.propTrak.pages.PtProposalHazardView.getTableCellData(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 468 | Medium |
| Dead store to row in edu.columbia.rascal.presentation.propTrak.pages.PtProposalHazardView.getTypes() | STYLE | DLS_DEAD_LOCAL_STORE | 539 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to docs in new edu.columbia.rascal.presentation.propTrak.pages.PtProposalLogOutView(Vector, RascalUser, String, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 52 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of selectAffils in edu.columbia.rascal.presentation.propTrak.pages.PtProposalNewView.addGeneralRows(CUHtmlTable, int) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 387 | Medium |
| Possible null pointer dereference of selectedCountries in edu.columbia.rascal.presentation.propTrak.pages.PtProposalNewView.addGeneralRows(CUHtmlTable, int) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 561 | Medium |
| edu.columbia.rascal.presentation.propTrak.pages.PtProposalNewView.addGeneralRows(CUHtmlTable, int) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 405 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to aCell in edu.columbia.rascal.presentation.propTrak.pages.PtProposalPrintPageView.setPONotesTableDataRow(CUHtmlTable) | STYLE | DLS_DEAD_LOCAL_STORE | 736 | Medium |
| Useless object stored in variable aBuffer of method edu.columbia.rascal.presentation.propTrak.pages.PtProposalPrintPageView.setPHS2590TableDataRow(CUHtmlTable) | STYLE | UC_USELESS_OBJECT | 666 | Medium |
| Useless object stored in variable aBuffer of method edu.columbia.rascal.presentation.propTrak.pages.PtProposalPrintPageView.setPHS398TableDataRow(CUHtmlTable) | STYLE | UC_USELESS_OBJECT | 700 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to docs in new edu.columbia.rascal.presentation.propTrak.pages.PtProposalSignoffView(Vector, RascalUser, String) | STYLE | DLS_DEAD_LOCAL_STORE | 54 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Boxed value is unboxed and then immediately reboxed in edu.columbia.rascal.presentation.propTrak.pages.PtProposalStatusHistoryView.getApprovalsTable() | PERFORMANCE | BX_UNBOXING_IMMEDIATELY_REBOXED | 366 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to parmString in edu.columbia.rascal.presentation.propTrak.pages.PtQueueCorrespondenceView.setTableDataRow(Hashtable, String) | STYLE | DLS_DEAD_LOCAL_STORE | 173 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to fiscalYear in edu.columbia.rascal.presentation.propTrak.pages.PtReportApprovalHistoryView.addDateRange() | STYLE | DLS_DEAD_LOCAL_STORE | 202 | Medium |
| Nullcheck of aString at line 656 of value previously dereferenced in edu.columbia.rascal.presentation.propTrak.pages.PtReportApprovalHistoryView.getWidgetFor(Float) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 654 | High |
| Unread public/protected field: edu.columbia.rascal.presentation.propTrak.pages.PtReportApprovalHistoryView.i | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 34 | Medium |
| Unused field: edu.columbia.rascal.presentation.propTrak.pages.PtReportApprovalHistoryView.deptName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from java.util.Vector to edu.columbia.rascal.presentation.common.CUSortVector in new edu.columbia.rascal.presentation.propTrak.pages.PtReportCancerCenterMemberView(Vector, String, boolean, boolean) | STYLE | BC_UNCONFIRMED_CAST | 94 | Medium |
| Unchecked/unconfirmed cast from java.util.Vector to edu.columbia.rascal.presentation.common.CUSortVector in edu.columbia.rascal.presentation.propTrak.pages.PtReportCancerCenterMemberView.addGeneralInformation(Vector) | STYLE | BC_UNCONFIRMED_CAST | 176 | Medium |
| Null pointer dereference of s in edu.columbia.rascal.presentation.propTrak.pages.PtReportCancerCenterMemberView.getColumnHeaderFor(CUSortVector) | CORRECTNESS | NP_ALWAYS_NULL | 223 | High |
| Load of known null value in edu.columbia.rascal.presentation.propTrak.pages.PtReportCancerCenterMemberView.getColumnHeaderFor(CUSortVector) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 223 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from java.util.Vector to edu.columbia.rascal.presentation.common.CUSortVector in new edu.columbia.rascal.presentation.propTrak.pages.PtReportCancerCenterView(Vector, boolean, String, String, String, boolean) | STYLE | BC_UNCONFIRMED_CAST | 105 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to usr in edu.columbia.rascal.presentation.propTrak.pages.PtReportDeptDateRangeView.getDeptNameWidget() | STYLE | DLS_DEAD_LOCAL_STORE | 269 | Medium |
| Possible null pointer dereference of allDept in edu.columbia.rascal.presentation.propTrak.pages.PtReportDeptDateRangeView.getDeptNameWidget() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 292 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.propTrak.pages.PtReportDeptView.addGeneralInformation(Vector, Vector) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 486 | High |
| Nullcheck of aString at line 941 of value previously dereferenced in edu.columbia.rascal.presentation.propTrak.pages.PtReportDeptView.getWidgetFor(Float) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 939 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.propTrak.pages.PtReportHazMatView.getTableCellData(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 484 | Medium |
| Dead store to columns in edu.columbia.rascal.presentation.propTrak.pages.PtReportHazMatView.addKey() | STYLE | DLS_DEAD_LOCAL_STORE | 291 | Medium |
| Dead store to noPrefixTrakId in edu.columbia.rascal.presentation.propTrak.pages.PtReportHazMatView.getProposalDataSheetLinkWidgetFor(String) | STYLE | DLS_DEAD_LOCAL_STORE | 433 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of aString at line 250 of value previously dereferenced in edu.columbia.rascal.presentation.propTrak.pages.PtReportResearchSummaryByUNIView.getWidgetFor(Float) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 248 | High |
| Unread public/protected field: edu.columbia.rascal.presentation.propTrak.pages.PtReportResearchSummaryByUNIView.beginDate | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 292 | Medium |
| Unused field: edu.columbia.rascal.presentation.propTrak.pages.PtReportResearchSummaryByUNIView.event | PERFORMANCE | UUF_UNUSED_FIELD | Medium | |
| Unused field: edu.columbia.rascal.presentation.propTrak.pages.PtReportResearchSummaryByUNIView.selectedCommittee | PERFORMANCE | UUF_UNUSED_FIELD | Medium | |
| Unused field: edu.columbia.rascal.presentation.propTrak.pages.PtReportResearchSummaryByUNIView.status | PERFORMANCE | UUF_UNUSED_FIELD | Medium | |
| Unused public or protected field: edu.columbia.rascal.presentation.propTrak.pages.PtReportResearchSummaryByUNIView.endDate | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to columns in edu.columbia.rascal.presentation.propTrak.pages.PtReportResearchSummaryView.addDeptInfo(Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 325 | High |
| Dead store to columns2 in edu.columbia.rascal.presentation.propTrak.pages.PtReportResearchSummaryView.addProposalsOverallSummary(Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 580 | High |
| Dead store to columns2 in edu.columbia.rascal.presentation.propTrak.pages.PtReportResearchSummaryView.addProtocolsOverallSummary(Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 830 | High |
| Dead store to row in edu.columbia.rascal.presentation.propTrak.pages.PtReportResearchSummaryView.addDeptInfo(Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 324 | Medium |
| Dead store to row2 in edu.columbia.rascal.presentation.propTrak.pages.PtReportResearchSummaryView.addProposalsOverallSummary(Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 579 | Medium |
| Dead store to row2 in edu.columbia.rascal.presentation.propTrak.pages.PtReportResearchSummaryView.addProtocolsOverallSummary(Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 829 | Medium |
| Boxing/unboxing to parse a primitive new edu.columbia.rascal.presentation.propTrak.pages.PtReportResearchSummaryView(String, String, Vector, Vector, Vector, Vector, Vector, Vector, Vector, Vector, Vector, Vector, boolean, boolean) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 180 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.propTrak.pages.PtReportSignoffView.getDurationFor(Date, Date), since all java.util.Date are instances of java.util.Date | STYLE | BC_VACUOUS_INSTANCEOF | 503 | Medium |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.propTrak.pages.PtReportSignoffView.getDurationFor(Date, Date) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 507 | High |
| Nullcheck of aString at line 692 of value previously dereferenced in edu.columbia.rascal.presentation.propTrak.pages.PtReportSignoffView.getWidgetFor(Float) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 690 | High |
| Unread public/protected field: edu.columbia.rascal.presentation.propTrak.pages.PtReportSignoffView.i | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 36 | Medium |
| Unread public/protected field: edu.columbia.rascal.presentation.propTrak.pages.PtReportSignoffView.indexOfDeadlineDate | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 39 | Medium |
| Unused field: edu.columbia.rascal.presentation.propTrak.pages.PtReportSignoffView.deptName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to begin in edu.columbia.rascal.presentation.propTrak.pages.PtReportSpogDataEntryView.addInformation() | STYLE | DLS_DEAD_LOCAL_STORE | 296 | Medium |
| Possible null pointer dereference of ptAgency in edu.columbia.rascal.presentation.propTrak.pages.PtReportSpogDataEntryView.addInformation() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 187 | Medium |
| Possible null pointer dereference of track in edu.columbia.rascal.presentation.propTrak.pages.PtReportSpogDataEntryView.addInformation() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 235 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of aString at line 461 of value previously dereferenced in edu.columbia.rascal.presentation.propTrak.pages.PtReportStatusView.getWidgetFor(Float) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 459 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to trakId in edu.columbia.rascal.presentation.propTrak.servlets.PtApprovalEntryServlet.submit() | STYLE | DLS_DEAD_LOCAL_STORE | 112 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.propTrak.servlets.PtApprovalRemoveServlet.getPage() invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 55 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.propTrak.servlets.PtAttachAnimalSubjectProtocolServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 111 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.propTrak.servlets.PtAttachIRBProtocolServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 147 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to businessObjectId in edu.columbia.rascal.presentation.propTrak.servlets.PtConflictOfInterestEditServlet.submit() | STYLE | DLS_DEAD_LOCAL_STORE | 58 | Medium |
| Dead store to businessObjectName in edu.columbia.rascal.presentation.propTrak.servlets.PtConflictOfInterestEditServlet.submit() | STYLE | DLS_DEAD_LOCAL_STORE | 59 | Medium |
| Dead store to userId in edu.columbia.rascal.presentation.propTrak.servlets.PtConflictOfInterestEditServlet.submit() | STYLE | DLS_DEAD_LOCAL_STORE | 57 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.propTrak.servlets.PtCorrespondenceCreateServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 284 | Medium |
| Redundant nullcheck of assPo which is known to be null in edu.columbia.rascal.presentation.propTrak.servlets.PtCorrespondenceCreateServlet.createRecipientForResearcher(PtCorrespondence, PtProposalHeader) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 121 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of aCorr in edu.columbia.rascal.presentation.propTrak.servlets.PtCorrespondenceDispositionServlet.getPage() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 68 | Medium |
| Nullcheck of aCorr at line 70 of value previously dereferenced in edu.columbia.rascal.presentation.propTrak.servlets.PtCorrespondenceDispositionServlet.getPage() | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 68 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of poRid in edu.columbia.rascal.presentation.propTrak.servlets.PtCorrespondenceRespondServlet.createRecipientForResearcher(PtCorrespondence, PtProposalHeader) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 131 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of ph at line 65 of value previously dereferenced in edu.columbia.rascal.presentation.propTrak.servlets.PtHazardRemoveServlet.getPage() | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 65 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.propTrak.servlets.PtIncomeSourceServlet.formatCheck(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 135 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to destination in edu.columbia.rascal.presentation.propTrak.servlets.PtLocationFilterServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 51 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of page, which is known to be non-null in edu.columbia.rascal.presentation.propTrak.servlets.PtLogoFrameServlet.doGet(HttpServletRequest, HttpServletResponse) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 59 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of directCost, which is known to be non-null in edu.columbia.rascal.presentation.propTrak.servlets.PtPHS398Servlet.setFormTXTEntireDirectCosts() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 619 | Medium |
| Redundant nullcheck of entireCosts, which is known to be non-null in edu.columbia.rascal.presentation.propTrak.servlets.PtPHS398Servlet.setFormTXTEntireTotalCosts() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 647 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to staffSize in edu.columbia.rascal.presentation.propTrak.servlets.PtParticipantEntryServlet.checkConflicts(RascalUser, PtProposalHeader, String, String, PtAccessControl, List) | STYLE | DLS_DEAD_LOCAL_STORE | 175 | Medium |
| Dead store to staffSize in edu.columbia.rascal.presentation.propTrak.servlets.PtParticipantEntryServlet.saveParticipantValues(RascalUser, PtProposalHeader, String, String, PtAccessControl, List, List) | STYLE | DLS_DEAD_LOCAL_STORE | 278 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of agencyName at line 86 of value previously dereferenced in edu.columbia.rascal.presentation.propTrak.servlets.PtProposalAgencyServlet.saveAgencyValues() | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 86 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in edu.columbia.rascal.presentation.propTrak.servlets.PtProposalCheckFinalizeServlet.getPage() | STYLE | REC_CATCH_EXCEPTION | 412 | Medium |
| edu.columbia.rascal.presentation.propTrak.servlets.PtProposalCheckFinalizeServlet.checkInvestigatorCOI() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 320 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to size in edu.columbia.rascal.presentation.propTrak.servlets.PtProposalCopyServlet.replicatePtAccessControlChildren(PtProposalHeader, PtProposalHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 442 | Medium |
| Dead store to size in edu.columbia.rascal.presentation.propTrak.servlets.PtProposalCopyServlet.replicatePtApprovalChildren(PtProposalHeader, PtProposalHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 519 | Medium |
| Dead store to size in edu.columbia.rascal.presentation.propTrak.servlets.PtProposalCopyServlet.replicatePtAttachDocumentsChildren(PtProposalHeader, PtProposalHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 543 | Medium |
| Dead store to size in edu.columbia.rascal.presentation.propTrak.servlets.PtProposalCopyServlet.replicatePtComplianceChildren(PtProposalHeader, PtProposalHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 575 | Medium |
| Dead store to size in edu.columbia.rascal.presentation.propTrak.servlets.PtProposalCopyServlet.replicatePtIncomeSourceChildren(PtProposalHeader, PtProposalHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 630 | Medium |
| Dead store to size in edu.columbia.rascal.presentation.propTrak.servlets.PtProposalCopyServlet.replicatePtInstitutionUsageChildren(PtProposalHeader, PtProposalHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 651 | Medium |
| Dead store to size in edu.columbia.rascal.presentation.propTrak.servlets.PtProposalCopyServlet.replicatePtSpaceChildren(PtProposalHeader, PtProposalHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 676 | Medium |
| Dead store to size in edu.columbia.rascal.presentation.propTrak.servlets.PtProposalCopyServlet.replicatePtSubAwardInstitutionChildren(PtProposalHeader, PtProposalHeader) | STYLE | DLS_DEAD_LOCAL_STORE | 701 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.propTrak.servlets.PtProposalFundingServlet.saveFundingValues() invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 261 | Medium |
| edu.columbia.rascal.presentation.propTrak.servlets.PtProposalFundingServlet.formatCheck(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 68 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to trakId in edu.columbia.rascal.presentation.propTrak.servlets.PtProposalInstitutionUsageServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 50 | Medium |
| Null pointer dereference of out in edu.columbia.rascal.presentation.propTrak.servlets.PtProposalInstitutionUsageServlet.submit() on exception path | CORRECTNESS | NP_ALWAYS_NULL_EXCEPTION | 129 | High |
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.propTrak.servlets.PtProposalInstitutionUsageServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 129 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to anticipateInventionDiscovery in edu.columbia.rascal.presentation.propTrak.servlets.PtProposalNewServlet.saveProposalValues() | STYLE | DLS_DEAD_LOCAL_STORE | 94 | Medium |
| Dead store to cancerRelated in edu.columbia.rascal.presentation.propTrak.servlets.PtProposalNewServlet.saveProposalValues() | STYLE | DLS_DEAD_LOCAL_STORE | 88 | Medium |
| Dead store to deadline in edu.columbia.rascal.presentation.propTrak.servlets.PtProposalNewServlet.saveProposalValues() | STYLE | DLS_DEAD_LOCAL_STORE | 84 | Medium |
| Dead store to deadlineTime in edu.columbia.rascal.presentation.propTrak.servlets.PtProposalNewServlet.saveProposalValues() | STYLE | DLS_DEAD_LOCAL_STORE | 83 | Medium |
| Dead store to exportControl in edu.columbia.rascal.presentation.propTrak.servlets.PtProposalNewServlet.saveProposalValues() | STYLE | DLS_DEAD_LOCAL_STORE | 90 | Medium |
| Dead store to foreignNationalAssisting in edu.columbia.rascal.presentation.propTrak.servlets.PtProposalNewServlet.saveProposalValues() | STYLE | DLS_DEAD_LOCAL_STORE | 91 | Medium |
| Dead store to involvedShipment in edu.columbia.rascal.presentation.propTrak.servlets.PtProposalNewServlet.saveProposalValues() | STYLE | DLS_DEAD_LOCAL_STORE | 93 | Medium |
| Dead store to involvesSpaceInstitute in edu.columbia.rascal.presentation.propTrak.servlets.PtProposalNewServlet.saveProposalValues() | STYLE | DLS_DEAD_LOCAL_STORE | 87 | Medium |
| Dead store to originatingDepartment in edu.columbia.rascal.presentation.propTrak.servlets.PtProposalNewServlet.saveProposalValues() | STYLE | DLS_DEAD_LOCAL_STORE | 82 | Medium |
| Dead store to selectAgenda in edu.columbia.rascal.presentation.propTrak.servlets.PtProposalNewServlet.saveProposalValues() | STYLE | DLS_DEAD_LOCAL_STORE | 92 | Medium |
| Dead store to submitOtherAgency in edu.columbia.rascal.presentation.propTrak.servlets.PtProposalNewServlet.saveProposalValues() | STYLE | DLS_DEAD_LOCAL_STORE | 86 | Medium |
| Dead store to title in edu.columbia.rascal.presentation.propTrak.servlets.PtProposalNewServlet.saveProposalValues() | STYLE | DLS_DEAD_LOCAL_STORE | 95 | Medium |
| Dead store to usingCancerCenter in edu.columbia.rascal.presentation.propTrak.servlets.PtProposalNewServlet.saveProposalValues() | STYLE | DLS_DEAD_LOCAL_STORE | 89 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of view in edu.columbia.rascal.presentation.propTrak.servlets.PtProposalRascalSearchServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 116 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to dbLocation in edu.columbia.rascal.presentation.propTrak.servlets.PtProposalSignoffServlet.generateReturnedProposalEmail(String, RascalUser, RascalUser) | STYLE | DLS_DEAD_LOCAL_STORE | 139 | Medium |
| Class edu.columbia.rascal.presentation.propTrak.servlets.PtProposalSignoffServlet defines non-transient non-serializable instance field ptSnapshotService | BAD_PRACTICE | SE_BAD_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Call to equals(null) in edu.columbia.rascal.presentation.propTrak.servlets.PtReportApprovalHistoryServlet.getPage() | CORRECTNESS | EC_NULL_ARG | 124 | Medium |
| Exception is caught when Exception is not thrown in edu.columbia.rascal.presentation.propTrak.servlets.PtReportApprovalHistoryServlet.getPage() | STYLE | REC_CATCH_EXCEPTION | 195 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to reportFields in edu.columbia.rascal.presentation.propTrak.servlets.PtReportDeptDateRangeServlet.submit() | STYLE | DLS_DEAD_LOCAL_STORE | 72 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Call to equals(null) in edu.columbia.rascal.presentation.propTrak.servlets.PtReportDeptServlet.getPage() | CORRECTNESS | EC_NULL_ARG | 168 | Medium |
| Exception is caught when Exception is not thrown in edu.columbia.rascal.presentation.propTrak.servlets.PtReportDeptServlet.getPage() | STYLE | REC_CATCH_EXCEPTION | 261 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to row in edu.columbia.rascal.presentation.propTrak.servlets.PtReportHazMatServlet.getSelectedData(String, String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 51 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to results in edu.columbia.rascal.presentation.propTrak.servlets.PtReportResearchSummaryByUNIServlet.getSelectedData(String) | STYLE | DLS_DEAD_LOCAL_STORE | 96 | Medium |
| edu.columbia.rascal.presentation.propTrak.servlets.PtReportResearchSummaryByUNIServlet.getPage() invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 67 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to row in edu.columbia.rascal.presentation.propTrak.servlets.PtReportResearchSummaryServlet.getSelectedDataResearcherInfo(String) | STYLE | DLS_DEAD_LOCAL_STORE | 2341 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to reportFields in edu.columbia.rascal.presentation.propTrak.servlets.PtReportSelectFieldsServlet.submit() | STYLE | DLS_DEAD_LOCAL_STORE | 73 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to reportFields in edu.columbia.rascal.presentation.propTrak.servlets.PtReportSignoffDateRangeServlet.submit() | STYLE | DLS_DEAD_LOCAL_STORE | 76 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.propTrak.servlets.PtReportSignoffServlet.getAllData(String, String, Vector, RascalUser) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 103 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.propTrak.servlets.PtReportSignoffServlet.getSelectedData(String, String, Vector, RascalUser) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 182 | High |
| Call to equals(null) in edu.columbia.rascal.presentation.propTrak.servlets.PtReportSignoffServlet.getPage() | CORRECTNESS | EC_NULL_ARG | 226 | Medium |
| Exception is caught when Exception is not thrown in edu.columbia.rascal.presentation.propTrak.servlets.PtReportSignoffServlet.getPage() | STYLE | REC_CATCH_EXCEPTION | 303 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.propTrak.servlets.PtReportSpogDataEntryServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 81 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to reportFields in edu.columbia.rascal.presentation.propTrak.servlets.PtReportStatusDateRangeServlet.submit() | STYLE | DLS_DEAD_LOCAL_STORE | 70 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.propTrak.servlets.PtReportStatusServlet.getSelectedData(String, String, String, Vector) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 102 | Medium |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.propTrak.servlets.PtReportStatusServlet.getSelectedData(String, String, String, Vector) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 102 | High |
| Call to equals(null) in edu.columbia.rascal.presentation.propTrak.servlets.PtReportStatusServlet.getPage() | CORRECTNESS | EC_NULL_ARG | 196 | Medium |
| Exception is caught when Exception is not thrown in edu.columbia.rascal.presentation.propTrak.servlets.PtReportStatusServlet.getPage() | STYLE | REC_CATCH_EXCEPTION | 254 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.propTrak.servlets.PtSpaceEntryServlet.submit() might ignore java.io.IOException | BAD_PRACTICE | DE_MIGHT_IGNORE | 82 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.propTrak.servlets.PtSubAwardServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 102 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of ph in edu.columbia.rascal.presentation.propTrak.servlets.PtTrackingRemoveServlet.getPage() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 76 | Medium |
| Possible null pointer dereference of ph in edu.columbia.rascal.presentation.propTrak.servlets.PtTrackingRemoveServlet.getPage() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 76 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.propTrak.servlets.PtUpdateStatusServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 73 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Return value of String.concat(String) ignored in edu.columbia.rascal.presentation.propTrak.tools.PtTreeViewJsBuilder.buildTreeRecursively(Vector, StringBuffer, String, int) | CORRECTNESS | RV_RETURN_VALUE_IGNORED | 135 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Primitive value is boxed then unboxed to perform primitive coercion in edu.columbia.rascal.presentation.tc.jdbc.TCCourseQuery.getAllCourseListForUser(int) | PERFORMANCE | BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION | 87 | Medium |
| edu.columbia.rascal.presentation.tc.jdbc.TCCourseQuery.reportCourseAdminFor(String, String, String) uses the same code for two branches | STYLE | DB_DUPLICATE_BRANCHES | 1471 | Medium |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.tc.jdbc.TCCourseQuery.getAveragePassingScore(Long) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 442 | High |
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.tc.jdbc.TCCourseQuery.getAveragePassingScore(String) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 396 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.tc.jdbc.TCCourseQuery.getAllCourseListForUser(int) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 87 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.tc.jdbc.TCCourseQuery.getEHSCoursesExpiredForExceptionReportByTest(String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 706 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.tc.jdbc.TCCourseQuery.getEHSCoursesExpiredLastMonthForEmail() | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 775 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.tc.servlets.TCAbstractPopupServlet.writeWindowCloseAndExitScript() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 156 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of out at line 156 of value previously dereferenced in edu.columbia.rascal.presentation.tc.servlets.TCAccessControlEntryServlet.submit() | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 156 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null passed for non-null parameter of new edu.columbia.rascal.presentation.tc.views.TCAddTestScoresView(RascalUser, TccourseHeader) in edu.columbia.rascal.presentation.tc.servlets.TCAddTestScoresServlet.getPage() | CORRECTNESS | NP_NULL_PARAM_DEREF | 76 | Medium |
| Nullcheck of header at line 108 of value previously dereferenced in edu.columbia.rascal.presentation.tc.servlets.TCAddTestScoresServlet.submit() | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 108 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of testLocation in edu.columbia.rascal.presentation.tc.servlets.TCCourseNewServlet.saveCourseValues(TccourseHeader) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 199 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of tch at line 202 of value previously dereferenced in edu.columbia.rascal.presentation.tc.servlets.TCCourseRemoveServlet.getPage() | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 202 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null passed for non-null parameter of new edu.columbia.rascal.presentation.tc.views.TCCourseTestResultsView(TccourseHeader, boolean, Vector, RascalUser) in edu.columbia.rascal.presentation.tc.servlets.TCCourseTestResultsServlet.getPage() | CORRECTNESS | NP_NULL_PARAM_DEREF | 71 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of aString, which is known to be non-null in edu.columbia.rascal.presentation.tc.servlets.TCDivisionEntryServlet.formatCheck(String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 251 | Medium |
| edu.columbia.rascal.presentation.tc.servlets.TCDivisionEntryServlet.formatCheck(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 257 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null passed for non-null parameter of new edu.columbia.rascal.presentation.tc.views.TCGenerateCertificateView(String, TcuserHeader, RascalUser, boolean) in edu.columbia.rascal.presentation.tc.servlets.TCGenerateCertificateServlet.getPage() | CORRECTNESS | NP_NULL_PARAM_DEREF | 78 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of objPage, which is known to be non-null in edu.columbia.rascal.presentation.tc.servlets.TCGeneratePDFCertificateServlet.doGet(HttpServletRequest, HttpServletResponse) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 67 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null passed for non-null parameter of new edu.columbia.rascal.presentation.tc.views.TCGeneratePDFTranscriptView(List, RascalUser, String) in edu.columbia.rascal.presentation.tc.servlets.TCGeneratePDFTranscriptServlet.getPDFPage() | CORRECTNESS | NP_NULL_PARAM_DEREF | 150 | Medium |
| Redundant nullcheck of objPage, which is known to be non-null in edu.columbia.rascal.presentation.tc.servlets.TCGeneratePDFTranscriptServlet.doGet(HttpServletRequest, HttpServletResponse) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 69 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to expiredCourses in edu.columbia.rascal.presentation.tc.servlets.TCMainMenuServlet.getExpiredCourses() | STYLE | DLS_DEAD_LOCAL_STORE | 145 | Medium |
| Dead store to courseInfo in edu.columbia.rascal.presentation.tc.servlets.TCMainMenuServlet.getRequiredCourses() | STYLE | DLS_DEAD_LOCAL_STORE | 69 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Load of known null value in edu.columbia.rascal.presentation.tc.servlets.TCQuestionServlet.getPage() | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 59 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.tc.servlets.TCReferenceEntryServlet.formatCheck(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 224 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of tch in edu.columbia.rascal.presentation.tc.servlets.TCReferenceRemoveServlet.getPage() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 83 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.tc.servlets.TCReportAdminByDeptEntryServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 143 | Medium |
| Nullcheck of out at line 143 of value previously dereferenced in edu.columbia.rascal.presentation.tc.servlets.TCReportAdminByDeptEntryServlet.submit() | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 143 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of ru in edu.columbia.rascal.presentation.tc.servlets.TCReportAdminByDeptInactiveServlet.submit() | CORRECTNESS | NP_NULL_ON_SOME_PATH | 99 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to out in edu.columbia.rascal.presentation.tc.servlets.TCReportAdminByDeptTcUserEHSServlet.submit() | STYLE | DLS_DEAD_LOCAL_STORE | 135 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to deptCode in edu.columbia.rascal.presentation.tc.servlets.TCReportByDeptAndLocationServlet.submit() | STYLE | DLS_DEAD_LOCAL_STORE | 246 | Medium |
| Dead store to location in edu.columbia.rascal.presentation.tc.servlets.TCReportByDeptAndLocationServlet.submit() | STYLE | DLS_DEAD_LOCAL_STORE | 247 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of rows, which is known to be non-null in edu.columbia.rascal.presentation.tc.servlets.TCReportCourseAdminServlet.getPage() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 89 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to columns in edu.columbia.rascal.presentation.tc.servlets.TCReportEHSExceptionByTestServlet.getColumnData(Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 52 | Medium |
| Dead store to deptString in edu.columbia.rascal.presentation.tc.servlets.TCReportEHSExceptionByTestServlet.getColumnData(Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 51 | Medium |
| edu.columbia.rascal.presentation.tc.servlets.TCReportEHSExceptionByTestServlet.getPage() invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 133 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.tc.servlets.TCReportTestQuestionStatsServlet.getPage() invokes inefficient new String() constructor | PERFORMANCE | DM_STRING_VOID_CTOR | 75 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to course in edu.columbia.rascal.presentation.tc.servlets.TCReportTestSelectionServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 58 | Medium |
| Dead store to courseInfo in edu.columbia.rascal.presentation.tc.servlets.TCReportTestSelectionServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 60 | Medium |
| Dead store to tests in edu.columbia.rascal.presentation.tc.servlets.TCReportTestSelectionServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 57 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to pageType in edu.columbia.rascal.presentation.tc.servlets.TCRequiredCourseEntryServlet.getPage() | STYLE | DLS_DEAD_LOCAL_STORE | 65 | Medium |
| edu.columbia.rascal.presentation.tc.servlets.TCRequiredCourseEntryServlet.formatCheck(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 245 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization and update of static field edu.columbia.rascal.presentation.tc.tools.TCEmailEHSRequiredCourseMonthlyMonitor.timer in edu.columbia.rascal.presentation.tc.tools.TCEmailEHSRequiredCourseMonthlyMonitor.start() | MT_CORRECTNESS | LI_LAZY_INIT_UPDATE_STATIC | 58 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to courseInfo in edu.columbia.rascal.presentation.tc.tools.TCEmailEHSRequiredCourseTask.generateExpiredNotificationEmails(List) | STYLE | DLS_DEAD_LOCAL_STORE | 110 | Medium |
| Dead store to courseInfo in edu.columbia.rascal.presentation.tc.tools.TCEmailEHSRequiredCourseTask.generateExpiringNotificationEmails(List) | STYLE | DLS_DEAD_LOCAL_STORE | 185 | Medium |
| Null passed for non-null parameter of edu.columbia.rascal.presentation.tools.emailDistributor.CURascalEmailSender.sendEmail(CURascalEmailMessage) in edu.columbia.rascal.presentation.tc.tools.TCEmailEHSRequiredCourseTask.sendExpiredEmail(String, String, String, String, List) | CORRECTNESS | NP_NULL_PARAM_DEREF | 508 | Medium |
| Null passed for non-null parameter of edu.columbia.rascal.presentation.tools.emailDistributor.CURascalEmailSender.sendEmail(CURascalEmailMessage) in edu.columbia.rascal.presentation.tc.tools.TCEmailEHSRequiredCourseTask.sendExpiringEmail(String, String, String, List) | CORRECTNESS | NP_NULL_PARAM_DEREF | 581 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization and update of static field edu.columbia.rascal.presentation.tc.tools.TCEmailRequiredCourse30DaysWarningMonitor.timer in edu.columbia.rascal.presentation.tc.tools.TCEmailRequiredCourse30DaysWarningMonitor.start() | MT_CORRECTNESS | LI_LAZY_INIT_UPDATE_STATIC | 58 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null passed for non-null parameter of edu.columbia.rascal.presentation.tools.emailDistributor.CURascalEmailSender.sendEmail(CURascalEmailMessage) in edu.columbia.rascal.presentation.tc.tools.TCEmailRequiredCourse30DaysWarningTask.generateRascalEmails(List) | CORRECTNESS | NP_NULL_PARAM_DEREF | 277 | Medium |
| Useless object stored in variable message of method edu.columbia.rascal.presentation.tc.tools.TCEmailRequiredCourse30DaysWarningTask.generateRascalEmails(List) | STYLE | UC_USELESS_OBJECT | 222 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization and update of static field edu.columbia.rascal.presentation.tc.tools.TCEmailRequiredCourse60DaysWarningMonitor.timer in edu.columbia.rascal.presentation.tc.tools.TCEmailRequiredCourse60DaysWarningMonitor.start() | MT_CORRECTNESS | LI_LAZY_INIT_UPDATE_STATIC | 57 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null passed for non-null parameter of edu.columbia.rascal.presentation.tools.emailDistributor.CURascalEmailSender.sendEmail(CURascalEmailMessage) in edu.columbia.rascal.presentation.tc.tools.TCEmailRequiredCourse60DaysWarningTask.generateRascalEmails(List) | CORRECTNESS | NP_NULL_PARAM_DEREF | 260 | Medium |
| Useless object stored in variable message of method edu.columbia.rascal.presentation.tc.tools.TCEmailRequiredCourse60DaysWarningTask.generateRascalEmails(List) | STYLE | UC_USELESS_OBJECT | 207 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization and update of static field edu.columbia.rascal.presentation.tc.tools.TCEmailRequiredCourseExpireMonitor.timer in edu.columbia.rascal.presentation.tc.tools.TCEmailRequiredCourseExpireMonitor.start() | MT_CORRECTNESS | LI_LAZY_INIT_UPDATE_STATIC | 55 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null passed for non-null parameter of edu.columbia.rascal.presentation.tools.emailDistributor.CURascalEmailSender.sendEmail(CURascalEmailMessage) in edu.columbia.rascal.presentation.tc.tools.TCEmailRequiredCourseExpireTask.generateRascalEmails(List, int) | CORRECTNESS | NP_NULL_PARAM_DEREF | 316 | Medium |
| Useless object stored in variable buff of method edu.columbia.rascal.presentation.tc.tools.TCEmailRequiredCourseExpireTask.generateExpireEmails(List, int) | STYLE | UC_USELESS_OBJECT | 243 | Medium |
| Useless object stored in variable message of method edu.columbia.rascal.presentation.tc.tools.TCEmailRequiredCourseExpireTask.generateRascalEmails(List, int) | STYLE | UC_USELESS_OBJECT | 269 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization and update of static field edu.columbia.rascal.presentation.tc.tools.TCEmailRequiredCourseNotifyMonitor.timer in edu.columbia.rascal.presentation.tc.tools.TCEmailRequiredCourseNotifyMonitor.start() | MT_CORRECTNESS | LI_LAZY_INIT_UPDATE_STATIC | 54 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Null passed for non-null parameter of edu.columbia.rascal.presentation.tools.emailDistributor.CURascalEmailSender.sendEmail(CURascalEmailMessage) in edu.columbia.rascal.presentation.tc.tools.TCEmailRequiredCourseNotifyTask.generateRascalEmails(List) | CORRECTNESS | NP_NULL_PARAM_DEREF | 310 | Medium |
| Useless object stored in variable message of method edu.columbia.rascal.presentation.tc.tools.TCEmailRequiredCourseNotifyTask.generateRascalEmails(List) | STYLE | UC_USELESS_OBJECT | 249 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| VERY confusing to have methods edu.columbia.rascal.presentation.tc.views.TCAccessControlView.getRowLabelleftFor(String) and edu.columbia.rascal.presentation.tc.views.TCHtmlView.getRowLabelLeftFor(String) | CORRECTNESS | NM_VERY_CONFUSING | 204 | Medium |
| Useless object stored in variable columns of method edu.columbia.rascal.presentation.tc.views.TCAccessControlView.buildControlRows(Vector) | STYLE | UC_USELESS_OBJECT | 160 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to elements in edu.columbia.rascal.presentation.tc.views.TCCourseDataSheetView.addDataCourseHeader1() | STYLE | DLS_DEAD_LOCAL_STORE | 182 | High |
| Dead store to elements in edu.columbia.rascal.presentation.tc.views.TCCourseDataSheetView.addSectionTitle(String, String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 561 | High |
| Dead store to elements in edu.columbia.rascal.presentation.tc.views.TCCourseDataSheetView.addAnswerRows(CUHtmlTable, Vector) | STYLE | DLS_DEAD_LOCAL_STORE | 86 | Medium |
| Nullcheck of date at line 756 of value previously dereferenced in edu.columbia.rascal.presentation.tc.views.TCCourseDataSheetView.toDateString(Date) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 754 | Medium |
| Unread field: edu.columbia.rascal.presentation.tc.views.TCCourseDataSheetView.currentUserUni | PERFORMANCE | URF_UNREAD_FIELD | 715 | Medium |
| Unused field: edu.columbia.rascal.presentation.tc.views.TCCourseDataSheetView.subTitle | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: edu.columbia.rascal.presentation.tc.views.TCCourseReferenceView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of mainStudyUrl at line 34 of value previously dereferenced in new edu.columbia.rascal.presentation.tc.views.TCCourseStudyContentView(TccourseHeader) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 34 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.tc.views.TCCourseTestView.addQuestionRows(CUHtmlTable, int) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 256 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: edu.columbia.rascal.presentation.tc.views.TCDivisionView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: edu.columbia.rascal.presentation.tc.views.TCGenerateCertificateView.aForm | PERFORMANCE | URF_UNREAD_FIELD | 31 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| stream is null guaranteed to be dereferenced in edu.columbia.rascal.presentation.tc.views.TCGeneratePDFCertificateView.addCertificateContent(String, String, String, String) on exception path | CORRECTNESS | NP_GUARANTEED_DEREF_ON_EXCEPTION_PATH | 182 | Medium |
| stream2 is null guaranteed to be dereferenced in edu.columbia.rascal.presentation.tc.views.TCGeneratePDFCertificateView.addCertificateContent(String, String, String, String) on exception path | CORRECTNESS | NP_GUARANTEED_DEREF_ON_EXCEPTION_PATH | 183 | Medium |
| Exception is caught when Exception is not thrown in edu.columbia.rascal.presentation.tc.views.TCGeneratePDFCertificateView.addCertificateContent(String, String, String, String) | STYLE | REC_CATCH_EXCEPTION | 177 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: edu.columbia.rascal.presentation.tc.views.TCGeneratePDFTranscriptView.datePassed | PERFORMANCE | URF_UNREAD_FIELD | 36 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.tc.views.TCHtmlView.getDateTable(String, String, String, String, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 211 | High |
| Field TCHtmlView.labelName masks field in superclass edu.columbia.rascal.presentation.common.views.CURascalHtmlView | CORRECTNESS | MF_CLASS_MASKS_FIELD | High | |
| Nullcheck of selectedItem at line 843 of value previously dereferenced in edu.columbia.rascal.presentation.tc.views.TCHtmlView.getSelectWidget(Vector, String, String, boolean) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 843 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to aRow in edu.columbia.rascal.presentation.tc.views.TCMainMenuView.addExpiredCourses(List, CUHtmlTable) | STYLE | DLS_DEAD_LOCAL_STORE | 306 | Medium |
| Dead store to aRow in edu.columbia.rascal.presentation.tc.views.TCMainMenuView.addRequiredCourses(Vector, CUHtmlTable) | STYLE | DLS_DEAD_LOCAL_STORE | 249 | Medium |
| Dead store to aCell in edu.columbia.rascal.presentation.tc.views.TCMainMenuView.addTableHeaders(CUHtmlTable) | STYLE | DLS_DEAD_LOCAL_STORE | 219 | Medium |
| Dead store to titleLen in edu.columbia.rascal.presentation.tc.views.TCMainMenuView.getColumns() | STYLE | DLS_DEAD_LOCAL_STORE | 362 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.tc.views.TCReportAdminByDeptInactiveView.getInstruction(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 383 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.tc.views.TCReportAdminByDeptView.getInstruction(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 452 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.tc.views.TCReportByDeptAndLocationView.getInstruction(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 265 | Medium |
| Useless object stored in variable allUser of method edu.columbia.rascal.presentation.tc.views.TCReportByDeptAndLocationView.getReportTable(Vector, Vector, int) | STYLE | UC_USELESS_OBJECT | 391 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.tc.views.TCReportByDeptFilterByJobCodeView.getInstruction(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 304 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.tc.views.TCReportByDeptView.getInstruction(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 246 | Medium |
| Useless object stored in variable allUser of method edu.columbia.rascal.presentation.tc.views.TCReportByDeptView.getReportTable(Vector, Vector, int) | STYLE | UC_USELESS_OBJECT | 374 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from java.util.Vector<java.lang.Object> to edu.columbia.rascal.presentation.common.CUSortVector in edu.columbia.rascal.presentation.tc.views.TCReportCourseAdminView.addGeneralInformation(Vector) | STYLE | BC_UNCONFIRMED_CAST | 238 | Medium |
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.tc.views.TCReportCourseAdminView.getInstruction(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 295 | Medium |
| Nullcheck of rows at line 83 of value previously dereferenced in new edu.columbia.rascal.presentation.tc.views.TCReportCourseAdminView(CUSortVector, TccourseHeader, String, String, RascalUser, Vector, boolean, boolean, String) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 77 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread public/protected field: edu.columbia.rascal.presentation.tc.views.TCReportDeptSelectionForExceptionView.passKerberos | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 31 | Medium |
| Unused field: edu.columbia.rascal.presentation.tc.views.TCReportDeptSelectionForExceptionView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread public/protected field: edu.columbia.rascal.presentation.tc.views.TCReportDeptSelectionView.passKerberos | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 33 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from java.util.Vector to edu.columbia.rascal.presentation.common.CUSortVector in new edu.columbia.rascal.presentation.tc.views.TCReportEHSExceptionByTestView(Vector, boolean, String, boolean, String, String) | STYLE | BC_UNCONFIRMED_CAST | 110 | Medium |
| Unchecked/unconfirmed cast from java.util.Vector to edu.columbia.rascal.presentation.common.CUSortVector in edu.columbia.rascal.presentation.tc.views.TCReportEHSExceptionByTestView.getReportTable(Vector) | STYLE | BC_UNCONFIRMED_CAST | 277 | Medium |
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.tc.views.TCReportEHSExceptionByTestView.getInstruction(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 240 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.tc.views.TCReportSelectFieldsView.getDateTable(String, String, String, String, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 301 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.tc.views.TCReportSelectFieldsView.getYearWidget(String, int) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 401 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unchecked/unconfirmed cast from java.util.Vector<java.lang.Object> to edu.columbia.rascal.presentation.common.CUSortVector in new edu.columbia.rascal.presentation.tc.views.TCReportTestQuestionStatsView(Vector, TccourseHeader, RascalUser, Vector, boolean, boolean, String) | STYLE | BC_UNCONFIRMED_CAST | 117 | Medium |
| Unchecked/unconfirmed cast from java.util.Vector<java.lang.Object> to edu.columbia.rascal.presentation.common.CUSortVector in edu.columbia.rascal.presentation.tc.views.TCReportTestQuestionStatsView.addGeneralInformation(Vector) | STYLE | BC_UNCONFIRMED_CAST | 222 | Medium |
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.tc.views.TCReportTestQuestionStatsView.getInstruction(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 284 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.tc.views.TCReportTestRequirementExceptionView.getInstruction(String), since all String are instances of String | STYLE | BC_VACUOUS_INSTANCEOF | 268 | Medium |
| Unused public or protected field: edu.columbia.rascal.presentation.tc.views.TCReportTestRequirementExceptionView.deptLocationCode | STYLE | UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread public/protected field: edu.columbia.rascal.presentation.tc.views.TCReportUNISelectionView.passKerberos | STYLE | URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD | 27 | Medium |
| Unused field: edu.columbia.rascal.presentation.tc.views.TCReportUNISelectionView.labelName | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in edu.columbia.rascal.presentation.tools.emailDistributor.CURascalEmailSender.openConnection(): new java.io.PrintWriter(OutputStream) | I18N | DM_DEFAULT_ENCODING | 92 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.tools.emailDistributor.CURascalJavaMailMonitor.isTestingMonitor() invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead | PERFORMANCE | DM_BOOLEAN_CTOR | 326 | Medium |
| Result of integer multiplication cast to long in edu.columbia.rascal.presentation.tools.emailDistributor.CURascalJavaMailMonitor.getPeriodInMillisByTask(int) | STYLE | ICAST_INTEGER_MULTIPLY_CAST_TO_LONG | 144 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Primitive boxed just to call toString in new edu.columbia.rascal.presentation.tools.emailDistributor.CURascalJavaMailSender() | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 77 | High |
| Primitive boxed just to call toString in new edu.columbia.rascal.presentation.tools.emailDistributor.CURascalJavaMailSender(String, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 121 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: edu.columbia.rascal.presentation.tools.htmlGen.CUHtmlActionItem.label | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.tools.htmlGen.CUHtmlImage.setHtmlAttributes() | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 133 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new edu.columbia.rascal.presentation.tools.htmlGen.CUHtmlMoveToSelectList(String, Vector, String, Vector, String, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 92 | Medium |
| new edu.columbia.rascal.presentation.tools.htmlGen.CUHtmlMoveToSelectList(String, Vector, String, Vector, String, String, int) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 263 | Medium |
| new edu.columbia.rascal.presentation.tools.htmlGen.CUHtmlMoveToSelectList(String, Vector, String, Vector, String, String, int, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 440 | Medium |
| new edu.columbia.rascal.presentation.tools.htmlGen.CUHtmlMoveToSelectList(String, Vector, String, Vector, String, String, String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 615 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unused field: edu.columbia.rascal.presentation.tools.htmlGen.CUHtmlNoFrames.columns | PERFORMANCE | UUF_UNUSED_FIELD | Medium | |
| Unused field: edu.columbia.rascal.presentation.tools.htmlGen.CUHtmlNoFrames.rows | PERFORMANCE | UUF_UNUSED_FIELD | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in edu.columbia.rascal.presentation.tools.htmlGen.CUHtmlPage.getJSCodeFrom(String): new java.io.FileReader(File) | I18N | DM_DEFAULT_ENCODING | 199 | High |
| Possible null pointer dereference of fr in edu.columbia.rascal.presentation.tools.htmlGen.CUHtmlPage.getJSCodeFrom(String) on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 210 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new edu.columbia.rascal.presentation.tools.htmlGen.CUHtmlPushButton(String) invokes inefficient new Character(char) constructor; use Character.valueOf(char) instead | PERFORMANCE | DM_NUMBER_CTOR | 51 | Medium |
| Return value of new Character(char) ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 51 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| new edu.columbia.rascal.presentation.tools.htmlGen.CUHtmlRadioButtonSet(Map, String, String, boolean) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 202 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.tools.htmlGen.CUHtmlTable.setHtmlAttributes() | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 234 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.tools.htmlGen.CUHtmlTableCell.setHtmlAttributes() | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 113 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.tools.htmlGen.attributes.CUHtmlAttribute.colors isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 23 | High |
| edu.columbia.rascal.presentation.tools.htmlGen.attributes.CUHtmlAttribute.getValueString() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 217 | Medium |
| edu.columbia.rascal.presentation.tools.htmlGen.attributes.CUHtmlAttribute.getKeys() makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 168 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: edu.columbia.rascal.presentation.tools.htmlGen.attributes.CUHtmlTitle.stringValue | PERFORMANCE | URF_UNREAD_FIELD | 17 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in edu.columbia.rascal.presentation.user.servlets.CURascalUserAbstractServlet.doGet(HttpServletRequest, HttpServletResponse), since all edu.columbia.rascal.presentation.common.views.CURascalHtmlView are instances of edu.columbia.rascal.presentation.common.views.CURascalHtmlView | STYLE | BC_VACUOUS_INSTANCEOF | 70 | Medium |
| A known null value is checked to see if it is an instance of edu.columbia.rascal.presentation.common.views.CURascalMessageView in edu.columbia.rascal.presentation.user.servlets.CURascalUserAbstractServlet.doGet(HttpServletRequest, HttpServletResponse) | CORRECTNESS | NP_NULL_INSTANCEOF | 76 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.user.servlets.CURascalUserMoreInfoServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 52 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.user.servlets.CoiAddConflictInterestServlet.submit() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 90 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.user.servlets.RuAbstractServlet.getIndexOf(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 258 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.user.servlets.RuICMExperimentalSurgeryTrainingEntryServlet.redirectToOpener() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 53 | Medium |
| Switch statement found in edu.columbia.rascal.presentation.user.servlets.RuICMExperimentalSurgeryTrainingEntryServlet.saveData() where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 105 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.user.servlets.RuOccupationalHealthProgramEntryServlet.redirectToOpener() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 49 | Medium |
| Switch statement found in edu.columbia.rascal.presentation.user.servlets.RuOccupationalHealthProgramEntryServlet.saveData() where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 105 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.user.servlets.RuRadiationSafetyBadgeEntryServlet.redirectToOpener() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 45 | Medium |
| Switch statement found in edu.columbia.rascal.presentation.user.servlets.RuRadiationSafetyBadgeEntryServlet.saveData() where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 83 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.user.servlets.RuSimpleTrainingBBPOEntryServlet.redirectToOpener() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 49 | Medium |
| Switch statement found in edu.columbia.rascal.presentation.user.servlets.RuSimpleTrainingBBPOEntryServlet.saveData() where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 96 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of out in edu.columbia.rascal.presentation.user.servlets.RuSimpleTrainingLSCHOEntryServlet.redirectToOpener() on exception path | CORRECTNESS | NP_NULL_ON_SOME_PATH_EXCEPTION | 49 | Medium |
| Switch statement found in edu.columbia.rascal.presentation.user.servlets.RuSimpleTrainingLSCHOEntryServlet.saveData() where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 96 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to values in edu.columbia.rascal.presentation.user.views.CUInfoHtmlView.render() | STYLE | DLS_DEAD_LOCAL_STORE | 285 | High |
| Dead store to e in edu.columbia.rascal.presentation.user.views.CUInfoHtmlView.render() | STYLE | DLS_DEAD_LOCAL_STORE | 269 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of ruDept at line 116 of value previously dereferenced in edu.columbia.rascal.presentation.user.views.CURascalDepartmentAuthorizationAddView.addDepartmentRows(CUHtmlTable) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 116 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to values in edu.columbia.rascal.presentation.user.views.CuHtmlView.render() | STYLE | DLS_DEAD_LOCAL_STORE | 336 | High |
| Field CuHtmlView.labelName masks field in superclass edu.columbia.rascal.presentation.common.views.CURascalHtmlView | CORRECTNESS | MF_CLASS_MASKS_FIELD | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Switch statement found in edu.columbia.rascal.presentation.user.views.RuCertificationAbstractEntryView.addSubTitle() where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 110 | Medium |
| Switch statement found in edu.columbia.rascal.presentation.user.views.RuCertificationAbstractEntryView.getActionButtons(String) where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 154 | Medium |
| Unread field: edu.columbia.rascal.presentation.user.views.RuCertificationAbstractEntryView.adminUser | PERFORMANCE | URF_UNREAD_FIELD | 45 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Boxing/unboxing to parse a primitive edu.columbia.rascal.presentation.user.views.RuHtmlView.getDateTable(String, String, String, String, String) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 170 | High |
| Primitive boxed just to call toString in edu.columbia.rascal.presentation.user.views.RuHtmlView.getYearWidget(String, int) | PERFORMANCE | DM_BOXED_PRIMITIVE_TOSTRING | 429 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to dataRow in edu.columbia.rascal.presentation.user.views.RuSimpleTrainingEnrollmentAdminView.getOnClickToModifyCertification(Object) | STYLE | DLS_DEAD_LOCAL_STORE | 359 | Medium |
| Null passed for non-null parameter of new java.util.Vector(Collection) in edu.columbia.rascal.presentation.user.views.RuSimpleTrainingEnrollmentAdminView.extractCertsByType() | CORRECTNESS | NP_NULL_PARAM_DEREF | 249 | Medium |
| Switch statement found in edu.columbia.rascal.presentation.user.views.RuSimpleTrainingEnrollmentAdminView.extractCertsByType() where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 236 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| edu.columbia.rascal.presentation.validators.irb.IrbFutureUseValidator.validate(Object, Errors) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 64 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to ip in edu.columbia.rascal.presentation.validators.irb.IrbProtocolImagingProcedureValidator.validate(Object, Errors) | STYLE | DLS_DEAD_LOCAL_STORE | 48 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of target, which is known to be non-null in edu.columbia.rascal.presentation.validators.irb.IrbRisksBenefitsValidator.validate(Object, Errors) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 52 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class name edu.columbia.rascal.presentation.validators.irb.irbDrugsBiologicsAttachmentValidator doesn't start with an upper case letter | BAD_PRACTICE | NM_CLASS_NAMING_CONVENTION | 21 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to confHeader in edu.columbia.rascal.presentation.validators.pt.PtCoiValidator.validate(Object, Errors) | STYLE | DLS_DEAD_LOCAL_STORE | 34 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to currentUser in edu.columbia.rascal.presentation.validators.pt.PtDeleteValidator.validate(Object, Errors) | STYLE | DLS_DEAD_LOCAL_STORE | 50 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of type in edu.columbia.rascal.presentation.validators.pt.PtProposalFinalizeValidator.validate(Object, Errors) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 161 | Medium |
| edu.columbia.rascal.presentation.validators.pt.PtProposalFinalizeValidator.validate(Object, Errors) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 207 | Medium |
